pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove useless Assert. 2+ messages / 2 participants [nested] [flat]
* pgsql: Remove useless Assert. @ 2020-08-09 15:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2020-08-09 15:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove useless Assert. Testing that an unsigned variable is >= 0 is pretty pointless, as noted by Coverity and numerous buildfarm members. In passing, add comment about new uses of "volatile" --- Coverity doesn't much like that either, but it seems probably necessary. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1c164ef3d28dfab445a885a03e80cfd0d552f64a Modified Files -------------- src/backend/replication/logical/reorderbuffer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Remove useless Assert @ 2024-01-14 06:38 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2024-01-14 06:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove useless Assert It's already included in the subsequent intVal() call. Fixup for 4f622503d6. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e3aa802e6f843fc8df793d2dccdafecc32fe2cfc Modified Files -------------- src/backend/commands/tablecmds.c | 1 - 1 file changed, 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-01-14 06:38 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-08-09 15:32 pgsql: Remove useless Assert. Tom Lane <tgl@sss.pgh.pa.us> 2024-01-14 06:38 pgsql: Remove useless Assert Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox