pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix incorrect comment on how BackendStatusArray is indexed 4+ messages / 1 participants [nested] [flat]
* pgsql: Fix incorrect comment on how BackendStatusArray is indexed @ 2024-01-17 13:57 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 4+ messages in thread From: Heikki Linnakangas @ 2024-01-17 13:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect comment on how BackendStatusArray is indexed The comment was copy-pasted from the call to ProcSignalInit() in AuxiliaryProcessMain(), which uses a similar scheme of having reserved slots for aux processes after MaxBackends slots for backends. However, ProcSignalInit() indexing starts from 1, whereas BackendStatusArray starts from 0. The code is correct, but the comment was wrong. Discussion: https://www.postgresql.org/message-id/f3ecd4cb-85ee-4e54-8278-5fabfb3a4ed0@iki.fi Backpatch-through: v14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/2b53a462cff0074f5bf1675ad58ca95190c4bcd0 Modified Files -------------- src/backend/utils/activity/backend_status.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix incorrect comment on how BackendStatusArray is indexed @ 2024-01-17 13:57 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 4+ messages in thread From: Heikki Linnakangas @ 2024-01-17 13:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect comment on how BackendStatusArray is indexed The comment was copy-pasted from the call to ProcSignalInit() in AuxiliaryProcessMain(), which uses a similar scheme of having reserved slots for aux processes after MaxBackends slots for backends. However, ProcSignalInit() indexing starts from 1, whereas BackendStatusArray starts from 0. The code is correct, but the comment was wrong. Discussion: https://www.postgresql.org/message-id/f3ecd4cb-85ee-4e54-8278-5fabfb3a4ed0@iki.fi Backpatch-through: v14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4cf9ef670e4cb6c73aeaec8c1939f4aa26358353 Modified Files -------------- src/backend/utils/activity/backend_status.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix incorrect comment on how BackendStatusArray is indexed @ 2024-01-17 13:57 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 4+ messages in thread From: Heikki Linnakangas @ 2024-01-17 13:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect comment on how BackendStatusArray is indexed The comment was copy-pasted from the call to ProcSignalInit() in AuxiliaryProcessMain(), which uses a similar scheme of having reserved slots for aux processes after MaxBackends slots for backends. However, ProcSignalInit() indexing starts from 1, whereas BackendStatusArray starts from 0. The code is correct, but the comment was wrong. Discussion: https://www.postgresql.org/message-id/f3ecd4cb-85ee-4e54-8278-5fabfb3a4ed0@iki.fi Backpatch-through: v14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/90ccc9bf90a917037f9cd451ce4c10fb9704924e Modified Files -------------- src/backend/utils/activity/backend_status.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix incorrect comment on how BackendStatusArray is indexed @ 2024-01-17 13:57 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 4+ messages in thread From: Heikki Linnakangas @ 2024-01-17 13:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect comment on how BackendStatusArray is indexed The comment was copy-pasted from the call to ProcSignalInit() in AuxiliaryProcessMain(), which uses a similar scheme of having reserved slots for aux processes after MaxBackends slots for backends. However, ProcSignalInit() indexing starts from 1, whereas BackendStatusArray starts from 0. The code is correct, but the comment was wrong. Discussion: https://www.postgresql.org/message-id/f3ecd4cb-85ee-4e54-8278-5fabfb3a4ed0@iki.fi Backpatch-through: v14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/28215a32b5154e11574b6e924519b0fb8be4b041 Modified Files -------------- src/backend/utils/activity/backend_status.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-01-17 13:57 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-01-17 13:57 pgsql: Fix incorrect comment on how BackendStatusArray is indexed Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-01-17 13:57 pgsql: Fix incorrect comment on how BackendStatusArray is indexed Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-01-17 13:57 pgsql: Fix incorrect comment on how BackendStatusArray is indexed Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-01-17 13:57 pgsql: Fix incorrect comment on how BackendStatusArray is indexed Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox