pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Improve handling of dropped partitioned indexes for REINDEX INDE 4+ messages / 1 participants [nested] [flat]
* pgsql: Improve handling of dropped partitioned indexes for REINDEX INDE @ 2024-01-18 07:32 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2024-01-18 07:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve handling of dropped partitioned indexes for REINDEX INDEX A REINDEX INDEX done on a partitioned index builds a list of the indexes to work on before processing its partitions in individual transactions. When combined with a DROP of the partitioned index, there was a window where it was possible to see some unexpected "could not open relation with OID", synonym of relation lookup error. The code was robust enough to handle the case where the parent relation is missing, but not the case where an index would be gone missing. This is similar to 1d65416661bb. Support for REINDEX on partitioned relations has been introduced in a6642b3ae060, so backpatch down to 14. Author: Fei Changhong Discussion: https://postgr.es/m/tencent_6A52106095ACDE55333E3AD33F304C0C3909@qq.com Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0ae3b466210316ebedbe123b64b46ac2dc1fc04f Modified Files -------------- src/backend/catalog/index.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Improve handling of dropped partitioned indexes for REINDEX INDE @ 2024-01-18 07:32 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2024-01-18 07:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve handling of dropped partitioned indexes for REINDEX INDEX A REINDEX INDEX done on a partitioned index builds a list of the indexes to work on before processing its partitions in individual transactions. When combined with a DROP of the partitioned index, there was a window where it was possible to see some unexpected "could not open relation with OID", synonym of relation lookup error. The code was robust enough to handle the case where the parent relation is missing, but not the case where an index would be gone missing. This is similar to 1d65416661bb. Support for REINDEX on partitioned relations has been introduced in a6642b3ae060, so backpatch down to 14. Author: Fei Changhong Discussion: https://postgr.es/m/tencent_6A52106095ACDE55333E3AD33F304C0C3909@qq.com Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c030e263e7fed65d5f936e8b3bb13da22bb09fdb Modified Files -------------- src/backend/catalog/index.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Improve handling of dropped partitioned indexes for REINDEX INDE @ 2024-01-18 07:32 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2024-01-18 07:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve handling of dropped partitioned indexes for REINDEX INDEX A REINDEX INDEX done on a partitioned index builds a list of the indexes to work on before processing its partitions in individual transactions. When combined with a DROP of the partitioned index, there was a window where it was possible to see some unexpected "could not open relation with OID", synonym of relation lookup error. The code was robust enough to handle the case where the parent relation is missing, but not the case where an index would be gone missing. This is similar to 1d65416661bb. Support for REINDEX on partitioned relations has been introduced in a6642b3ae060, so backpatch down to 14. Author: Fei Changhong Discussion: https://postgr.es/m/tencent_6A52106095ACDE55333E3AD33F304C0C3909@qq.com Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a0c19de115661a9c10553291bc5c384f326140af Modified Files -------------- src/backend/catalog/index.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Improve handling of dropped partitioned indexes for REINDEX INDE @ 2024-01-18 07:32 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2024-01-18 07:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve handling of dropped partitioned indexes for REINDEX INDEX A REINDEX INDEX done on a partitioned index builds a list of the indexes to work on before processing its partitions in individual transactions. When combined with a DROP of the partitioned index, there was a window where it was possible to see some unexpected "could not open relation with OID", synonym of relation lookup error. The code was robust enough to handle the case where the parent relation is missing, but not the case where an index would be gone missing. This is similar to 1d65416661bb. Support for REINDEX on partitioned relations has been introduced in a6642b3ae060, so backpatch down to 14. Author: Fei Changhong Discussion: https://postgr.es/m/tencent_6A52106095ACDE55333E3AD33F304C0C3909@qq.com Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b6f2e019d66ffaa3435d51a554ceacbee868a0e4 Modified Files -------------- src/backend/catalog/index.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-01-18 07:32 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-01-18 07:32 pgsql: Improve handling of dropped partitioned indexes for REINDEX INDE Michael Paquier <michael@paquier.xyz> 2024-01-18 07:32 pgsql: Improve handling of dropped partitioned indexes for REINDEX INDE Michael Paquier <michael@paquier.xyz> 2024-01-18 07:32 pgsql: Improve handling of dropped partitioned indexes for REINDEX INDE Michael Paquier <michael@paquier.xyz> 2024-01-18 07:32 pgsql: Improve handling of dropped partitioned indexes for REINDEX INDE Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox