pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Abort pgbench if script end is reached with an open pipeline 4+ messages / 1 participants [nested] [flat]
* pgsql: Abort pgbench if script end is reached with an open pipeline @ 2024-01-22 16:50 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 4+ messages in thread From: Alvaro Herrera @ 2024-01-22 16:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Abort pgbench if script end is reached with an open pipeline When a pipeline is opened with \startpipeline and not closed, pgbench will either error on the next transaction with a "already in pipeline mode" error or successfully end if this was the last transaction -- despite not sending anything that was piped in the pipeline. Make it an error to reach end of script is reached while there's an open pipeline. Backpatch to 14, where pgbench got support for pipelines. Author: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> Reported-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/Za4IObZkDjrO4TcS@paquier.xyz Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/49f7c6c44a5f6a7f7b39d140e490c9c627511893 Modified Files -------------- src/bin/pgbench/pgbench.c | 15 +++++++++++++-- src/bin/pgbench/t/001_pgbench_with_server.pl | 28 ++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Abort pgbench if script end is reached with an open pipeline @ 2024-01-22 16:50 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 4+ messages in thread From: Alvaro Herrera @ 2024-01-22 16:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Abort pgbench if script end is reached with an open pipeline When a pipeline is opened with \startpipeline and not closed, pgbench will either error on the next transaction with a "already in pipeline mode" error or successfully end if this was the last transaction -- despite not sending anything that was piped in the pipeline. Make it an error to reach end of script is reached while there's an open pipeline. Backpatch to 14, where pgbench got support for pipelines. Author: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> Reported-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/Za4IObZkDjrO4TcS@paquier.xyz Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/07b53de700390c8bdee99ce373d84f0cdcad74d6 Modified Files -------------- src/bin/pgbench/pgbench.c | 15 +++++++++++++-- src/bin/pgbench/t/001_pgbench_with_server.pl | 28 ++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Abort pgbench if script end is reached with an open pipeline @ 2024-01-22 16:50 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 4+ messages in thread From: Alvaro Herrera @ 2024-01-22 16:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Abort pgbench if script end is reached with an open pipeline When a pipeline is opened with \startpipeline and not closed, pgbench will either error on the next transaction with a "already in pipeline mode" error or successfully end if this was the last transaction -- despite not sending anything that was piped in the pipeline. Make it an error to reach end of script is reached while there's an open pipeline. Backpatch to 14, where pgbench got support for pipelines. Author: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> Reported-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/Za4IObZkDjrO4TcS@paquier.xyz Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3fd36be52b70b95eea6fe7d296ce871f49eedb50 Modified Files -------------- src/bin/pgbench/pgbench.c | 15 +++++++++++++-- src/bin/pgbench/t/001_pgbench_with_server.pl | 28 ++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Abort pgbench if script end is reached with an open pipeline @ 2024-01-22 16:50 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 4+ messages in thread From: Alvaro Herrera @ 2024-01-22 16:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Abort pgbench if script end is reached with an open pipeline When a pipeline is opened with \startpipeline and not closed, pgbench will either error on the next transaction with a "already in pipeline mode" error or successfully end if this was the last transaction -- despite not sending anything that was piped in the pipeline. Make it an error to reach end of script is reached while there's an open pipeline. Backpatch to 14, where pgbench got support for pipelines. Author: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> Reported-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/Za4IObZkDjrO4TcS@paquier.xyz Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/85ecff891525d61bc975584e2dc2d3c01e5a48ee Modified Files -------------- src/bin/pgbench/pgbench.c | 15 +++++++++++++-- src/bin/pgbench/t/001_pgbench_with_server.pl | 28 ++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-01-22 16:50 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-01-22 16:50 pgsql: Abort pgbench if script end is reached with an open pipeline Alvaro Herrera <alvherre@alvh.no-ip.org> 2024-01-22 16:50 pgsql: Abort pgbench if script end is reached with an open pipeline Alvaro Herrera <alvherre@alvh.no-ip.org> 2024-01-22 16:50 pgsql: Abort pgbench if script end is reached with an open pipeline Alvaro Herrera <alvherre@alvh.no-ip.org> 2024-01-22 16:50 pgsql: Abort pgbench if script end is reached with an open pipeline Alvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox