pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h" 2+ messages / 1 participants [nested] [flat]
* pgsql: Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h" @ 2024-01-23 08:56 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 2+ messages in thread From: Heikki Linnakangas @ 2024-01-23 08:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h" This reverts commit 728f86fec65537eade8d9e751961782ddb527934. The signal handling was a few bricks shy of a load in that commit, which made the walreceiver non-responsive to SIGTERM while it was waiting for the connection to be established. That prevented a standby from being promoted. Since it was non-essential refactoring, let's revert it to make v16 work the same as earlier releases. I reverted it in 'master' too, to keep the branches in sync. The refactoring was a good idea as such, but it needs a bit more work. Once we have developed a complete patch with this issue fixed, let's re-apply that to 'master'. Reported-by: Kyotaro Horiguchi Backpatch-through: 16 Discussion: https://www.postgresql.org/message-id/20231231.200741.1078989336605759878.horikyota.ntt@gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/21ef4d4d897563adb2f7920ad53b734950f1e0a4 Modified Files -------------- .../libpqwalreceiver/libpqwalreceiver.c | 55 ++++++++++++++++++---- 1 file changed, 47 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h" @ 2024-01-23 08:56 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 2+ messages in thread From: Heikki Linnakangas @ 2024-01-23 08:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h" This reverts commit 728f86fec65537eade8d9e751961782ddb527934. The signal handling was a few bricks shy of a load in that commit, which made the walreceiver non-responsive to SIGTERM while it was waiting for the connection to be established. That prevented a standby from being promoted. Since it was non-essential refactoring, let's revert it to make v16 work the same as earlier releases. I reverted it in 'master' too, to keep the branches in sync. The refactoring was a good idea as such, but it needs a bit more work. Once we have developed a complete patch with this issue fixed, let's re-apply that to 'master'. Reported-by: Kyotaro Horiguchi Backpatch-through: 16 Discussion: https://www.postgresql.org/message-id/20231231.200741.1078989336605759878.horikyota.ntt@gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c5a6d5337170a133490c91d7f6d27ac25c47480b Modified Files -------------- .../libpqwalreceiver/libpqwalreceiver.c | 55 ++++++++++++++++++---- 1 file changed, 47 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-01-23 08:56 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-01-23 08:56 pgsql: Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h" Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-01-23 08:56 pgsql: Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h" Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox