pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: meson: portname was set too early 2+ messages / 1 participants [nested] [flat]
* pgsql: meson: portname was set too early @ 2024-01-23 11:20 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2024-01-23 11:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org meson: portname was set too early portname is set to host_system, but host_system might still be changed later in the file. As a consequence, platforms where host_system is changed later wouldn't find some of their platform-specific files (driven by portname), and the build would fail. Move the assignment of portname further down after the last change of host_system (but before further overriding assignments to portname). Discussion: https://www.postgresql.org/message-id/flat/CAC7zN94TdsHhY88XkroJzSMx7E%3DBQpV9LKKjNSEnTM04ihoWCA%40m... Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4b4b3467ee36d11b6bf791731532ab962b0379be Modified Files -------------- meson.build | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: meson: portname was set too early @ 2024-01-23 11:20 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2024-01-23 11:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org meson: portname was set too early portname is set to host_system, but host_system might still be changed later in the file. As a consequence, platforms where host_system is changed later wouldn't find some of their platform-specific files (driven by portname), and the build would fail. Move the assignment of portname further down after the last change of host_system (but before further overriding assignments to portname). Discussion: https://www.postgresql.org/message-id/flat/CAC7zN94TdsHhY88XkroJzSMx7E%3DBQpV9LKKjNSEnTM04ihoWCA%40m... Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8b31b689f4db9fca726a8d1bab20b89ebb3fa0b1 Modified Files -------------- meson.build | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-01-23 11:20 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-01-23 11:20 pgsql: meson: portname was set too early Peter Eisentraut <peter@eisentraut.org> 2024-01-23 11:20 pgsql: meson: portname was set too early Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox