public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: [email protected]
Subject: pgsql: Revert "Refactor CopyReadAttributes{CSV,Text}() to use a callbac
Date: Wed, 14 Feb 2024 01:07:51 +0000
Message-ID: <[email protected]> (raw)

Revert "Refactor CopyReadAttributes{CSV,Text}() to use a callback in COPY FROM"

This reverts commit 95fb5b49024, for reasons similar to what led to
1aa8324b81fa.  In this case, the callback was called once per row, which
is less worse than the previous callback introduced for COPY TO called
once per argument for each row, still the patch set discussed to plug in
custom routines to the COPY paths would be able to know which subroutine
to use depending on its CopyFromState, so this led to a suboptimal
approach at the end.

For now, this part is reverted to consider better which approach to use.

Discussion: https://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/06bd311bce24083c76d9741ae89c98750aaf4b41

Modified Files
--------------
src/backend/commands/copyfrom.c          |  5 -----
src/backend/commands/copyfromparse.c     | 24 ++++++++++++++++--------
src/include/commands/copyfrom_internal.h | 17 -----------------
3 files changed, 16 insertions(+), 30 deletions(-)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Revert "Refactor CopyReadAttributes{CSV,Text}() to use a callbac
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox