public inbox for [email protected]
help / color / mirror / Atom feedpgsql: Fix test race between primary XLOG_RUNNING_XACTS and standby log
2+ messages / 1 participants
[nested] [flat]
* pgsql: Fix test race between primary XLOG_RUNNING_XACTS and standby log
@ 2024-02-19 20:57 Noah Misch <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Noah Misch @ 2024-02-19 20:57 UTC (permalink / raw)
To: [email protected]
Fix test race between primary XLOG_RUNNING_XACTS and standby logical slot.
Before the previous commit, the test could hang until
LOG_SNAPSHOT_INTERVAL_MS (15s), until checkpoint_timeout (300s), or
indefinitely. An indefinite hang was awfully improbable. It entailed
the test reaching checkpoint_timeout before the
DecodingContextFindStartpoint() of a CREATE SUBSCRIPTION, yet after the
preceding WAL record. Back-patch to v16, which introduced the test.
Bertrand Drouvot, reported by Noah Misch.
Discussion: https://postgr.es/m/[email protected]
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0e162810df7657bac24ba4657460a87104523fc6
Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 46 +++++++++++++++-------
.../recovery/t/035_standby_logical_decoding.pl | 4 +-
2 files changed, 34 insertions(+), 16 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix test race between primary XLOG_RUNNING_XACTS and standby log
@ 2024-02-19 20:57 Noah Misch <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Noah Misch @ 2024-02-19 20:57 UTC (permalink / raw)
To: [email protected]
Fix test race between primary XLOG_RUNNING_XACTS and standby logical slot.
Before the previous commit, the test could hang until
LOG_SNAPSHOT_INTERVAL_MS (15s), until checkpoint_timeout (300s), or
indefinitely. An indefinite hang was awfully improbable. It entailed
the test reaching checkpoint_timeout before the
DecodingContextFindStartpoint() of a CREATE SUBSCRIPTION, yet after the
preceding WAL record. Back-patch to v16, which introduced the test.
Bertrand Drouvot, reported by Noah Misch.
Discussion: https://postgr.es/m/[email protected]
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c59a97313ba34aeb4b1670307c0228fb94694adb
Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 46 +++++++++++++++-------
.../recovery/t/035_standby_logical_decoding.pl | 4 +-
2 files changed, 34 insertions(+), 16 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-02-19 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-02-19 20:57 pgsql: Fix test race between primary XLOG_RUNNING_XACTS and standby log Noah Misch <[email protected]>
2024-02-19 20:57 pgsql: Fix test race between primary XLOG_RUNNING_XACTS and standby log Noah Misch <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox