pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedlibpqtypes - libpqtypes: Added support for PQspecPrepare.
9+ messages / 2 participants
[nested] [flat]
* libpqtypes - libpqtypes: Added support for PQspecPrepare.
@ 2009-06-25 20:51 User Achernow <achernow@pgfoundry.org>
0 siblings, 0 replies; 9+ messages in thread
From: achernow@pgfoundry.org @ 2009-06-25 20:51 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Added support for PQspecPrepare. This required centralizing spec format parsing code into spec.c, so several functions like putf and getf can make use of it. Added a man page for the new function, a regression test and updated the change log.
Modified Files:
--------------
libpqtypes:
ChangeLog (r1.32 -> r1.33)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/ChangeLog?r1=1.32&r2=1.33)
Makefile.am (r1.13 -> r1.14)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/Makefile.am?r1=1.13&r2=1.14)
Makefile.win32 (r1.6 -> r1.7)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/Makefile.win32?r1=1.6&r2=1.7)
win32.mak (r1.4 -> r1.5)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/win32.mak?r1=1.4&r2=1.5)
libpqtypes/docs/man3:
PQgetf.3 (r1.5 -> r1.6)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/docs/man3/PQgetf.3?r1=1.5&r2=1...)
PQputf.3 (r1.7 -> r1.8)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/docs/man3/PQputf.3?r1=1.7&r2=1...)
libpqtypes/src:
events.c (r1.7 -> r1.8)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/events.c?r1=1.7&r2=1.8)
exec.c (r1.14 -> r1.15)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/exec.c?r1=1.14&r2=1.15)
handler.c (r1.12 -> r1.13)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/handler.c?r1=1.12&r2=1.13)
libpqtypes-int.h (r1.13 -> r1.14)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/libpqtypes-int.h?r1=1.13&r...)
libpqtypes.h (r1.19 -> r1.20)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/libpqtypes.h?r1=1.19&r2=1....)
param.c (r1.16 -> r1.17)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/param.c?r1=1.16&r2=1.17)
regression-test.c (r1.16 -> r1.17)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/regression-test.c?r1=1.16&...)
^ permalink raw reply [nested|flat] 9+ messages in thread
* libpqtypes - libpqtypes: Added support for PQspecPrepare.
@ 2009-06-25 20:52 User Achernow <achernow@pgfoundry.org>
0 siblings, 0 replies; 9+ messages in thread
From: achernow@pgfoundry.org @ 2009-06-25 20:52 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Added support for PQspecPrepare. This required centralizing spec format parsing code into spec.c, so several functions like putf and getf can make use of it. Added a man page for the new function, a regression test and updated the change log.
Added Files:
-----------
libpqtypes/src:
spec.c (r1.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/spec.c?rev=1.1&content-typ...)
^ permalink raw reply [nested|flat] 9+ messages in thread
* libpqtypes - libpqtypes: Added support for PQspecPrepare.
@ 2009-06-25 20:53 User Achernow <achernow@pgfoundry.org>
0 siblings, 0 replies; 9+ messages in thread
From: achernow@pgfoundry.org @ 2009-06-25 20:53 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Added support for PQspecPrepare. This required centralizing spec format parsing code into spec.c, so several functions like putf and getf can make use of it. Added a man page for the new function, a regression test and updated the change log.
Added Files:
-----------
libpqtypes/docs/man3:
PQspecPrepare.3 (r1.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/docs/man3/PQspecPrepare.3?rev=1.1&...)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Fix parallel-safety check of expressions and predicate for index
@ 2024-03-06 08:24 Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 9+ messages in thread
From: Michael Paquier @ 2024-03-06 08:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix parallel-safety check of expressions and predicate for index builds
As coded, the planner logic that calculates the number of parallel
workers to use for a parallel index build uses expressions and
predicates from the relcache, which are flattened for the planner by
eval_const_expressions().
As reported in the bug, an immutable parallel-unsafe function flattened
in the relcache would become a Const, which would be considered as
parallel-safe, even if the predicate or the expressions including the
function are not safe in parallel workers. Depending on the expressions
or predicate used, this could cause the parallel build to fail.
Tests are included that check parallel index builds with parallel-unsafe
predicate and expressions. Two routines are added to lsyscache.h to be
able to retrieve expressions and predicate of an index from its pg_index
data.
Reported-by: Alexander Lakhin
Author: Tender Wang
Reviewed-by: Jian He, Michael Paquier
Discussion: https://postgr.es/m/CAHewXN=UaAaNn9ruHDH3Os8kxLVmtWqbssnf=dZN_s9=evHUFA@mail.gmail.com
Backpatch-through: 12
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/eae7be600be715b2f393b018fc4b98c5b89296da
Modified Files
--------------
src/backend/optimizer/plan/planner.c | 12 +++++-
src/backend/utils/cache/lsyscache.c | 68 +++++++++++++++++++++++++++++++
src/include/utils/lsyscache.h | 2 +
src/test/regress/expected/btree_index.out | 19 +++++++++
src/test/regress/sql/btree_index.sql | 22 ++++++++++
5 files changed, 121 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Fix parallel-safety check of expressions and predicate for index
@ 2024-03-06 08:24 Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 9+ messages in thread
From: Michael Paquier @ 2024-03-06 08:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix parallel-safety check of expressions and predicate for index builds
As coded, the planner logic that calculates the number of parallel
workers to use for a parallel index build uses expressions and
predicates from the relcache, which are flattened for the planner by
eval_const_expressions().
As reported in the bug, an immutable parallel-unsafe function flattened
in the relcache would become a Const, which would be considered as
parallel-safe, even if the predicate or the expressions including the
function are not safe in parallel workers. Depending on the expressions
or predicate used, this could cause the parallel build to fail.
Tests are included that check parallel index builds with parallel-unsafe
predicate and expressions. Two routines are added to lsyscache.h to be
able to retrieve expressions and predicate of an index from its pg_index
data.
Reported-by: Alexander Lakhin
Author: Tender Wang
Reviewed-by: Jian He, Michael Paquier
Discussion: https://postgr.es/m/CAHewXN=UaAaNn9ruHDH3Os8kxLVmtWqbssnf=dZN_s9=evHUFA@mail.gmail.com
Backpatch-through: 12
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/4ec8f7708b6b4c494bd0ccd937fc28d34a872b49
Modified Files
--------------
src/backend/optimizer/plan/planner.c | 12 +++++-
src/backend/utils/cache/lsyscache.c | 68 +++++++++++++++++++++++++++++++
src/include/utils/lsyscache.h | 2 +
src/test/regress/expected/btree_index.out | 19 +++++++++
src/test/regress/sql/btree_index.sql | 22 ++++++++++
5 files changed, 121 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Fix parallel-safety check of expressions and predicate for index
@ 2024-03-06 08:24 Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 9+ messages in thread
From: Michael Paquier @ 2024-03-06 08:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix parallel-safety check of expressions and predicate for index builds
As coded, the planner logic that calculates the number of parallel
workers to use for a parallel index build uses expressions and
predicates from the relcache, which are flattened for the planner by
eval_const_expressions().
As reported in the bug, an immutable parallel-unsafe function flattened
in the relcache would become a Const, which would be considered as
parallel-safe, even if the predicate or the expressions including the
function are not safe in parallel workers. Depending on the expressions
or predicate used, this could cause the parallel build to fail.
Tests are included that check parallel index builds with parallel-unsafe
predicate and expressions. Two routines are added to lsyscache.h to be
able to retrieve expressions and predicate of an index from its pg_index
data.
Reported-by: Alexander Lakhin
Author: Tender Wang
Reviewed-by: Jian He, Michael Paquier
Discussion: https://postgr.es/m/CAHewXN=UaAaNn9ruHDH3Os8kxLVmtWqbssnf=dZN_s9=evHUFA@mail.gmail.com
Backpatch-through: 12
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/50b5913a87c9c2d67330d82429f6dda61441d40c
Modified Files
--------------
src/backend/optimizer/plan/planner.c | 12 +++++-
src/backend/utils/cache/lsyscache.c | 68 +++++++++++++++++++++++++++++++
src/include/utils/lsyscache.h | 2 +
src/test/regress/expected/btree_index.out | 19 +++++++++
src/test/regress/sql/btree_index.sql | 22 ++++++++++
5 files changed, 121 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Fix parallel-safety check of expressions and predicate for index
@ 2024-03-06 08:24 Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 9+ messages in thread
From: Michael Paquier @ 2024-03-06 08:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix parallel-safety check of expressions and predicate for index builds
As coded, the planner logic that calculates the number of parallel
workers to use for a parallel index build uses expressions and
predicates from the relcache, which are flattened for the planner by
eval_const_expressions().
As reported in the bug, an immutable parallel-unsafe function flattened
in the relcache would become a Const, which would be considered as
parallel-safe, even if the predicate or the expressions including the
function are not safe in parallel workers. Depending on the expressions
or predicate used, this could cause the parallel build to fail.
Tests are included that check parallel index builds with parallel-unsafe
predicate and expressions. Two routines are added to lsyscache.h to be
able to retrieve expressions and predicate of an index from its pg_index
data.
Reported-by: Alexander Lakhin
Author: Tender Wang
Reviewed-by: Jian He, Michael Paquier
Discussion: https://postgr.es/m/CAHewXN=UaAaNn9ruHDH3Os8kxLVmtWqbssnf=dZN_s9=evHUFA@mail.gmail.com
Backpatch-through: 12
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/56a8ab2fc6f76ec2ca7a257f36ef8138a3fd473a
Modified Files
--------------
src/backend/optimizer/plan/planner.c | 12 +++++-
src/backend/utils/cache/lsyscache.c | 68 +++++++++++++++++++++++++++++++
src/include/utils/lsyscache.h | 2 +
src/test/regress/expected/btree_index.out | 19 +++++++++
src/test/regress/sql/btree_index.sql | 22 ++++++++++
5 files changed, 121 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Fix parallel-safety check of expressions and predicate for index
@ 2024-03-06 08:24 Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 9+ messages in thread
From: Michael Paquier @ 2024-03-06 08:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix parallel-safety check of expressions and predicate for index builds
As coded, the planner logic that calculates the number of parallel
workers to use for a parallel index build uses expressions and
predicates from the relcache, which are flattened for the planner by
eval_const_expressions().
As reported in the bug, an immutable parallel-unsafe function flattened
in the relcache would become a Const, which would be considered as
parallel-safe, even if the predicate or the expressions including the
function are not safe in parallel workers. Depending on the expressions
or predicate used, this could cause the parallel build to fail.
Tests are included that check parallel index builds with parallel-unsafe
predicate and expressions. Two routines are added to lsyscache.h to be
able to retrieve expressions and predicate of an index from its pg_index
data.
Reported-by: Alexander Lakhin
Author: Tender Wang
Reviewed-by: Jian He, Michael Paquier
Discussion: https://postgr.es/m/CAHewXN=UaAaNn9ruHDH3Os8kxLVmtWqbssnf=dZN_s9=evHUFA@mail.gmail.com
Backpatch-through: 12
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b60d71c202cde344e0b447c2bb301addf95fa3b5
Modified Files
--------------
src/backend/optimizer/plan/planner.c | 12 +++++-
src/backend/utils/cache/lsyscache.c | 68 +++++++++++++++++++++++++++++++
src/include/utils/lsyscache.h | 2 +
src/test/regress/expected/btree_index.out | 19 +++++++++
src/test/regress/sql/btree_index.sql | 22 ++++++++++
5 files changed, 121 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Fix parallel-safety check of expressions and predicate for index
@ 2024-03-06 08:24 Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 9+ messages in thread
From: Michael Paquier @ 2024-03-06 08:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix parallel-safety check of expressions and predicate for index builds
As coded, the planner logic that calculates the number of parallel
workers to use for a parallel index build uses expressions and
predicates from the relcache, which are flattened for the planner by
eval_const_expressions().
As reported in the bug, an immutable parallel-unsafe function flattened
in the relcache would become a Const, which would be considered as
parallel-safe, even if the predicate or the expressions including the
function are not safe in parallel workers. Depending on the expressions
or predicate used, this could cause the parallel build to fail.
Tests are included that check parallel index builds with parallel-unsafe
predicate and expressions. Two routines are added to lsyscache.h to be
able to retrieve expressions and predicate of an index from its pg_index
data.
Reported-by: Alexander Lakhin
Author: Tender Wang
Reviewed-by: Jian He, Michael Paquier
Discussion: https://postgr.es/m/CAHewXN=UaAaNn9ruHDH3Os8kxLVmtWqbssnf=dZN_s9=evHUFA@mail.gmail.com
Backpatch-through: 12
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c0e0174c216bedcd3cfeb6b0bb5eead50713c772
Modified Files
--------------
src/backend/optimizer/plan/planner.c | 12 +++++-
src/backend/utils/cache/lsyscache.c | 68 +++++++++++++++++++++++++++++++
src/include/utils/lsyscache.h | 2 +
src/test/regress/expected/btree_index.out | 19 +++++++++
src/test/regress/sql/btree_index.sql | 22 ++++++++++
5 files changed, 121 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2024-03-06 08:24 UTC | newest]
Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-25 20:51 libpqtypes - libpqtypes: Added support for PQspecPrepare. User Achernow <achernow@pgfoundry.org>
2009-06-25 20:52 libpqtypes - libpqtypes: Added support for PQspecPrepare. User Achernow <achernow@pgfoundry.org>
2009-06-25 20:53 libpqtypes - libpqtypes: Added support for PQspecPrepare. User Achernow <achernow@pgfoundry.org>
2024-03-06 08:24 pgsql: Fix parallel-safety check of expressions and predicate for index Michael Paquier <michael@paquier.xyz>
2024-03-06 08:24 pgsql: Fix parallel-safety check of expressions and predicate for index Michael Paquier <michael@paquier.xyz>
2024-03-06 08:24 pgsql: Fix parallel-safety check of expressions and predicate for index Michael Paquier <michael@paquier.xyz>
2024-03-06 08:24 pgsql: Fix parallel-safety check of expressions and predicate for index Michael Paquier <michael@paquier.xyz>
2024-03-06 08:24 pgsql: Fix parallel-safety check of expressions and predicate for index Michael Paquier <michael@paquier.xyz>
2024-03-06 08:24 pgsql: Fix parallel-safety check of expressions and predicate for index Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox