pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpg-migrator - pg_migrator: Make PGXS invocations conform to currently
3+ messages / 2 participants
[nested] [flat]
* pg-migrator - pg_migrator: Make PGXS invocations conform to currently
@ 2009-07-03 16:57 User Tgl <tgl@pgfoundry.org>
0 siblings, 0 replies; 3+ messages in thread
From: tgl@pgfoundry.org @ 2009-07-03 16:57 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Make PGXS invocations conform to currently accepted style.
Modified Files:
--------------
pg_migrator/func:
Makefile (r1.2 -> r1.3)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/func/Makefile?r1=1.2&r2=1.3)
pg_migrator/src:
Makefile (r1.4 -> r1.5)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/src/Makefile?r1=1.4&r2=1.5)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Set all_visible_according_to_vm correctly with DISABLE_PAGE_SKIP
@ 2024-03-11 09:20 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 3+ messages in thread
From: Heikki Linnakangas @ 2024-03-11 09:20 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Set all_visible_according_to_vm correctly with DISABLE_PAGE_SKIPPING
It's important for 'all_visible_according_to_vm' to correctly reflect
whether the VM bit is set or not, even when we are not trusting the VM
to skip pages, because contrary to what the comment said,
lazy_scan_prune() relies on it.
If it's incorrectly set to 'false', when the VM bit is in fact set,
lazy_scan_prune() will try to set the VM bit again and dirty the page
unnecessarily. As a result, if you used DISABLE_PAGE_SKIPPING, all
heap pages were dirtied, even if there were no changes. We would also
fail to clear any VM bits that were set incorrectly.
This was broken in commit 980ae17310, so backpatch to v16.
Backpatch-through: 16
Reviewed-by: Melanie Plageman, Peter Geoghegan
Discussion: https://www.postgresql.org/message-id/3df2b582-dc1c-46b6-99b6-38eddd1b2784@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/674e49c73c1c442d05a46388fcc1431fbd59ca44
Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 4 ----
1 file changed, 4 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Set all_visible_according_to_vm correctly with DISABLE_PAGE_SKIP
@ 2024-03-11 09:20 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 3+ messages in thread
From: Heikki Linnakangas @ 2024-03-11 09:20 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Set all_visible_according_to_vm correctly with DISABLE_PAGE_SKIPPING
It's important for 'all_visible_according_to_vm' to correctly reflect
whether the VM bit is set or not, even when we are not trusting the VM
to skip pages, because contrary to what the comment said,
lazy_scan_prune() relies on it.
If it's incorrectly set to 'false', when the VM bit is in fact set,
lazy_scan_prune() will try to set the VM bit again and dirty the page
unnecessarily. As a result, if you used DISABLE_PAGE_SKIPPING, all
heap pages were dirtied, even if there were no changes. We would also
fail to clear any VM bits that were set incorrectly.
This was broken in commit 980ae17310, so backpatch to v16.
Backpatch-through: 16
Reviewed-by: Melanie Plageman, Peter Geoghegan
Discussion: https://www.postgresql.org/message-id/3df2b582-dc1c-46b6-99b6-38eddd1b2784@iki.fi
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/407cb6c6589fa2b757c9f2724278ae101749d9f7
Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 4 ----
1 file changed, 4 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-03-11 09:20 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-03 16:57 pg-migrator - pg_migrator: Make PGXS invocations conform to currently User Tgl <tgl@pgfoundry.org>
2024-03-11 09:20 pgsql: Set all_visible_according_to_vm correctly with DISABLE_PAGE_SKIP Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-03-11 09:20 pgsql: Set all_visible_according_to_vm correctly with DISABLE_PAGE_SKIP Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox