pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgtcl - libpgtcl: * pg_select was not checking returns from
2+ messages / 2 participants
[nested] [flat]
* pgtcl - libpgtcl: * pg_select was not checking returns from
@ 2009-07-08 03:45 User Karl <karl@pgfoundry.org>
0 siblings, 0 replies; 2+ messages in thread
From: karl@pgfoundry.org @ 2009-07-08 03:45 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
* pg_select was not checking returns from Tcl_ObjSetVar2 and friends.
The problem was that if the pg_select array already existed as a
scalar variable, no error was returned to denote this, and it caused
a coredump in Tcl 8.5. This has now been fixed.
Modified Files:
--------------
libpgtcl:
ChangeLog (r1.58 -> r1.59)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgtcl/libpgtcl/ChangeLog?r1=1.58&r2=1.59)
configure (r1.17 -> r1.18)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgtcl/libpgtcl/configure?r1=1.17&r2=1.18)
libpgtcl/generic:
pgtclCmds.c (r1.74 -> r1.75)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgtcl/libpgtcl/generic/pgtclCmds.c?r1=1.74&r2=1.75)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Hopefully make libpq_pipeline's new cancel test more reliable
@ 2024-03-13 18:56 Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 0 replies; 2+ messages in thread
From: Alvaro Herrera @ 2024-03-13 18:56 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Hopefully make libpq_pipeline's new cancel test more reliable
The newly introduced cancel test in libpq_pipeline was flaky. It's not
completely clear why, but one option is that the check for "active" was
actually seeing the active state for the previous query. This change
should address any such race condition by first waiting until the
connection is reported as idle.
Author: Jelte Fennema-Nio <me@jeltef.nl>
Discussion: https://postgr.es/m/CAGECzQRvmUK5-d68A+cm+fgmfht9Dv2uZ28-qq3QiaF6EAZqPQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1ee910ce437188eab40eddf32dc7d81952e99f82
Modified Files
--------------
src/test/modules/libpq_pipeline/libpq_pipeline.c | 78 +++++++++++++++---------
1 file changed, 49 insertions(+), 29 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-03-13 18:56 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-08 03:45 pgtcl - libpgtcl: * pg_select was not checking returns from User Karl <karl@pgfoundry.org>
2024-03-13 18:56 pgsql: Hopefully make libpq_pipeline's new cancel test more reliable Alvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox