pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix dumping role comments when using --no-role-passwords 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix dumping role comments when using --no-role-passwords @ 2024-03-21 22:33 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2024-03-21 22:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix dumping role comments when using --no-role-passwords Commit 9a83d56b38c added support for allowing pg_dumpall to dump roles without including passwords, which accidentally made dumps omit COMMENTs on roles. This fixes it by using pg_authid to get the comment. Backpatch to all supported versions. Patch simultaneously written independently by Álvaro and myself. Author: Álvaro Herrera <alvherre@alvh.no-ip.org> Author: Daniel Gustafsson <daniel@yesql.se> Reported-by: Bartosz Chroł <bartosz.chrol@handen.pl> Discussion: https://postgr.es/m/AS8P194MB1271CDA0ADCA7B75FCD8E767F7332@AS8P194MB1271.EURP194.PROD.OUTLOOK.COM Discussion: https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com Backpatch-through: v12 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7e65ad197f9dff7466cea7986450f9573adb4448 Modified Files -------------- src/bin/pg_dump/pg_dumpall.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix dumping role comments when using --no-role-passwords @ 2024-03-21 22:34 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2024-03-21 22:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix dumping role comments when using --no-role-passwords Commit 9a83d56b38c added support for allowing pg_dumpall to dump roles without including passwords, which accidentally made dumps omit COMMENTs on roles. This fixes it by using pg_authid to get the comment. Backpatch to all supported versions. Patch simultaneously written independently by Álvaro and myself. Author: Álvaro Herrera <alvherre@alvh.no-ip.org> Author: Daniel Gustafsson <daniel@yesql.se> Reported-by: Bartosz Chroł <bartosz.chrol@handen.pl> Discussion: https://postgr.es/m/AS8P194MB1271CDA0ADCA7B75FCD8E767F7332@AS8P194MB1271.EURP194.PROD.OUTLOOK.COM Discussion: https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com Backpatch-through: v12 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5863bacb87c1e6cd1a322c9c4a5a861b27768379 Modified Files -------------- src/bin/pg_dump/pg_dumpall.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix dumping role comments when using --no-role-passwords @ 2024-03-21 22:34 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2024-03-21 22:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix dumping role comments when using --no-role-passwords Commit 9a83d56b38c added support for allowing pg_dumpall to dump roles without including passwords, which accidentally made dumps omit COMMENTs on roles. This fixes it by using pg_authid to get the comment. Backpatch to all supported versions. Patch simultaneously written independently by Álvaro and myself. Author: Álvaro Herrera <alvherre@alvh.no-ip.org> Author: Daniel Gustafsson <daniel@yesql.se> Reported-by: Bartosz Chroł <bartosz.chrol@handen.pl> Discussion: https://postgr.es/m/AS8P194MB1271CDA0ADCA7B75FCD8E767F7332@AS8P194MB1271.EURP194.PROD.OUTLOOK.COM Discussion: https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com Backpatch-through: v12 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/12128be623fdfd1f15167a477d7de46744fb9bca Modified Files -------------- src/bin/pg_dump/pg_dumpall.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix dumping role comments when using --no-role-passwords @ 2024-03-21 22:34 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2024-03-21 22:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix dumping role comments when using --no-role-passwords Commit 9a83d56b38c added support for allowing pg_dumpall to dump roles without including passwords, which accidentally made dumps omit COMMENTs on roles. This fixes it by using pg_authid to get the comment. Backpatch to all supported versions. Patch simultaneously written independently by Álvaro and myself. Author: Álvaro Herrera <alvherre@alvh.no-ip.org> Author: Daniel Gustafsson <daniel@yesql.se> Reported-by: Bartosz Chroł <bartosz.chrol@handen.pl> Discussion: https://postgr.es/m/AS8P194MB1271CDA0ADCA7B75FCD8E767F7332@AS8P194MB1271.EURP194.PROD.OUTLOOK.COM Discussion: https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com Backpatch-through: v12 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/be01c8c3450e48fbe8baa13625e1d36e0814c29b Modified Files -------------- src/bin/pg_dump/pg_dumpall.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix dumping role comments when using --no-role-passwords @ 2024-03-21 22:34 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2024-03-21 22:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix dumping role comments when using --no-role-passwords Commit 9a83d56b38c added support for allowing pg_dumpall to dump roles without including passwords, which accidentally made dumps omit COMMENTs on roles. This fixes it by using pg_authid to get the comment. Backpatch to all supported versions. Patch simultaneously written independently by Álvaro and myself. Author: Álvaro Herrera <alvherre@alvh.no-ip.org> Author: Daniel Gustafsson <daniel@yesql.se> Reported-by: Bartosz Chroł <bartosz.chrol@handen.pl> Discussion: https://postgr.es/m/AS8P194MB1271CDA0ADCA7B75FCD8E767F7332@AS8P194MB1271.EURP194.PROD.OUTLOOK.COM Discussion: https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com Backpatch-through: v12 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/affc46b76d50a42c44ae1322545769eceaa509c6 Modified Files -------------- src/bin/pg_dump/pg_dumpall.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix dumping role comments when using --no-role-passwords @ 2024-03-21 22:34 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2024-03-21 22:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix dumping role comments when using --no-role-passwords Commit 9a83d56b38c added support for allowing pg_dumpall to dump roles without including passwords, which accidentally made dumps omit COMMENTs on roles. This fixes it by using pg_authid to get the comment. Backpatch to all supported versions. Patch simultaneously written independently by Álvaro and myself. Author: Álvaro Herrera <alvherre@alvh.no-ip.org> Author: Daniel Gustafsson <daniel@yesql.se> Reported-by: Bartosz Chroł <bartosz.chrol@handen.pl> Discussion: https://postgr.es/m/AS8P194MB1271CDA0ADCA7B75FCD8E767F7332@AS8P194MB1271.EURP194.PROD.OUTLOOK.COM Discussion: https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com Backpatch-through: v12 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d82cb467bbc292375283b40f5cc65868024c82b4 Modified Files -------------- src/bin/pg_dump/pg_dumpall.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-03-21 22:34 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-03-21 22:33 pgsql: Fix dumping role comments when using --no-role-passwords Daniel Gustafsson <dgustafsson@postgresql.org> 2024-03-21 22:34 pgsql: Fix dumping role comments when using --no-role-passwords Daniel Gustafsson <dgustafsson@postgresql.org> 2024-03-21 22:34 pgsql: Fix dumping role comments when using --no-role-passwords Daniel Gustafsson <dgustafsson@postgresql.org> 2024-03-21 22:34 pgsql: Fix dumping role comments when using --no-role-passwords Daniel Gustafsson <dgustafsson@postgresql.org> 2024-03-21 22:34 pgsql: Fix dumping role comments when using --no-role-passwords Daniel Gustafsson <dgustafsson@postgresql.org> 2024-03-21 22:34 pgsql: Fix dumping role comments when using --no-role-passwords Daniel Gustafsson <dgustafsson@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox