pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Defend against possible crash if a plpython function does not
2+ messages / 2 participants
[nested] [flat]

* pgsql: Defend against possible crash if a plpython function does not
@ 2009-04-03 16:59 Tom Lane <tgl@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: tgl@postgresql.org @ 2009-04-03 16:59 UTC (permalink / raw)
  To: pgsql-committers

Log Message:
-----------
Defend against possible crash if a plpython function does not specify names
for its arguments.  Also add a regression test, since someone apparently
changed every single plpython test case to use only named parameters; else
we'd have noticed this sooner.

Euler Taveira de Oliveira, per a report from Alvaro

Modified Files:
--------------
    pgsql/src/pl/plpython/expected:
        plpython_function.out (r1.11 -> r1.12)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/expected/plpython_function.out?r1=1.1...)
        plpython_test.out (r1.7 -> r1.8)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/expected/plpython_test.out?r1=1.7&...)
    pgsql/src/pl/plpython:
        plpython.c (r1.119 -> r1.120)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c?r1=1.119&r2=1.120)
    pgsql/src/pl/plpython/sql:
        plpython_function.sql (r1.11 -> r1.12)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/sql/plpython_function.sql?r1=1.11&...)
        plpython_test.sql (r1.4 -> r1.5)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/sql/plpython_test.sql?r1=1.4&r2=1...)




^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Release temporary array in check_for_data_types_usage().
@ 2024-03-24 16:31 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2024-03-24 16:31 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Release temporary array in check_for_data_types_usage().

Coverity identified this as a resource leak.  It's surely of no
consequence given that the function is called only once per run, but
freeing the storage is no more work than dismissing the complaint.
Minor oversight in commit 347758b12.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/225e1dde463ae312714d71a929f45cfd153df2be

Modified Files
--------------
src/bin/pg_upgrade/check.c | 2 ++
1 file changed, 2 insertions(+)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2024-03-24 16:31 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-04-03 16:59 pgsql: Defend against possible crash if a plpython function does not Tom Lane <tgl@postgresql.org>
2024-03-24 16:31 pgsql: Release temporary array in check_for_data_types_usage(). Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox