pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Add allow_alter_system GUC.
6+ messages / 4 participants
[nested] [flat]
* pgsql: Add allow_alter_system GUC.
@ 2024-03-29 12:45 Robert Haas <rhaas@postgresql.org>
0 siblings, 1 reply; 6+ messages in thread
From: Robert Haas @ 2024-03-29 12:45 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Add allow_alter_system GUC.
This is marked PGC_SIGHUP, so it can only be set in a configuration
file, not anywhere else; and it is also marked GUC_DISALLOW_IN_AUTO_FILE,
so it can't be set using ALTER SYSTEM. When set to false, the
ALTER SYSTEM command is disallowed.
There was considerable concern that this would be misinterpreted as
a security feature, which it is not, because a determined superuser
has various ways of bypassing it. Hence, a lot of work has gone into
wordsmithing the documentation, in the hopes of avoiding any such
confusion.
Jelte Fennemia-Nio and Gabriele Bartolini, with wording suggestions
for the documentation from many others.
Discussion: http://postgr.es/m/CA%2BVUV5rEKt2%2BCdC_KUaPoihMu%2Bi5ChT4WVNTr4CD5-xXZUfuQw%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d3ae2a24f265a028f4b9e8df79ea7b075c6cf016
Modified Files
--------------
doc/src/sgml/config.sgml | 51 ++++++++++++++++++++++++++-
doc/src/sgml/ref/alter_system.sgml | 8 +++++
src/backend/utils/misc/guc.c | 5 +++
src/backend/utils/misc/guc_tables.c | 17 +++++++++
src/backend/utils/misc/postgresql.conf.sample | 1 +
src/include/utils/guc.h | 1 +
6 files changed, 82 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: Add allow_alter_system GUC.
@ 2024-03-29 12:47 Robert Haas <robertmhaas@gmail.com>
parent: Robert Haas <rhaas@postgresql.org>
0 siblings, 3 replies; 6+ messages in thread
From: Robert Haas @ 2024-03-29 12:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org, Jelte Fennema <postgres@jeltef.nl>
Oh no! Jelte, I'm so sorry ... I spelled your name wrong in this
commit message. :-(
Please accept my apologies.
...Robert
On Fri, Mar 29, 2024 at 8:45 AM Robert Haas <rhaas@postgresql.org> wrote:
>
> Add allow_alter_system GUC.
>
> This is marked PGC_SIGHUP, so it can only be set in a configuration
> file, not anywhere else; and it is also marked GUC_DISALLOW_IN_AUTO_FILE,
> so it can't be set using ALTER SYSTEM. When set to false, the
> ALTER SYSTEM command is disallowed.
>
> There was considerable concern that this would be misinterpreted as
> a security feature, which it is not, because a determined superuser
> has various ways of bypassing it. Hence, a lot of work has gone into
> wordsmithing the documentation, in the hopes of avoiding any such
> confusion.
>
> Jelte Fennemia-Nio and Gabriele Bartolini, with wording suggestions
> for the documentation from many others.
>
> Discussion: http://postgr.es/m/CA%2BVUV5rEKt2%2BCdC_KUaPoihMu%2Bi5ChT4WVNTr4CD5-xXZUfuQw%40mail.gmail.com
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/d3ae2a24f265a028f4b9e8df79ea7b075c6cf016
>
> Modified Files
> --------------
> doc/src/sgml/config.sgml | 51 ++++++++++++++++++++++++++-
> doc/src/sgml/ref/alter_system.sgml | 8 +++++
> src/backend/utils/misc/guc.c | 5 +++
> src/backend/utils/misc/guc_tables.c | 17 +++++++++
> src/backend/utils/misc/postgresql.conf.sample | 1 +
> src/include/utils/guc.h | 1 +
> 6 files changed, 82 insertions(+), 1 deletion(-)
>
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: Add allow_alter_system GUC.
@ 2024-03-29 13:03 Jelte Fennema-Nio <postgres@jeltef.nl>
parent: Robert Haas <robertmhaas@gmail.com>
2 siblings, 1 reply; 6+ messages in thread
From: Jelte Fennema-Nio @ 2024-03-29 13:03 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-committers@lists.postgresql.org
no worries, these things happen. I'm just glad it's committed and I
can now focus on different things than back and forth discussion over
documentation that all looks pretty much identical to me.
On Fri, 29 Mar 2024 at 13:47, Robert Haas <robertmhaas@gmail.com> wrote:
>
> Oh no! Jelte, I'm so sorry ... I spelled your name wrong in this
> commit message. :-(
>
> Please accept my apologies.
>
> ...Robert
>
> On Fri, Mar 29, 2024 at 8:45 AM Robert Haas <rhaas@postgresql.org> wrote:
> >
> > Add allow_alter_system GUC.
> >
> > This is marked PGC_SIGHUP, so it can only be set in a configuration
> > file, not anywhere else; and it is also marked GUC_DISALLOW_IN_AUTO_FILE,
> > so it can't be set using ALTER SYSTEM. When set to false, the
> > ALTER SYSTEM command is disallowed.
> >
> > There was considerable concern that this would be misinterpreted as
> > a security feature, which it is not, because a determined superuser
> > has various ways of bypassing it. Hence, a lot of work has gone into
> > wordsmithing the documentation, in the hopes of avoiding any such
> > confusion.
> >
> > Jelte Fennemia-Nio and Gabriele Bartolini, with wording suggestions
> > for the documentation from many others.
> >
> > Discussion: http://postgr.es/m/CA%2BVUV5rEKt2%2BCdC_KUaPoihMu%2Bi5ChT4WVNTr4CD5-xXZUfuQw%40mail.gmail.com
> >
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> > https://git.postgresql.org/pg/commitdiff/d3ae2a24f265a028f4b9e8df79ea7b075c6cf016
> >
> > Modified Files
> > --------------
> > doc/src/sgml/config.sgml | 51 ++++++++++++++++++++++++++-
> > doc/src/sgml/ref/alter_system.sgml | 8 +++++
> > src/backend/utils/misc/guc.c | 5 +++
> > src/backend/utils/misc/guc_tables.c | 17 +++++++++
> > src/backend/utils/misc/postgresql.conf.sample | 1 +
> > src/include/utils/guc.h | 1 +
> > 6 files changed, 82 insertions(+), 1 deletion(-)
> >
>
>
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: Add allow_alter_system GUC.
@ 2024-03-29 13:07 Robert Haas <robertmhaas@gmail.com>
parent: Jelte Fennema-Nio <postgres@jeltef.nl>
0 siblings, 0 replies; 6+ messages in thread
From: Robert Haas @ 2024-03-29 13:07 UTC (permalink / raw)
To: Jelte Fennema-Nio <postgres@jeltef.nl>; +Cc: pgsql-committers@lists.postgresql.org
On Fri, Mar 29, 2024 at 9:03 AM Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
> no worries, these things happen. I'm just glad it's committed and I
> can now focus on different things than back and forth discussion over
> documentation that all looks pretty much identical to me.
Yeah, imagine that!
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: Add allow_alter_system GUC.
@ 2024-03-29 16:27 Bruce Momjian <bruce@momjian.us>
parent: Robert Haas <robertmhaas@gmail.com>
2 siblings, 0 replies; 6+ messages in thread
From: Bruce Momjian @ 2024-03-29 16:27 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-committers@lists.postgresql.org, Jelte Fennema <postgres@jeltef.nl>
On Fri, Mar 29, 2024 at 08:47:18AM -0400, Robert Haas wrote:
> Oh no! Jelte, I'm so sorry ... I spelled your name wrong in this
> commit message. :-(
>
> Please accept my apologies.
I have made a record of this so I will make sure it is accurate in the
release notes.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: Add allow_alter_system GUC.
@ 2024-05-08 17:37 Bruce Momjian <bruce@momjian.us>
parent: Robert Haas <robertmhaas@gmail.com>
2 siblings, 0 replies; 6+ messages in thread
From: Bruce Momjian @ 2024-05-08 17:37 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-committers@lists.postgresql.org, Jelte Fennema <postgres@jeltef.nl>
On Fri, Mar 29, 2024 at 08:47:18AM -0400, Robert Haas wrote:
> Oh no! Jelte, I'm so sorry ... I spelled your name wrong in this
> commit message. :-(
>
> Please accept my apologies.
I have corrected his name in the release notes for this item.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-05-08 17:37 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-03-29 12:45 pgsql: Add allow_alter_system GUC. Robert Haas <rhaas@postgresql.org>
2024-03-29 12:47 ` Robert Haas <robertmhaas@gmail.com>
2024-03-29 13:03 ` Jelte Fennema-Nio <postgres@jeltef.nl>
2024-03-29 13:07 ` Robert Haas <robertmhaas@gmail.com>
2024-03-29 16:27 ` Bruce Momjian <bruce@momjian.us>
2024-05-08 17:37 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox