pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Revert "Custom reloptions for table AM" 2+ messages / 1 participants [nested] [flat]
* pgsql: Revert "Custom reloptions for table AM" @ 2024-04-02 08:44 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Alexander Korotkov @ 2024-04-02 08:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Custom reloptions for table AM" This reverts commit c95c25f9af4bc77f2f66a587735c50da08c12b37 due to multiple design issues spotted after commit. Reported-by: Jeff Davis Discussion: https://postgr.es/m/11550b536211d5748bb2865ed6cb3502ff073bf7.camel%40j-davis.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/867cc7b6ddb9d998103688a56048fe9a1ddd972a Modified Files -------------- src/backend/access/common/reloptions.c | 6 ++-- src/backend/access/heap/heapam_handler.c | 12 ------- src/backend/access/table/tableamapi.c | 25 --------------- src/backend/commands/tablecmds.c | 55 +++++++++++++------------------- src/backend/postmaster/autovacuum.c | 4 +-- src/backend/utils/cache/relcache.c | 6 +--- src/include/access/reloptions.h | 2 -- src/include/access/tableam.h | 43 ------------------------- 8 files changed, 27 insertions(+), 126 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Revert: Custom reloptions for table AM @ 2024-04-11 13:23 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Alexander Korotkov @ 2024-04-11 13:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert: Custom reloptions for table AM This commit reverts 9bd99f4c26 and 422041542f per review by Andres Freund. Discussion: https://postgr.es/m/20240410165236.rwyrny7ihi4ddxw4%40awork3.anarazel.de Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/bc1e2092ebb857802a9713d0d3588079e2f0216a Modified Files -------------- src/backend/access/common/reloptions.c | 149 +++++---------------- src/backend/access/heap/heapam.c | 4 +- src/backend/access/heap/heapam_handler.c | 13 -- src/backend/access/heap/heaptoast.c | 9 +- src/backend/access/heap/hio.c | 4 +- src/backend/access/heap/pruneheap.c | 4 +- src/backend/access/heap/rewriteheap.c | 4 +- src/backend/access/table/tableam.c | 2 +- src/backend/access/table/tableamapi.c | 25 ---- src/backend/commands/createas.c | 13 +- src/backend/commands/tablecmds.c | 63 ++++----- src/backend/commands/vacuum.c | 8 +- src/backend/postmaster/autovacuum.c | 13 +- src/backend/tcop/utility.c | 28 +--- src/backend/utils/cache/relcache.c | 54 +------- src/include/access/reloptions.h | 11 +- src/include/access/tableam.h | 50 ------- src/include/utils/rel.h | 148 ++++++++++---------- src/test/modules/Makefile | 1 - src/test/modules/meson.build | 1 - src/test/modules/test_tam_options/.gitignore | 4 - src/test/modules/test_tam_options/Makefile | 23 ---- .../test_tam_options/expected/test_tam_options.out | 36 ----- src/test/modules/test_tam_options/meson.build | 33 ----- .../test_tam_options/sql/test_tam_options.sql | 25 ---- .../test_tam_options/test_tam_options--1.0.sql | 12 -- .../modules/test_tam_options/test_tam_options.c | 66 --------- .../test_tam_options/test_tam_options.control | 4 - src/tools/pgindent/typedefs.list | 4 +- 29 files changed, 161 insertions(+), 650 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-04-11 13:23 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-04-02 08:44 pgsql: Revert "Custom reloptions for table AM" Alexander Korotkov <akorotkov@postgresql.org> 2024-04-11 13:23 pgsql: Revert: Custom reloptions for table AM Alexander Korotkov <akorotkov@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox