pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Improve check in LDAP test to find the OpenLDAP installation 6+ messages / 1 participants [nested] [flat]
* pgsql: Improve check in LDAP test to find the OpenLDAP installation @ 2024-04-07 17:31 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-04-07 17:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve check in LDAP test to find the OpenLDAP installation If the OpenLDAP installation directory is not found, set $setup to 0 so that the LDAP tests are skipped. The macOS checks were already doing that, but the checks on other OS's were not. While we're at it, improve the error message when the tests are skipped, to specify whether the OS is supported at all, or if we just didn't find the installation directory. This was accidentally "working" without this, i.e. we were skipping the tests if the OpenLDAP installation was not found, because of a bug in the LdapServer test module: the END block clobbered the exit code so if the script die()s before running the first subtest, the whole test script was marked as SKIPped. The next commit will fix that bug, but we need to fix the setup code first. These checks should probably go into configure/meson, but this is better than nothing and allows fixing the bug in the END block. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/fb898a70-3a88-4629-88e9-f2375020061d@iki.fi Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e13b586d7c989147afd910c6997659a8412a8b84 Modified Files -------------- src/test/ldap/LdapServer.pm | 91 ++++++++++++++++++++++++++++----------- src/test/ldap/t/001_auth.pl | 3 +- src/test/ldap/t/002_bindpasswd.pl | 3 +- 3 files changed, 67 insertions(+), 30 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Improve check in LDAP test to find the OpenLDAP installation @ 2024-04-07 17:31 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-04-07 17:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve check in LDAP test to find the OpenLDAP installation If the OpenLDAP installation directory is not found, set $setup to 0 so that the LDAP tests are skipped. The macOS checks were already doing that, but the checks on other OS's were not. While we're at it, improve the error message when the tests are skipped, to specify whether the OS is supported at all, or if we just didn't find the installation directory. This was accidentally "working" without this, i.e. we were skipping the tests if the OpenLDAP installation was not found, because of a bug in the LdapServer test module: the END block clobbered the exit code so if the script die()s before running the first subtest, the whole test script was marked as SKIPped. The next commit will fix that bug, but we need to fix the setup code first. These checks should probably go into configure/meson, but this is better than nothing and allows fixing the bug in the END block. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/fb898a70-3a88-4629-88e9-f2375020061d@iki.fi Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/854dd250ee178aca201e73923c99aac09b25ea9c Modified Files -------------- src/test/ldap/LdapServer.pm | 91 ++++++++++++++++++++++++++++----------- src/test/ldap/t/001_auth.pl | 3 +- src/test/ldap/t/002_bindpasswd.pl | 3 +- 3 files changed, 67 insertions(+), 30 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Improve check in LDAP test to find the OpenLDAP installation @ 2024-04-07 17:31 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-04-07 17:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve check in LDAP test to find the OpenLDAP installation If the OpenLDAP installation directory is not found, set $setup to 0 so that the LDAP tests are skipped. The macOS checks were already doing that, but the checks on other OS's were not. While we're at it, improve the error message when the tests are skipped, to specify whether the OS is supported at all, or if we just didn't find the installation directory. This was accidentally "working" without this, i.e. we were skipping the tests if the OpenLDAP installation was not found, because of a bug in the LdapServer test module: the END block clobbered the exit code so if the script die()s before running the first subtest, the whole test script was marked as SKIPped. The next commit will fix that bug, but we need to fix the setup code first. These checks should probably go into configure/meson, but this is better than nothing and allows fixing the bug in the END block. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/fb898a70-3a88-4629-88e9-f2375020061d@iki.fi Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1843a27efb56eee2f679a246c47bd56ad891592c Modified Files -------------- src/test/ldap/t/001_auth.pl | 84 ++++++++++++++++++++++++++++++--------------- 1 file changed, 56 insertions(+), 28 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Improve check in LDAP test to find the OpenLDAP installation @ 2024-04-07 17:31 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-04-07 17:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve check in LDAP test to find the OpenLDAP installation If the OpenLDAP installation directory is not found, set $setup to 0 so that the LDAP tests are skipped. The macOS checks were already doing that, but the checks on other OS's were not. While we're at it, improve the error message when the tests are skipped, to specify whether the OS is supported at all, or if we just didn't find the installation directory. This was accidentally "working" without this, i.e. we were skipping the tests if the OpenLDAP installation was not found, because of a bug in the LdapServer test module: the END block clobbered the exit code so if the script die()s before running the first subtest, the whole test script was marked as SKIPped. The next commit will fix that bug, but we need to fix the setup code first. These checks should probably go into configure/meson, but this is better than nothing and allows fixing the bug in the END block. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/fb898a70-3a88-4629-88e9-f2375020061d@iki.fi Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1782571f6537c1d1a3c65fbf47a1be445eb606e3 Modified Files -------------- src/test/ldap/t/001_auth.pl | 84 ++++++++++++++++++++++++++++++--------------- 1 file changed, 56 insertions(+), 28 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Improve check in LDAP test to find the OpenLDAP installation @ 2024-04-07 17:31 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-04-07 17:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve check in LDAP test to find the OpenLDAP installation If the OpenLDAP installation directory is not found, set $setup to 0 so that the LDAP tests are skipped. The macOS checks were already doing that, but the checks on other OS's were not. While we're at it, improve the error message when the tests are skipped, to specify whether the OS is supported at all, or if we just didn't find the installation directory. This was accidentally "working" without this, i.e. we were skipping the tests if the OpenLDAP installation was not found, because of a bug in the LdapServer test module: the END block clobbered the exit code so if the script die()s before running the first subtest, the whole test script was marked as SKIPped. The next commit will fix that bug, but we need to fix the setup code first. These checks should probably go into configure/meson, but this is better than nothing and allows fixing the bug in the END block. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/fb898a70-3a88-4629-88e9-f2375020061d@iki.fi Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9e0493445a575495b901bd8ab0d9c976ee6e4e62 Modified Files -------------- src/test/ldap/t/001_auth.pl | 84 ++++++++++++++++++++++++++++++--------------- 1 file changed, 56 insertions(+), 28 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Improve check in LDAP test to find the OpenLDAP installation @ 2024-04-07 17:31 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-04-07 17:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve check in LDAP test to find the OpenLDAP installation If the OpenLDAP installation directory is not found, set $setup to 0 so that the LDAP tests are skipped. The macOS checks were already doing that, but the checks on other OS's were not. While we're at it, improve the error message when the tests are skipped, to specify whether the OS is supported at all, or if we just didn't find the installation directory. This was accidentally "working" without this, i.e. we were skipping the tests if the OpenLDAP installation was not found, because of a bug in the LdapServer test module: the END block clobbered the exit code so if the script die()s before running the first subtest, the whole test script was marked as SKIPped. The next commit will fix that bug, but we need to fix the setup code first. These checks should probably go into configure/meson, but this is better than nothing and allows fixing the bug in the END block. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/fb898a70-3a88-4629-88e9-f2375020061d@iki.fi Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c8df46b65705c87ab5b76cefe1ff69aed72095bf Modified Files -------------- src/test/ldap/t/001_auth.pl | 83 +++++++++++++++++++++++++++++++-------------- 1 file changed, 58 insertions(+), 25 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-04-07 17:31 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-04-07 17:31 pgsql: Improve check in LDAP test to find the OpenLDAP installation Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-04-07 17:31 pgsql: Improve check in LDAP test to find the OpenLDAP installation Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-04-07 17:31 pgsql: Improve check in LDAP test to find the OpenLDAP installation Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-04-07 17:31 pgsql: Improve check in LDAP test to find the OpenLDAP installation Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-04-07 17:31 pgsql: Improve check in LDAP test to find the OpenLDAP installation Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-04-07 17:31 pgsql: Improve check in LDAP test to find the OpenLDAP installation Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox