pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). @ 2024-04-11 10:13 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Etsuro Fujita @ 2024-04-11 10:13 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix WaitEventSet resource leak in WaitLatchOrSocket(). This function would have the same issue we solved in commit 501cfd07d: If an error is thrown after calling CreateWaitEventSet(), the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that the WaitEventSet contains are leaked. Like that commit, use PG_TRY-PG_FINALLY (PG_TRY-PG_CATCH in v12) to make sure the WaitEventSet is freed properly. Back-patch to all supported versions, but as we do not have this issue in HEAD (cf. commit 50c67c201), no need to apply this patch to it. Discussion: https://postgr.es/m/CAPmGK16MqdDoD8oatp8SQWaEa4vS3nfQqDN_Sj9YRuu5J3Lj9g%40mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/01b01a77fe786740ec5e657e5f2ed0a94ab0ac17 Modified Files -------------- src/backend/storage/ipc/latch.c | 70 ++++++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 32 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). @ 2024-04-11 10:13 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Etsuro Fujita @ 2024-04-11 10:13 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix WaitEventSet resource leak in WaitLatchOrSocket(). This function would have the same issue we solved in commit 501cfd07d: If an error is thrown after calling CreateWaitEventSet(), the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that the WaitEventSet contains are leaked. Like that commit, use PG_TRY-PG_FINALLY (PG_TRY-PG_CATCH in v12) to make sure the WaitEventSet is freed properly. Back-patch to all supported versions, but as we do not have this issue in HEAD (cf. commit 50c67c201), no need to apply this patch to it. Discussion: https://postgr.es/m/CAPmGK16MqdDoD8oatp8SQWaEa4vS3nfQqDN_Sj9YRuu5J3Lj9g%40mail.gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0341d4b10e786dcbc4c63da9d21af842ab31e118 Modified Files -------------- src/backend/storage/ipc/latch.c | 69 +++++++++++++++++++++++------------------ 1 file changed, 39 insertions(+), 30 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). @ 2024-04-11 10:13 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Etsuro Fujita @ 2024-04-11 10:13 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix WaitEventSet resource leak in WaitLatchOrSocket(). This function would have the same issue we solved in commit 501cfd07d: If an error is thrown after calling CreateWaitEventSet(), the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that the WaitEventSet contains are leaked. Like that commit, use PG_TRY-PG_FINALLY (PG_TRY-PG_CATCH in v12) to make sure the WaitEventSet is freed properly. Back-patch to all supported versions, but as we do not have this issue in HEAD (cf. commit 50c67c201), no need to apply this patch to it. Discussion: https://postgr.es/m/CAPmGK16MqdDoD8oatp8SQWaEa4vS3nfQqDN_Sj9YRuu5J3Lj9g%40mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b714bc40cf066dde745fcb78fde160788730a7be Modified Files -------------- src/backend/storage/ipc/latch.c | 70 ++++++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 32 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). @ 2024-04-11 10:13 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Etsuro Fujita @ 2024-04-11 10:13 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix WaitEventSet resource leak in WaitLatchOrSocket(). This function would have the same issue we solved in commit 501cfd07d: If an error is thrown after calling CreateWaitEventSet(), the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that the WaitEventSet contains are leaked. Like that commit, use PG_TRY-PG_FINALLY (PG_TRY-PG_CATCH in v12) to make sure the WaitEventSet is freed properly. Back-patch to all supported versions, but as we do not have this issue in HEAD (cf. commit 50c67c201), no need to apply this patch to it. Discussion: https://postgr.es/m/CAPmGK16MqdDoD8oatp8SQWaEa4vS3nfQqDN_Sj9YRuu5J3Lj9g%40mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b82dca2a5a929c2b65174a073194a9cfb080052f Modified Files -------------- src/backend/storage/ipc/latch.c | 70 ++++++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 32 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). @ 2024-04-11 10:13 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Etsuro Fujita @ 2024-04-11 10:13 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix WaitEventSet resource leak in WaitLatchOrSocket(). This function would have the same issue we solved in commit 501cfd07d: If an error is thrown after calling CreateWaitEventSet(), the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that the WaitEventSet contains are leaked. Like that commit, use PG_TRY-PG_FINALLY (PG_TRY-PG_CATCH in v12) to make sure the WaitEventSet is freed properly. Back-patch to all supported versions, but as we do not have this issue in HEAD (cf. commit 50c67c201), no need to apply this patch to it. Discussion: https://postgr.es/m/CAPmGK16MqdDoD8oatp8SQWaEa4vS3nfQqDN_Sj9YRuu5J3Lj9g%40mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e79ceafe93a85820188e835adb392d38331ceed2 Modified Files -------------- src/backend/storage/ipc/latch.c | 70 ++++++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 32 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2024-04-11 10:13 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-04-11 10:13 pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). Etsuro Fujita <efujita@postgresql.org> 2024-04-11 10:13 pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). Etsuro Fujita <efujita@postgresql.org> 2024-04-11 10:13 pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). Etsuro Fujita <efujita@postgresql.org> 2024-04-11 10:13 pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). Etsuro Fujita <efujita@postgresql.org> 2024-04-11 10:13 pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). Etsuro Fujita <efujita@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox