pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Use the correct PG_DETOAST_DATUM macro in BRIN 2+ messages / 1 participants [nested] [flat]
* pgsql: Use the correct PG_DETOAST_DATUM macro in BRIN @ 2024-04-14 16:26 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Tomas Vondra @ 2024-04-14 16:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use the correct PG_DETOAST_DATUM macro in BRIN Commit 6bcda4a721 replaced PG_DETOAST_DATUM with PG_DETOAST_DATUM_PACKED in two BRIN output functions, for minmax-multi and bloom opclasses. But this is incorrect - the code is accessing the data through structs that already include a 4B header, so the detoast needs to match that. But the PACKED macro may keep the 1B header, which means the struct fields will point to incorrect data. Backpatch-through: 16 Discussion: https://postgr.es/m/1df00a66-db5a-4e66-809a-99b386a06d86%40enterprisedb.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/bb616ed3e6a2b263be320026e1660bd36827c858 Modified Files -------------- src/backend/access/brin/brin_bloom.c | 2 +- src/backend/access/brin/brin_minmax_multi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Use the correct PG_DETOAST_DATUM macro in BRIN @ 2024-04-14 16:27 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Tomas Vondra @ 2024-04-14 16:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use the correct PG_DETOAST_DATUM macro in BRIN Commit 6bcda4a721 replaced PG_DETOAST_DATUM with PG_DETOAST_DATUM_PACKED in two BRIN output functions, for minmax-multi and bloom opclasses. But this is incorrect - the code is accessing the data through structs that already include a 4B header, so the detoast needs to match that. But the PACKED macro may keep the 1B header, which means the struct fields will point to incorrect data. Backpatch-through: 16 Discussion: https://postgr.es/m/1df00a66-db5a-4e66-809a-99b386a06d86%40enterprisedb.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8cea358b128fea93c8360c9521dcf954775a38ca Modified Files -------------- src/backend/access/brin/brin_bloom.c | 2 +- src/backend/access/brin/brin_minmax_multi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-04-14 16:27 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-04-14 16:26 pgsql: Use the correct PG_DETOAST_DATUM macro in BRIN Tomas Vondra <tomas.vondra@postgresql.org> 2024-04-14 16:27 pgsql: Use the correct PG_DETOAST_DATUM macro in BRIN Tomas Vondra <tomas.vondra@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox