pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpg-migrator - pg_migrator: Add Win32 support for --link.
2+ messages / 2 participants
[nested] [flat]
* pg-migrator - pg_migrator: Add Win32 support for --link.
@ 2009-06-01 14:33 User Bmomjian <bmomjian@pgfoundry.org>
0 siblings, 0 replies; 2+ messages in thread
From: bmomjian@pgfoundry.org @ 2009-06-01 14:33 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Add Win32 support for --link. Win32 code from Hiroshi Saito.
Modified Files:
--------------
pg_migrator/src:
file.c (r1.14 -> r1.15)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/src/file.c?r1=1.14&r2=1.15)
pg_migrator.h (r1.39 -> r1.40)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/src/pg_migrator.h?r1=1.39&r2...)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Put back initialization of 'sslmode', to silence Coverity
@ 2024-04-14 20:04 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Linnakangas @ 2024-04-14 20:04 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Put back initialization of 'sslmode', to silence Coverity
Coverity pointed out that the function checks for conn->sslmode !=
NULL, which implies that it might be NULL, but later we access it
without a NULL-check anyway. It doesn't know that it is in fact always
initialized earlier, in conninfo_add_defaults(), and hence the
NULL-check is not necessary. However, there is a lot of distance
between conninfo_add_defaults() and pqConnectOptions2(), so it's not
surprising that it doesn't see that. Put back the initialization code,
as it existed before commit 05fd30c0e7, to silence the warning.
In the long run, I'd like to refactor the libpq options handling and
initalization code. It seems silly to strdup() and copy strings, for
things like sslmode that have a limited set of possible values; it
should be an enum. But that's for another day.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d21d61b96f7a4d89e4b2e7cc9b9a1ec3f642fa12
Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 6 ++++++
1 file changed, 6 insertions(+)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-04-14 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-01 14:33 pg-migrator - pg_migrator: Add Win32 support for --link. User Bmomjian <bmomjian@pgfoundry.org>
2024-04-14 20:04 pgsql: Put back initialization of 'sslmode', to silence Coverity Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox