pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpg-migrator - pg_migrator: Mention Postgres 8.4 Beta cannot be used,
5+ messages / 2 participants
[nested] [flat]
* pg-migrator - pg_migrator: Mention Postgres 8.4 Beta cannot be used,
@ 2009-06-12 17:40 User Bmomjian <bmomjian@pgfoundry.org>
0 siblings, 0 replies; 5+ messages in thread
From: bmomjian@pgfoundry.org @ 2009-06-12 17:40 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Mention Postgres 8.4 Beta cannot be used, only RC1 or later, due to
backend API change.
Modified Files:
--------------
pg_migrator:
README (r1.39 -> r1.40)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/README?r1=1.39&r2=1.40)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Throw a more on-point error for functions depending on columns.
@ 2024-04-28 18:34 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2024-04-28 18:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Throw a more on-point error for functions depending on columns.
ALTER COLUMN TYPE wasn't expecting to find any pg_proc objects
depending on the column whose type is to be altered. That indeed
wasn't possible when this code was written, but it is possible
since we introduced new-style SQL function bodies.
It's about as difficult to fix this case as it is to fix dependent
views, and we've been punting on those for years, so I don't feel
too awful about punting for functions too. (I sure wouldn't risk
back-patching such code.) So just throw a more user-facing error.
Also, adjust some of the existing comments to reflect that these
are all pretty much the same issue.
(This patch also fixes it so we will tolerate finding such a
dependency during ALTER COLUMN SET EXPRESSION; in that, we need
not do anything to the function, so no error is wanted. That
problem is new in HEAD.)
Per bug #18449 from Alexander Lakhin. Back-patch to v14 where
we added new-style SQL functions.
Discussion: https://postgr.es/m/18449-f8248467aaa294d5@postgresql.org
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b19255ca66f74fe9f8d0372db7d644d0bb4d6ac9
Modified Files
--------------
src/backend/commands/tablecmds.c | 30 +++++++++++++++++++++++++-----
1 file changed, 25 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Throw a more on-point error for functions depending on columns.
@ 2024-04-28 18:34 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2024-04-28 18:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Throw a more on-point error for functions depending on columns.
ALTER COLUMN TYPE wasn't expecting to find any pg_proc objects
depending on the column whose type is to be altered. That indeed
wasn't possible when this code was written, but it is possible
since we introduced new-style SQL function bodies.
It's about as difficult to fix this case as it is to fix dependent
views, and we've been punting on those for years, so I don't feel
too awful about punting for functions too. (I sure wouldn't risk
back-patching such code.) So just throw a more user-facing error.
Also, adjust some of the existing comments to reflect that these
are all pretty much the same issue.
(This patch also fixes it so we will tolerate finding such a
dependency during ALTER COLUMN SET EXPRESSION; in that, we need
not do anything to the function, so no error is wanted. That
problem is new in HEAD.)
Per bug #18449 from Alexander Lakhin. Back-patch to v14 where
we added new-style SQL functions.
Discussion: https://postgr.es/m/18449-f8248467aaa294d5@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/42b041243c00fb20023c983357e7f1ffd3710fff
Modified Files
--------------
src/backend/commands/tablecmds.c | 34 ++++++++++++++++++++++++++++++----
1 file changed, 30 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Throw a more on-point error for functions depending on columns.
@ 2024-04-28 18:34 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2024-04-28 18:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Throw a more on-point error for functions depending on columns.
ALTER COLUMN TYPE wasn't expecting to find any pg_proc objects
depending on the column whose type is to be altered. That indeed
wasn't possible when this code was written, but it is possible
since we introduced new-style SQL function bodies.
It's about as difficult to fix this case as it is to fix dependent
views, and we've been punting on those for years, so I don't feel
too awful about punting for functions too. (I sure wouldn't risk
back-patching such code.) So just throw a more user-facing error.
Also, adjust some of the existing comments to reflect that these
are all pretty much the same issue.
(This patch also fixes it so we will tolerate finding such a
dependency during ALTER COLUMN SET EXPRESSION; in that, we need
not do anything to the function, so no error is wanted. That
problem is new in HEAD.)
Per bug #18449 from Alexander Lakhin. Back-patch to v14 where
we added new-style SQL functions.
Discussion: https://postgr.es/m/18449-f8248467aaa294d5@postgresql.org
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9b41d1d634aa9a3a36a21c5624b25c8475fd51ee
Modified Files
--------------
src/backend/commands/tablecmds.c | 30 +++++++++++++++++++++++++-----
1 file changed, 25 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Throw a more on-point error for functions depending on columns.
@ 2024-04-28 18:34 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2024-04-28 18:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Throw a more on-point error for functions depending on columns.
ALTER COLUMN TYPE wasn't expecting to find any pg_proc objects
depending on the column whose type is to be altered. That indeed
wasn't possible when this code was written, but it is possible
since we introduced new-style SQL function bodies.
It's about as difficult to fix this case as it is to fix dependent
views, and we've been punting on those for years, so I don't feel
too awful about punting for functions too. (I sure wouldn't risk
back-patching such code.) So just throw a more user-facing error.
Also, adjust some of the existing comments to reflect that these
are all pretty much the same issue.
(This patch also fixes it so we will tolerate finding such a
dependency during ALTER COLUMN SET EXPRESSION; in that, we need
not do anything to the function, so no error is wanted. That
problem is new in HEAD.)
Per bug #18449 from Alexander Lakhin. Back-patch to v14 where
we added new-style SQL functions.
Discussion: https://postgr.es/m/18449-f8248467aaa294d5@postgresql.org
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/617a23927249c78f23ef005aaa78b508570f4cc8
Modified Files
--------------
src/backend/commands/tablecmds.c | 30 +++++++++++++++++++++++++-----
1 file changed, 25 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2024-04-28 18:34 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-12 17:40 pg-migrator - pg_migrator: Mention Postgres 8.4 Beta cannot be used, User Bmomjian <bmomjian@pgfoundry.org>
2024-04-28 18:34 pgsql: Throw a more on-point error for functions depending on columns. Tom Lane <tgl@sss.pgh.pa.us>
2024-04-28 18:34 pgsql: Throw a more on-point error for functions depending on columns. Tom Lane <tgl@sss.pgh.pa.us>
2024-04-28 18:34 pgsql: Throw a more on-point error for functions depending on columns. Tom Lane <tgl@sss.pgh.pa.us>
2024-04-28 18:34 pgsql: Throw a more on-point error for functions depending on columns. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox