pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca 6+ messages / 1 participants [nested] [flat]
* pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca @ 2024-05-01 01:21 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2024-05-01 01:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure we allocate NAMEDATALEN bytes for names in Index Only Scans As an optimization, we store "name" columns as cstrings in btree indexes. Here we modify it so that Index Only Scans convert these cstrings back to names with NAMEDATALEN bytes rather than storing the cstring in the tuple slot, as was happening previously. Bug: #17855 Reported-by: Alexander Lakhin Reviewed-by: Alexander Lakhin, Tom Lane Discussion: https://postgr.es/m/17855-5f523e0f9769a566@postgresql.org Backpatch-through: 12, all supported versions Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/a63224be49b86fccbf1bf1809d516626bce7ba11 Modified Files -------------- src/backend/executor/nodeIndexonlyscan.c | 95 +++++++++++++++++++++++++-- src/include/catalog/pg_opclass.dat | 7 +- src/include/nodes/execnodes.h | 4 ++ src/test/regress/expected/index_including.out | 25 +++++++ src/test/regress/sql/index_including.sql | 19 ++++++ 5 files changed, 141 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca @ 2024-05-01 01:22 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2024-05-01 01:22 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure we allocate NAMEDATALEN bytes for names in Index Only Scans As an optimization, we store "name" columns as cstrings in btree indexes. Here we modify it so that Index Only Scans convert these cstrings back to names with NAMEDATALEN bytes rather than storing the cstring in the tuple slot, as was happening previously. Bug: #17855 Reported-by: Alexander Lakhin Reviewed-by: Alexander Lakhin, Tom Lane Discussion: https://postgr.es/m/17855-5f523e0f9769a566@postgresql.org Backpatch-through: 12, all supported versions Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/68d358545037c51723a7ff0ab96f489e066a6fdd Modified Files -------------- src/backend/executor/nodeIndexonlyscan.c | 95 +++++++++++++++++++++++++-- src/include/catalog/pg_opclass.dat | 7 +- src/include/nodes/execnodes.h | 4 ++ src/test/regress/expected/index_including.out | 25 +++++++ src/test/regress/sql/index_including.sql | 19 ++++++ 5 files changed, 141 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca @ 2024-05-01 01:22 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2024-05-01 01:22 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure we allocate NAMEDATALEN bytes for names in Index Only Scans As an optimization, we store "name" columns as cstrings in btree indexes. Here we modify it so that Index Only Scans convert these cstrings back to names with NAMEDATALEN bytes rather than storing the cstring in the tuple slot, as was happening previously. Bug: #17855 Reported-by: Alexander Lakhin Reviewed-by: Alexander Lakhin, Tom Lane Discussion: https://postgr.es/m/17855-5f523e0f9769a566@postgresql.org Backpatch-through: 12, all supported versions Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/52f21f928732418b333232a36fb02890f9c87b52 Modified Files -------------- src/backend/executor/nodeIndexonlyscan.c | 95 +++++++++++++++++++++++++-- src/include/catalog/pg_opclass.dat | 7 +- src/include/nodes/execnodes.h | 4 ++ src/test/regress/expected/index_including.out | 25 +++++++ src/test/regress/sql/index_including.sql | 19 ++++++ 5 files changed, 141 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca @ 2024-05-01 01:22 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2024-05-01 01:22 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure we allocate NAMEDATALEN bytes for names in Index Only Scans As an optimization, we store "name" columns as cstrings in btree indexes. Here we modify it so that Index Only Scans convert these cstrings back to names with NAMEDATALEN bytes rather than storing the cstring in the tuple slot, as was happening previously. Bug: #17855 Reported-by: Alexander Lakhin Reviewed-by: Alexander Lakhin, Tom Lane Discussion: https://postgr.es/m/17855-5f523e0f9769a566@postgresql.org Backpatch-through: 12, all supported versions Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e6b0efc65e5885a0e46050df341c88f4a5ee76cd Modified Files -------------- src/backend/executor/nodeIndexonlyscan.c | 95 +++++++++++++++++++++++++-- src/include/catalog/pg_opclass.dat | 7 +- src/include/nodes/execnodes.h | 4 ++ src/test/regress/expected/index_including.out | 25 +++++++ src/test/regress/sql/index_including.sql | 19 ++++++ 5 files changed, 141 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca @ 2024-05-01 01:23 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2024-05-01 01:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure we allocate NAMEDATALEN bytes for names in Index Only Scans As an optimization, we store "name" columns as cstrings in btree indexes. Here we modify it so that Index Only Scans convert these cstrings back to names with NAMEDATALEN bytes rather than storing the cstring in the tuple slot, as was happening previously. Bug: #17855 Reported-by: Alexander Lakhin Reviewed-by: Alexander Lakhin, Tom Lane Discussion: https://postgr.es/m/17855-5f523e0f9769a566@postgresql.org Backpatch-through: 12, all supported versions Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0a34bcd0c23e7f67daad7b026320a12c52d797ac Modified Files -------------- src/backend/executor/nodeIndexonlyscan.c | 95 +++++++++++++++++++++++++-- src/include/catalog/pg_opclass.dat | 7 +- src/include/nodes/execnodes.h | 4 ++ src/test/regress/expected/index_including.out | 25 +++++++ src/test/regress/sql/index_including.sql | 19 ++++++ 5 files changed, 141 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca @ 2024-05-01 01:23 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2024-05-01 01:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure we allocate NAMEDATALEN bytes for names in Index Only Scans As an optimization, we store "name" columns as cstrings in btree indexes. Here we modify it so that Index Only Scans convert these cstrings back to names with NAMEDATALEN bytes rather than storing the cstring in the tuple slot, as was happening previously. Bug: #17855 Reported-by: Alexander Lakhin Reviewed-by: Alexander Lakhin, Tom Lane Discussion: https://postgr.es/m/17855-5f523e0f9769a566@postgresql.org Backpatch-through: 12, all supported versions Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e3f9dcabd6f2c4c1845f16ec24b59e0751b055af Modified Files -------------- src/backend/executor/nodeIndexonlyscan.c | 95 +++++++++++++++++++++++++-- src/include/catalog/pg_opclass.dat | 7 +- src/include/nodes/execnodes.h | 4 ++ src/test/regress/expected/index_including.out | 25 +++++++ src/test/regress/sql/index_including.sql | 19 ++++++ 5 files changed, 141 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-05-01 01:23 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-05-01 01:21 pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca David Rowley <drowley@postgresql.org> 2024-05-01 01:22 pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca David Rowley <drowley@postgresql.org> 2024-05-01 01:22 pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca David Rowley <drowley@postgresql.org> 2024-05-01 01:22 pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca David Rowley <drowley@postgresql.org> 2024-05-01 01:23 pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca David Rowley <drowley@postgresql.org> 2024-05-01 01:23 pgsql: Ensure we allocate NAMEDATALEN bytes for names in Index Only Sca David Rowley <drowley@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox