pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Re-forbid underscore in positional parameters 2+ messages / 1 participants [nested] [flat]
* pgsql: Re-forbid underscore in positional parameters @ 2024-05-15 11:57 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2024-05-15 11:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Re-forbid underscore in positional parameters Underscores were added to numeric literals in faff8f8e47. This change also affected the positional parameters (e.g., $1) rule, which uses the same production for its digits. But this did not actually work, because the digits for parameters are processed using atol(), which does not handle underscores and ignores whatever it cannot parse. The underscores notation is probably not useful for positional parameters, so for simplicity revert that rule to its old form that only accepts digits 0-9. Author: Erik Wienhold <ewie@ewie.name> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://www.postgresql.org/message-id/flat/5d216d1c-91f6-4cbe-95e2-b4cbd930520c%40ewie.name Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/98b4f53d156efe09294d6e1d62a5b52f544eee29 Modified Files -------------- src/backend/parser/scan.l | 5 +++-- src/fe_utils/psqlscan.l | 5 +++-- src/interfaces/ecpg/preproc/pgc.l | 5 +++-- src/test/regress/expected/numerology.out | 4 ++++ src/test/regress/sql/numerology.sql | 1 + 5 files changed, 14 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Re-forbid underscore in positional parameters @ 2024-05-15 11:57 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2024-05-15 11:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Re-forbid underscore in positional parameters Underscores were added to numeric literals in faff8f8e47. This change also affected the positional parameters (e.g., $1) rule, which uses the same production for its digits. But this did not actually work, because the digits for parameters are processed using atol(), which does not handle underscores and ignores whatever it cannot parse. The underscores notation is probably not useful for positional parameters, so for simplicity revert that rule to its old form that only accepts digits 0-9. Author: Erik Wienhold <ewie@ewie.name> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://www.postgresql.org/message-id/flat/5d216d1c-91f6-4cbe-95e2-b4cbd930520c%40ewie.name Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/315661ecafbcbb23116cceea2ea80657d7763af0 Modified Files -------------- src/backend/parser/scan.l | 5 +++-- src/fe_utils/psqlscan.l | 5 +++-- src/interfaces/ecpg/preproc/pgc.l | 5 +++-- src/test/regress/expected/numerology.out | 4 ++++ src/test/regress/sql/numerology.sql | 1 + 5 files changed, 14 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-05-15 11:57 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-05-15 11:57 pgsql: Re-forbid underscore in positional parameters Peter Eisentraut <peter@eisentraut.org> 2024-05-15 11:57 pgsql: Re-forbid underscore in positional parameters Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox