pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Improve stability of subscription/029_on_error.pl 3+ messages / 1 participants [nested] [flat]
* pgsql: Improve stability of subscription/029_on_error.pl @ 2024-05-24 02:21 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2024-05-24 02:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve stability of subscription/029_on_error.pl This test was failing when using wal_debug=on and -DWAL_DEBUG because of additional log entries that made the test grab an LSN not mapping with the error expected in the test. Previously the test would look for the first matching line to get the LSN to skip up to. This is improved by having the test scan the logs with a regexp that checks for the expected ERROR string, ensuring that the wanted LSN comes from the correct context. Backpatch down to 15 where this test has been introduced. Author: Ian Ilyasov Discussion: https://postgr.es/m/GV1P251MB100415F17E6B2FDD7188777ECDE32@GV1P251MB1004.EURP251.PROD.OUTLOOK.COM Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ac8c85d04b133509071b1de60a027ebe00654696 Modified Files -------------- src/test/subscription/t/029_on_error.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Improve stability of subscription/029_on_error.pl @ 2024-05-24 02:21 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2024-05-24 02:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve stability of subscription/029_on_error.pl This test was failing when using wal_debug=on and -DWAL_DEBUG because of additional log entries that made the test grab an LSN not mapping with the error expected in the test. Previously the test would look for the first matching line to get the LSN to skip up to. This is improved by having the test scan the logs with a regexp that checks for the expected ERROR string, ensuring that the wanted LSN comes from the correct context. Backpatch down to 15 where this test has been introduced. Author: Ian Ilyasov Discussion: https://postgr.es/m/GV1P251MB100415F17E6B2FDD7188777ECDE32@GV1P251MB1004.EURP251.PROD.OUTLOOK.COM Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/338fb8714c6cfe30c567ecb79812ec3879bd117f Modified Files -------------- src/test/subscription/t/029_on_error.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Improve stability of subscription/029_on_error.pl @ 2024-05-24 02:21 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2024-05-24 02:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve stability of subscription/029_on_error.pl This test was failing when using wal_debug=on and -DWAL_DEBUG because of additional log entries that made the test grab an LSN not mapping with the error expected in the test. Previously the test would look for the first matching line to get the LSN to skip up to. This is improved by having the test scan the logs with a regexp that checks for the expected ERROR string, ensuring that the wanted LSN comes from the correct context. Backpatch down to 15 where this test has been introduced. Author: Ian Ilyasov Discussion: https://postgr.es/m/GV1P251MB100415F17E6B2FDD7188777ECDE32@GV1P251MB1004.EURP251.PROD.OUTLOOK.COM Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8e16f81f3db4eb03ac2195e9e5527852047c14a0 Modified Files -------------- src/test/subscription/t/029_on_error.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-05-24 02:21 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-05-24 02:21 pgsql: Improve stability of subscription/029_on_error.pl Michael Paquier <michael@paquier.xyz> 2024-05-24 02:21 pgsql: Improve stability of subscription/029_on_error.pl Michael Paquier <michael@paquier.xyz> 2024-05-24 02:21 pgsql: Improve stability of subscription/029_on_error.pl Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox