pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser 5+ messages / 1 participants [nested] [flat]
* pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser @ 2024-06-07 08:55 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Etsuro Fujita @ 2024-06-07 08:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers. Previously, when considering LIMIT pushdown, postgres_fdw failed to check whether the query has this clause, which led to pushing false LIMIT clauses, causing incorrect results. This clause has been supported since v13, so we need to do a remote-version check before deciding that it will be safe to push such a clause, but we do not currently have a way to do the check (without accessing the remote server); disable pushing such a clause for now. Oversight in commit 357889eb1. Back-patch to v13, where that commit added the support. Per bug #18467 from Onder Kalaci. Patch by Japin Li, per a suggestion from Tom Lane, with some changes to the comments by me. Review by Onder Kalaci, Alvaro Herrera, and me. Discussion: https://postgr.es/m/18467-7bb89084ff03a08d%40postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8cfbac1492bddc6a81c1c3794355e1d7ac82e957 Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 21 +++++++++++++++++++++ contrib/postgres_fdw/postgres_fdw.c | 14 ++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 5 +++++ 3 files changed, 40 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser @ 2024-06-07 08:55 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Etsuro Fujita @ 2024-06-07 08:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers. Previously, when considering LIMIT pushdown, postgres_fdw failed to check whether the query has this clause, which led to pushing false LIMIT clauses, causing incorrect results. This clause has been supported since v13, so we need to do a remote-version check before deciding that it will be safe to push such a clause, but we do not currently have a way to do the check (without accessing the remote server); disable pushing such a clause for now. Oversight in commit 357889eb1. Back-patch to v13, where that commit added the support. Per bug #18467 from Onder Kalaci. Patch by Japin Li, per a suggestion from Tom Lane, with some changes to the comments by me. Review by Onder Kalaci, Alvaro Herrera, and me. Discussion: https://postgr.es/m/18467-7bb89084ff03a08d%40postgresql.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8405d5a37a25c53e568b2bf290a0ba5189940190 Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 21 +++++++++++++++++++++ contrib/postgres_fdw/postgres_fdw.c | 14 ++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 5 +++++ 3 files changed, 40 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser @ 2024-06-07 08:55 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Etsuro Fujita @ 2024-06-07 08:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers. Previously, when considering LIMIT pushdown, postgres_fdw failed to check whether the query has this clause, which led to pushing false LIMIT clauses, causing incorrect results. This clause has been supported since v13, so we need to do a remote-version check before deciding that it will be safe to push such a clause, but we do not currently have a way to do the check (without accessing the remote server); disable pushing such a clause for now. Oversight in commit 357889eb1. Back-patch to v13, where that commit added the support. Per bug #18467 from Onder Kalaci. Patch by Japin Li, per a suggestion from Tom Lane, with some changes to the comments by me. Review by Onder Kalaci, Alvaro Herrera, and me. Discussion: https://postgr.es/m/18467-7bb89084ff03a08d%40postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b33c141cc52b5dfdf06dea1c36874a5842bada8f Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 21 +++++++++++++++++++++ contrib/postgres_fdw/postgres_fdw.c | 14 ++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 5 +++++ 3 files changed, 40 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser @ 2024-06-07 08:55 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Etsuro Fujita @ 2024-06-07 08:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers. Previously, when considering LIMIT pushdown, postgres_fdw failed to check whether the query has this clause, which led to pushing false LIMIT clauses, causing incorrect results. This clause has been supported since v13, so we need to do a remote-version check before deciding that it will be safe to push such a clause, but we do not currently have a way to do the check (without accessing the remote server); disable pushing such a clause for now. Oversight in commit 357889eb1. Back-patch to v13, where that commit added the support. Per bug #18467 from Onder Kalaci. Patch by Japin Li, per a suggestion from Tom Lane, with some changes to the comments by me. Review by Onder Kalaci, Alvaro Herrera, and me. Discussion: https://postgr.es/m/18467-7bb89084ff03a08d%40postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/269e2c39162811a170d7e8f87a1a0bde3b9e2fab Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 21 +++++++++++++++++++++ contrib/postgres_fdw/postgres_fdw.c | 14 ++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 5 +++++ 3 files changed, 40 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser @ 2024-06-07 08:55 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Etsuro Fujita @ 2024-06-07 08:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers. Previously, when considering LIMIT pushdown, postgres_fdw failed to check whether the query has this clause, which led to pushing false LIMIT clauses, causing incorrect results. This clause has been supported since v13, so we need to do a remote-version check before deciding that it will be safe to push such a clause, but we do not currently have a way to do the check (without accessing the remote server); disable pushing such a clause for now. Oversight in commit 357889eb1. Back-patch to v13, where that commit added the support. Per bug #18467 from Onder Kalaci. Patch by Japin Li, per a suggestion from Tom Lane, with some changes to the comments by me. Review by Onder Kalaci, Alvaro Herrera, and me. Discussion: https://postgr.es/m/18467-7bb89084ff03a08d%40postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2b461efc5195e9b359dcf0ac98487bdfcbd1347f Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 21 +++++++++++++++++++++ contrib/postgres_fdw/postgres_fdw.c | 14 ++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 5 +++++ 3 files changed, 40 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2024-06-07 08:55 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-06-07 08:55 pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser Etsuro Fujita <efujita@postgresql.org> 2024-06-07 08:55 pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser Etsuro Fujita <efujita@postgresql.org> 2024-06-07 08:55 pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser Etsuro Fujita <efujita@postgresql.org> 2024-06-07 08:55 pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser Etsuro Fujita <efujita@postgresql.org> 2024-06-07 08:55 pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser Etsuro Fujita <efujita@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox