pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Tighten test_predtest's input checks, and improve error messages 6+ messages / 1 participants [nested] [flat]
* pgsql: Tighten test_predtest's input checks, and improve error messages @ 2024-06-07 20:46 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-06-07 20:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten test_predtest's input checks, and improve error messages. test_predtest() neglected to consider the possibility that SPI_plan_get_cached_plan would return NULL. This led to a core dump if the input (incorrectly) contains more than one SQL command. While here, let's expend more than zero effort on the error message for this case and nearby ones. Per (half of) bug #18483 from Alexander Kozhemyakin. Back-patch to all supported branches, not because this is very significant (it's merely test scaffolding) but to make our world a bit safer for fuzz testing. Discussion: https://postgr.es/m/18483-30bfff42de238000@postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d8062ead3d8382febf15194383199ac9ace94038 Modified Files -------------- src/test/modules/test_predtest/test_predtest.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Tighten test_predtest's input checks, and improve error messages @ 2024-06-07 20:46 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-06-07 20:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten test_predtest's input checks, and improve error messages. test_predtest() neglected to consider the possibility that SPI_plan_get_cached_plan would return NULL. This led to a core dump if the input (incorrectly) contains more than one SQL command. While here, let's expend more than zero effort on the error message for this case and nearby ones. Per (half of) bug #18483 from Alexander Kozhemyakin. Back-patch to all supported branches, not because this is very significant (it's merely test scaffolding) but to make our world a bit safer for fuzz testing. Discussion: https://postgr.es/m/18483-30bfff42de238000@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/00ac25a3c365004821e819653c3307acd3294818 Modified Files -------------- src/test/modules/test_predtest/test_predtest.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Tighten test_predtest's input checks, and improve error messages @ 2024-06-07 20:46 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-06-07 20:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten test_predtest's input checks, and improve error messages. test_predtest() neglected to consider the possibility that SPI_plan_get_cached_plan would return NULL. This led to a core dump if the input (incorrectly) contains more than one SQL command. While here, let's expend more than zero effort on the error message for this case and nearby ones. Per (half of) bug #18483 from Alexander Kozhemyakin. Back-patch to all supported branches, not because this is very significant (it's merely test scaffolding) but to make our world a bit safer for fuzz testing. Discussion: https://postgr.es/m/18483-30bfff42de238000@postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f4b44f2786950782526b407ead5daa849df3cb1b Modified Files -------------- src/test/modules/test_predtest/test_predtest.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Tighten test_predtest's input checks, and improve error messages @ 2024-06-07 20:46 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-06-07 20:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten test_predtest's input checks, and improve error messages. test_predtest() neglected to consider the possibility that SPI_plan_get_cached_plan would return NULL. This led to a core dump if the input (incorrectly) contains more than one SQL command. While here, let's expend more than zero effort on the error message for this case and nearby ones. Per (half of) bug #18483 from Alexander Kozhemyakin. Back-patch to all supported branches, not because this is very significant (it's merely test scaffolding) but to make our world a bit safer for fuzz testing. Discussion: https://postgr.es/m/18483-30bfff42de238000@postgresql.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f1f6ded66897efbf2ee520a8213a43251398ddf2 Modified Files -------------- src/test/modules/test_predtest/test_predtest.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Tighten test_predtest's input checks, and improve error messages @ 2024-06-07 20:46 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-06-07 20:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten test_predtest's input checks, and improve error messages. test_predtest() neglected to consider the possibility that SPI_plan_get_cached_plan would return NULL. This led to a core dump if the input (incorrectly) contains more than one SQL command. While here, let's expend more than zero effort on the error message for this case and nearby ones. Per (half of) bug #18483 from Alexander Kozhemyakin. Back-patch to all supported branches, not because this is very significant (it's merely test scaffolding) but to make our world a bit safer for fuzz testing. Discussion: https://postgr.es/m/18483-30bfff42de238000@postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2eba27571edcce56ac04838792e79cb23fe179d4 Modified Files -------------- src/test/modules/test_predtest/test_predtest.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Tighten test_predtest's input checks, and improve error messages @ 2024-06-07 20:46 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2024-06-07 20:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten test_predtest's input checks, and improve error messages. test_predtest() neglected to consider the possibility that SPI_plan_get_cached_plan would return NULL. This led to a core dump if the input (incorrectly) contains more than one SQL command. While here, let's expend more than zero effort on the error message for this case and nearby ones. Per (half of) bug #18483 from Alexander Kozhemyakin. Back-patch to all supported branches, not because this is very significant (it's merely test scaffolding) but to make our world a bit safer for fuzz testing. Discussion: https://postgr.es/m/18483-30bfff42de238000@postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5f200ab5749a0813c48b45b217b273abeb2fdc52 Modified Files -------------- src/test/modules/test_predtest/test_predtest.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-06-07 20:46 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-06-07 20:46 pgsql: Tighten test_predtest's input checks, and improve error messages Tom Lane <tgl@sss.pgh.pa.us> 2024-06-07 20:46 pgsql: Tighten test_predtest's input checks, and improve error messages Tom Lane <tgl@sss.pgh.pa.us> 2024-06-07 20:46 pgsql: Tighten test_predtest's input checks, and improve error messages Tom Lane <tgl@sss.pgh.pa.us> 2024-06-07 20:46 pgsql: Tighten test_predtest's input checks, and improve error messages Tom Lane <tgl@sss.pgh.pa.us> 2024-06-07 20:46 pgsql: Tighten test_predtest's input checks, and improve error messages Tom Lane <tgl@sss.pgh.pa.us> 2024-06-07 20:46 pgsql: Tighten test_predtest's input checks, and improve error messages Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox