pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Clean out column-level pg_init_privs entries when dropping table
6+ messages / 1 participants
[nested] [flat]
* pgsql: Clean out column-level pg_init_privs entries when dropping table
@ 2024-06-14 20:20 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2024-06-14 20:20 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Clean out column-level pg_init_privs entries when dropping tables.
DeleteInitPrivs did not get the memo about how, when dropping a
whole object (with subid == 0), you should drop entries relating
to its sub-objects too. This is visible in the test_pg_dump test
case if one drops the extension at the end: the entry for
GRANT SELECT(col1) ON regress_pg_dump_table TO public;
was still present in pg_init_privs afterwards, although it was
pointing to a dangling table OID.
Noted while fooling with a fix for REASSIGN OWNED for pg_init_privs
entries. This bug is aboriginal in the pg_init_privs feature
though, and there seems no reason not to back-patch the fix.
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9cf4beb9e7adf3225c33df256c4e7d54805ec4f8
Modified Files
--------------
src/backend/catalog/dependency.c | 21 +++++++++++++++------
.../modules/test_pg_dump/expected/test_pg_dump.out | 7 +++++++
src/test/modules/test_pg_dump/sql/test_pg_dump.sql | 5 +++++
3 files changed, 27 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Clean out column-level pg_init_privs entries when dropping table
@ 2024-06-14 20:20 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2024-06-14 20:20 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Clean out column-level pg_init_privs entries when dropping tables.
DeleteInitPrivs did not get the memo about how, when dropping a
whole object (with subid == 0), you should drop entries relating
to its sub-objects too. This is visible in the test_pg_dump test
case if one drops the extension at the end: the entry for
GRANT SELECT(col1) ON regress_pg_dump_table TO public;
was still present in pg_init_privs afterwards, although it was
pointing to a dangling table OID.
Noted while fooling with a fix for REASSIGN OWNED for pg_init_privs
entries. This bug is aboriginal in the pg_init_privs feature
though, and there seems no reason not to back-patch the fix.
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/1f1eedd3fa696f41ba426ebcd5de4fe08b5005cf
Modified Files
--------------
src/backend/catalog/dependency.c | 21 +++++++++++++++------
.../modules/test_pg_dump/expected/test_pg_dump.out | 7 +++++++
src/test/modules/test_pg_dump/sql/test_pg_dump.sql | 5 +++++
3 files changed, 27 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Clean out column-level pg_init_privs entries when dropping table
@ 2024-06-14 20:20 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2024-06-14 20:20 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Clean out column-level pg_init_privs entries when dropping tables.
DeleteInitPrivs did not get the memo about how, when dropping a
whole object (with subid == 0), you should drop entries relating
to its sub-objects too. This is visible in the test_pg_dump test
case if one drops the extension at the end: the entry for
GRANT SELECT(col1) ON regress_pg_dump_table TO public;
was still present in pg_init_privs afterwards, although it was
pointing to a dangling table OID.
Noted while fooling with a fix for REASSIGN OWNED for pg_init_privs
entries. This bug is aboriginal in the pg_init_privs feature
though, and there seems no reason not to back-patch the fix.
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f3f6a14ce3e982fb7fbe9f4f33134f3f693f4b7e
Modified Files
--------------
src/backend/catalog/dependency.c | 21 +++++++++++++++------
.../modules/test_pg_dump/expected/test_pg_dump.out | 7 +++++++
src/test/modules/test_pg_dump/sql/test_pg_dump.sql | 5 +++++
3 files changed, 27 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Clean out column-level pg_init_privs entries when dropping table
@ 2024-06-14 20:20 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2024-06-14 20:20 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Clean out column-level pg_init_privs entries when dropping tables.
DeleteInitPrivs did not get the memo about how, when dropping a
whole object (with subid == 0), you should drop entries relating
to its sub-objects too. This is visible in the test_pg_dump test
case if one drops the extension at the end: the entry for
GRANT SELECT(col1) ON regress_pg_dump_table TO public;
was still present in pg_init_privs afterwards, although it was
pointing to a dangling table OID.
Noted while fooling with a fix for REASSIGN OWNED for pg_init_privs
entries. This bug is aboriginal in the pg_init_privs feature
though, and there seems no reason not to back-patch the fix.
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/198de79612f04f45320781d0a57ee77d9043d0c2
Modified Files
--------------
src/backend/catalog/dependency.c | 21 +++++++++++++++------
.../modules/test_pg_dump/expected/test_pg_dump.out | 7 +++++++
src/test/modules/test_pg_dump/sql/test_pg_dump.sql | 5 +++++
3 files changed, 27 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Clean out column-level pg_init_privs entries when dropping table
@ 2024-06-14 20:20 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2024-06-14 20:20 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Clean out column-level pg_init_privs entries when dropping tables.
DeleteInitPrivs did not get the memo about how, when dropping a
whole object (with subid == 0), you should drop entries relating
to its sub-objects too. This is visible in the test_pg_dump test
case if one drops the extension at the end: the entry for
GRANT SELECT(col1) ON regress_pg_dump_table TO public;
was still present in pg_init_privs afterwards, although it was
pointing to a dangling table OID.
Noted while fooling with a fix for REASSIGN OWNED for pg_init_privs
entries. This bug is aboriginal in the pg_init_privs feature
though, and there seems no reason not to back-patch the fix.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/76618097a6c027ec603a3dd143f61098e3fb9794
Modified Files
--------------
src/backend/catalog/dependency.c | 21 +++++++++++++++------
.../modules/test_pg_dump/expected/test_pg_dump.out | 7 +++++++
src/test/modules/test_pg_dump/sql/test_pg_dump.sql | 5 +++++
3 files changed, 27 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Clean out column-level pg_init_privs entries when dropping table
@ 2024-06-14 20:20 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2024-06-14 20:20 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Clean out column-level pg_init_privs entries when dropping tables.
DeleteInitPrivs did not get the memo about how, when dropping a
whole object (with subid == 0), you should drop entries relating
to its sub-objects too. This is visible in the test_pg_dump test
case if one drops the extension at the end: the entry for
GRANT SELECT(col1) ON regress_pg_dump_table TO public;
was still present in pg_init_privs afterwards, although it was
pointing to a dangling table OID.
Noted while fooling with a fix for REASSIGN OWNED for pg_init_privs
entries. This bug is aboriginal in the pg_init_privs feature
though, and there seems no reason not to back-patch the fix.
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0a39343ae7d7430f4a993c404d95162f60daf937
Modified Files
--------------
src/backend/catalog/dependency.c | 21 +++++++++++++++------
.../modules/test_pg_dump/expected/test_pg_dump.out | 7 +++++++
src/test/modules/test_pg_dump/sql/test_pg_dump.sql | 5 +++++
3 files changed, 27 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-06-14 20:20 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-06-14 20:20 pgsql: Clean out column-level pg_init_privs entries when dropping table Tom Lane <tgl@sss.pgh.pa.us>
2024-06-14 20:20 pgsql: Clean out column-level pg_init_privs entries when dropping table Tom Lane <tgl@sss.pgh.pa.us>
2024-06-14 20:20 pgsql: Clean out column-level pg_init_privs entries when dropping table Tom Lane <tgl@sss.pgh.pa.us>
2024-06-14 20:20 pgsql: Clean out column-level pg_init_privs entries when dropping table Tom Lane <tgl@sss.pgh.pa.us>
2024-06-14 20:20 pgsql: Clean out column-level pg_init_privs entries when dropping table Tom Lane <tgl@sss.pgh.pa.us>
2024-06-14 20:20 pgsql: Clean out column-level pg_init_privs entries when dropping table Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox