pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix MVCC bug with prepared xact with subxacts on standby 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix MVCC bug with prepared xact with subxacts on standby @ 2024-06-27 18:34 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-06-27 18:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix MVCC bug with prepared xact with subxacts on standby We did not recover the subtransaction IDs of prepared transactions when starting a hot standby from a shutdown checkpoint. As a result, such subtransactions were considered as aborted, rather than in-progress. That would lead to hint bits being set incorrectly, and the subtransactions suddenly becoming visible to old snapshots when the prepared transaction was committed. To fix, update pg_subtrans with prepared transactions's subxids when starting hot standby from a shutdown checkpoint. The snapshots taken from that state need to be marked as "suboverflowed", so that we also check the pg_subtrans. Backport to all supported versions. Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9dbf8ab48c21f9a006e578983b21739326d7c621 Modified Files -------------- src/backend/access/transam/twophase.c | 7 +++-- src/backend/access/transam/xlog.c | 14 +++++----- src/backend/storage/ipc/procarray.c | 18 ++++++++++--- src/backend/storage/ipc/standby.c | 6 ++--- src/include/storage/standby.h | 10 +++++++- src/test/recovery/t/009_twophase.pl | 48 ++++++++++++++++++++++++++++++++++- src/tools/pgindent/typedefs.list | 1 + 7 files changed, 86 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix MVCC bug with prepared xact with subxacts on standby @ 2024-06-27 18:34 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-06-27 18:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix MVCC bug with prepared xact with subxacts on standby We did not recover the subtransaction IDs of prepared transactions when starting a hot standby from a shutdown checkpoint. As a result, such subtransactions were considered as aborted, rather than in-progress. That would lead to hint bits being set incorrectly, and the subtransactions suddenly becoming visible to old snapshots when the prepared transaction was committed. To fix, update pg_subtrans with prepared transactions's subxids when starting hot standby from a shutdown checkpoint. The snapshots taken from that state need to be marked as "suboverflowed", so that we also check the pg_subtrans. Backport to all supported versions. Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/cbfbda78413a5b2f4807e029407dcc98a0e63162 Modified Files -------------- src/backend/access/transam/twophase.c | 7 +++--- src/backend/access/transam/xlog.c | 14 ++++++----- src/backend/storage/ipc/procarray.c | 18 +++++++++++--- src/backend/storage/ipc/standby.c | 6 ++--- src/include/storage/standby.h | 10 +++++++- src/test/recovery/t/009_twophase.pl | 46 +++++++++++++++++++++++++++++++++++ src/tools/pgindent/typedefs.list | 1 + 7 files changed, 85 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix MVCC bug with prepared xact with subxacts on standby @ 2024-06-27 18:34 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-06-27 18:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix MVCC bug with prepared xact with subxacts on standby We did not recover the subtransaction IDs of prepared transactions when starting a hot standby from a shutdown checkpoint. As a result, such subtransactions were considered as aborted, rather than in-progress. That would lead to hint bits being set incorrectly, and the subtransactions suddenly becoming visible to old snapshots when the prepared transaction was committed. To fix, update pg_subtrans with prepared transactions's subxids when starting hot standby from a shutdown checkpoint. The snapshots taken from that state need to be marked as "suboverflowed", so that we also check the pg_subtrans. Backport to all supported versions. Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5dea6628b32d8092e789d9e31509ed74840a271e Modified Files -------------- src/backend/access/transam/twophase.c | 7 +++-- src/backend/access/transam/xlog.c | 14 +++++----- src/backend/storage/ipc/procarray.c | 18 ++++++++++--- src/backend/storage/ipc/standby.c | 6 ++--- src/include/storage/standby.h | 10 +++++++- src/test/recovery/t/009_twophase.pl | 48 ++++++++++++++++++++++++++++++++++- src/tools/pgindent/typedefs.list | 1 + 7 files changed, 86 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix MVCC bug with prepared xact with subxacts on standby @ 2024-06-27 18:34 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-06-27 18:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix MVCC bug with prepared xact with subxacts on standby We did not recover the subtransaction IDs of prepared transactions when starting a hot standby from a shutdown checkpoint. As a result, such subtransactions were considered as aborted, rather than in-progress. That would lead to hint bits being set incorrectly, and the subtransactions suddenly becoming visible to old snapshots when the prepared transaction was committed. To fix, update pg_subtrans with prepared transactions's subxids when starting hot standby from a shutdown checkpoint. The snapshots taken from that state need to be marked as "suboverflowed", so that we also check the pg_subtrans. Backport to all supported versions. Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0e2f3d78bf5ab869da0dbefeba629d74d4078655 Modified Files -------------- src/backend/access/transam/twophase.c | 7 +++--- src/backend/access/transam/xlog.c | 14 ++++++----- src/backend/storage/ipc/procarray.c | 18 +++++++++++--- src/backend/storage/ipc/standby.c | 6 ++--- src/include/storage/standby.h | 10 +++++++- src/test/recovery/t/009_twophase.pl | 46 +++++++++++++++++++++++++++++++++++ src/tools/pgindent/typedefs.list | 1 + 7 files changed, 85 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix MVCC bug with prepared xact with subxacts on standby @ 2024-06-27 18:34 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-06-27 18:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix MVCC bug with prepared xact with subxacts on standby We did not recover the subtransaction IDs of prepared transactions when starting a hot standby from a shutdown checkpoint. As a result, such subtransactions were considered as aborted, rather than in-progress. That would lead to hint bits being set incorrectly, and the subtransactions suddenly becoming visible to old snapshots when the prepared transaction was committed. To fix, update pg_subtrans with prepared transactions's subxids when starting hot standby from a shutdown checkpoint. The snapshots taken from that state need to be marked as "suboverflowed", so that we also check the pg_subtrans. Backport to all supported versions. Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e9c8747ee934db9b5bad0b0f5aa3709a41ad0a9c Modified Files -------------- src/backend/access/transam/twophase.c | 7 +++--- src/backend/access/transam/xlog.c | 14 ++++++----- src/backend/storage/ipc/procarray.c | 18 +++++++++++--- src/backend/storage/ipc/standby.c | 6 ++--- src/include/storage/standby.h | 10 +++++++- src/test/recovery/t/009_twophase.pl | 47 ++++++++++++++++++++++++++++++++++- src/tools/pgindent/typedefs.list | 1 + 7 files changed, 85 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix MVCC bug with prepared xact with subxacts on standby @ 2024-06-27 18:34 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-06-27 18:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix MVCC bug with prepared xact with subxacts on standby We did not recover the subtransaction IDs of prepared transactions when starting a hot standby from a shutdown checkpoint. As a result, such subtransactions were considered as aborted, rather than in-progress. That would lead to hint bits being set incorrectly, and the subtransactions suddenly becoming visible to old snapshots when the prepared transaction was committed. To fix, update pg_subtrans with prepared transactions's subxids when starting hot standby from a shutdown checkpoint. The snapshots taken from that state need to be marked as "suboverflowed", so that we also check the pg_subtrans. Backport to all supported versions. Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b5b418b689ec5d3807b0eea34e58166191e18499 Modified Files -------------- src/backend/access/transam/twophase.c | 7 +++--- src/backend/access/transam/xlog.c | 14 ++++++----- src/backend/storage/ipc/procarray.c | 18 +++++++++++--- src/backend/storage/ipc/standby.c | 6 ++--- src/include/storage/standby.h | 10 +++++++- src/test/recovery/t/009_twophase.pl | 46 +++++++++++++++++++++++++++++++++++ src/tools/pgindent/typedefs.list | 1 + 7 files changed, 85 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-06-27 18:34 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-06-27 18:34 pgsql: Fix MVCC bug with prepared xact with subxacts on standby Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-06-27 18:34 pgsql: Fix MVCC bug with prepared xact with subxacts on standby Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-06-27 18:34 pgsql: Fix MVCC bug with prepared xact with subxacts on standby Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-06-27 18:34 pgsql: Fix MVCC bug with prepared xact with subxacts on standby Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-06-27 18:34 pgsql: Fix MVCC bug with prepared xact with subxacts on standby Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-06-27 18:34 pgsql: Fix MVCC bug with prepared xact with subxacts on standby Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox