pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Expand comments and add an assertion in nodeModifyTable.c. 6+ messages / 1 participants [nested] [flat]
* pgsql: Expand comments and add an assertion in nodeModifyTable.c. @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Expand comments and add an assertion in nodeModifyTable.c. Most comments concern RELKIND_VIEW. One addresses the ExecUpdate() "tupleid" parameter. A later commit will rely on these facts, but they hold already. Back-patch to v12 (all supported versions), the plan for that commit. Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d5f788b41dc2cbdde6e7694c70dda54d829a5ed5 Modified Files -------------- src/backend/executor/nodeModifyTable.c | 70 ++++++++++++++++++++-------------- 1 file changed, 41 insertions(+), 29 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Expand comments and add an assertion in nodeModifyTable.c. @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Expand comments and add an assertion in nodeModifyTable.c. Most comments concern RELKIND_VIEW. One addresses the ExecUpdate() "tupleid" parameter. A later commit will rely on these facts, but they hold already. Back-patch to v12 (all supported versions), the plan for that commit. Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f8135d8b54ff68f0788779d86edd796efc330ff4 Modified Files -------------- src/backend/executor/nodeModifyTable.c | 55 ++++++++++++++++++++-------------- 1 file changed, 32 insertions(+), 23 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Expand comments and add an assertion in nodeModifyTable.c. @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Expand comments and add an assertion in nodeModifyTable.c. Most comments concern RELKIND_VIEW. One addresses the ExecUpdate() "tupleid" parameter. A later commit will rely on these facts, but they hold already. Back-patch to v12 (all supported versions), the plan for that commit. Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f0544432c3cc5e74817dac146196dabcf3de6c25 Modified Files -------------- src/backend/executor/nodeModifyTable.c | 55 ++++++++++++++++++++-------------- 1 file changed, 32 insertions(+), 23 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Expand comments and add an assertion in nodeModifyTable.c. @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Expand comments and add an assertion in nodeModifyTable.c. Most comments concern RELKIND_VIEW. One addresses the ExecUpdate() "tupleid" parameter. A later commit will rely on these facts, but they hold already. Back-patch to v12 (all supported versions), the plan for that commit. Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ad4653268c12cd50339dae0de59d9add41138d66 Modified Files -------------- src/backend/executor/nodeModifyTable.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Expand comments and add an assertion in nodeModifyTable.c. @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Expand comments and add an assertion in nodeModifyTable.c. Most comments concern RELKIND_VIEW. One addresses the ExecUpdate() "tupleid" parameter. A later commit will rely on these facts, but they hold already. Back-patch to v12 (all supported versions), the plan for that commit. Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c3437fb7255b1ad7b19c9d6149919b60daa9bb1d Modified Files -------------- src/backend/executor/nodeModifyTable.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Expand comments and add an assertion in nodeModifyTable.c. @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Expand comments and add an assertion in nodeModifyTable.c. Most comments concern RELKIND_VIEW. One addresses the ExecUpdate() "tupleid" parameter. A later commit will rely on these facts, but they hold already. Back-patch to v12 (all supported versions), the plan for that commit. Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fea47de3016ac8bc29bce10382220a457d2ef57f Modified Files -------------- src/backend/executor/nodeModifyTable.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-06-28 02:26 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-06-28 02:26 pgsql: Expand comments and add an assertion in nodeModifyTable.c. Noah Misch <noah@leadboat.com> 2024-06-28 02:26 pgsql: Expand comments and add an assertion in nodeModifyTable.c. Noah Misch <noah@leadboat.com> 2024-06-28 02:26 pgsql: Expand comments and add an assertion in nodeModifyTable.c. Noah Misch <noah@leadboat.com> 2024-06-28 02:26 pgsql: Expand comments and add an assertion in nodeModifyTable.c. Noah Misch <noah@leadboat.com> 2024-06-28 02:26 pgsql: Expand comments and add an assertion in nodeModifyTable.c. Noah Misch <noah@leadboat.com> 2024-06-28 02:26 pgsql: Expand comments and add an assertion in nodeModifyTable.c. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox