pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Cope with inplace update making catcache stale during TOAST fetc 6+ messages / 1 participants [nested] [flat]
* pgsql: Cope with inplace update making catcache stale during TOAST fetc @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Cope with inplace update making catcache stale during TOAST fetch. This extends ad98fb14226ae6456fbaed7990ee7591cbe5efd2 to invals of inplace updates. Trouble requires an inplace update of a catalog having a TOAST table, so only pg_database was at risk. (The other catalog on which core code performs inplace updates, pg_class, has no TOAST table.) Trouble would require something like the inplace-inval.spec test. Consider GRANT ... ON DATABASE fetching a stale row from cache and discarding a datfrozenxid update that vac_truncate_clog() has already relied upon. Back-patch to v12 (all supported versions). Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240114201411.d0@rfd.leadboat.com Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f9f47f0d93d1a493a3365625f96026c7b18d7cf5 Modified Files -------------- src/backend/catalog/catalog.c | 21 ++++++++++++++++++ src/backend/utils/cache/catcache.c | 44 +++++++++++++++++++++++++++++++++++--- src/include/catalog/catalog.h | 2 ++ 3 files changed, 64 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Cope with inplace update making catcache stale during TOAST fetc @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Cope with inplace update making catcache stale during TOAST fetch. This extends ad98fb14226ae6456fbaed7990ee7591cbe5efd2 to invals of inplace updates. Trouble requires an inplace update of a catalog having a TOAST table, so only pg_database was at risk. (The other catalog on which core code performs inplace updates, pg_class, has no TOAST table.) Trouble would require something like the inplace-inval.spec test. Consider GRANT ... ON DATABASE fetching a stale row from cache and discarding a datfrozenxid update that vac_truncate_clog() has already relied upon. Back-patch to v12 (all supported versions). Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240114201411.d0@rfd.leadboat.com Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e4afd7153bd80404bffc4d17b37451d7317ae53e Modified Files -------------- src/backend/catalog/catalog.c | 21 ++++++++++++++++++ src/backend/utils/cache/catcache.c | 44 +++++++++++++++++++++++++++++++++++--- src/include/catalog/catalog.h | 2 ++ 3 files changed, 64 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Cope with inplace update making catcache stale during TOAST fetc @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Cope with inplace update making catcache stale during TOAST fetch. This extends ad98fb14226ae6456fbaed7990ee7591cbe5efd2 to invals of inplace updates. Trouble requires an inplace update of a catalog having a TOAST table, so only pg_database was at risk. (The other catalog on which core code performs inplace updates, pg_class, has no TOAST table.) Trouble would require something like the inplace-inval.spec test. Consider GRANT ... ON DATABASE fetching a stale row from cache and discarding a datfrozenxid update that vac_truncate_clog() has already relied upon. Back-patch to v12 (all supported versions). Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240114201411.d0@rfd.leadboat.com Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b08a4b6163ebb10d0fcfabbccd49eeb23cef70d3 Modified Files -------------- src/backend/catalog/catalog.c | 21 ++++++++++++++++++ src/backend/utils/cache/catcache.c | 44 +++++++++++++++++++++++++++++++++++--- src/include/catalog/catalog.h | 2 ++ 3 files changed, 64 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Cope with inplace update making catcache stale during TOAST fetc @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Cope with inplace update making catcache stale during TOAST fetch. This extends ad98fb14226ae6456fbaed7990ee7591cbe5efd2 to invals of inplace updates. Trouble requires an inplace update of a catalog having a TOAST table, so only pg_database was at risk. (The other catalog on which core code performs inplace updates, pg_class, has no TOAST table.) Trouble would require something like the inplace-inval.spec test. Consider GRANT ... ON DATABASE fetching a stale row from cache and discarding a datfrozenxid update that vac_truncate_clog() has already relied upon. Back-patch to v12 (all supported versions). Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240114201411.d0@rfd.leadboat.com Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/af73e37fa181283a3199cda2233d89c7a669f772 Modified Files -------------- src/backend/catalog/catalog.c | 21 ++++++++++++++++++ src/backend/utils/cache/catcache.c | 44 +++++++++++++++++++++++++++++++++++--- src/include/catalog/catalog.h | 2 ++ 3 files changed, 64 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Cope with inplace update making catcache stale during TOAST fetc @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Cope with inplace update making catcache stale during TOAST fetch. This extends ad98fb14226ae6456fbaed7990ee7591cbe5efd2 to invals of inplace updates. Trouble requires an inplace update of a catalog having a TOAST table, so only pg_database was at risk. (The other catalog on which core code performs inplace updates, pg_class, has no TOAST table.) Trouble would require something like the inplace-inval.spec test. Consider GRANT ... ON DATABASE fetching a stale row from cache and discarding a datfrozenxid update that vac_truncate_clog() has already relied upon. Back-patch to v12 (all supported versions). Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240114201411.d0@rfd.leadboat.com Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7a21306aee0ac55d931e3da618735a75bda67245 Modified Files -------------- src/backend/catalog/catalog.c | 21 ++++++++++++++++++ src/backend/utils/cache/catcache.c | 44 +++++++++++++++++++++++++++++++++++--- src/include/catalog/catalog.h | 2 ++ 3 files changed, 64 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Cope with inplace update making catcache stale during TOAST fetc @ 2024-06-28 02:26 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-06-28 02:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Cope with inplace update making catcache stale during TOAST fetch. This extends ad98fb14226ae6456fbaed7990ee7591cbe5efd2 to invals of inplace updates. Trouble requires an inplace update of a catalog having a TOAST table, so only pg_database was at risk. (The other catalog on which core code performs inplace updates, pg_class, has no TOAST table.) Trouble would require something like the inplace-inval.spec test. Consider GRANT ... ON DATABASE fetching a stale row from cache and discarding a datfrozenxid update that vac_truncate_clog() has already relied upon. Back-patch to v12 (all supported versions). Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240114201411.d0@rfd.leadboat.com Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/11f3815d6af840dc9d557cc680ec477931a6825b Modified Files -------------- src/backend/catalog/catalog.c | 21 ++++++++++++++++++ src/backend/utils/cache/catcache.c | 44 +++++++++++++++++++++++++++++++++++--- src/include/catalog/catalog.h | 2 ++ 3 files changed, 64 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-06-28 02:26 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-06-28 02:26 pgsql: Cope with inplace update making catcache stale during TOAST fetc Noah Misch <noah@leadboat.com> 2024-06-28 02:26 pgsql: Cope with inplace update making catcache stale during TOAST fetc Noah Misch <noah@leadboat.com> 2024-06-28 02:26 pgsql: Cope with inplace update making catcache stale during TOAST fetc Noah Misch <noah@leadboat.com> 2024-06-28 02:26 pgsql: Cope with inplace update making catcache stale during TOAST fetc Noah Misch <noah@leadboat.com> 2024-06-28 02:26 pgsql: Cope with inplace update making catcache stale during TOAST fetc Noah Misch <noah@leadboat.com> 2024-06-28 02:26 pgsql: Cope with inplace update making catcache stale during TOAST fetc Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox