pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix the testcase introduced in commit 81d20fbf7a. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix the testcase introduced in commit 81d20fbf7a. @ 2024-07-03 09:50 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2024-07-03 09:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix the testcase introduced in commit 81d20fbf7a. The failed test was syncing failover replication slot to standby to test that we remove such slots after the standby is converted to subscriber by pg_createsubscriber. In one of the buildfarm members, the sync of the slot failed because the LSN on the standby was before the syncslot's LSN. We need to wait for standby to catch up before trying to sync the slot with pg_sync_replication_slots(). The other buildfarm failed because autovacuum generated a xid which is replicated to the standby at some random point making slots at primary lag behind standby during slot sync. Both these failures wouldn't have occurred if we had used built-in slotsync worker as it would have waited for the standby to sync with primary but for this test, it is sufficient to use pg_sync_replication_slots(). Reported-by: Alexander Lakhin as per buildfarm Author: Kuroda Hayato Reviewed-by: Amit Kapila Backpatch-through: 17 Discussion: https://postgr.es/m/0dffca12-bf17-4a7a-334d-225569de5e6e@gmail.com Discussion: https://postgr.es/m/OSBPR01MB25528300C71FDD83EA1DCA12F5DD2@OSBPR01MB2552.jpnprd01.prod.outlook.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ae395f0f7edbbf8e9ebe92e2ed3a471192789f0c Modified Files -------------- src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 7 +++++++ 1 file changed, 7 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix the testcase introduced in commit 81d20fbf7a. @ 2024-07-03 09:50 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2024-07-03 09:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix the testcase introduced in commit 81d20fbf7a. The failed test was syncing failover replication slot to standby to test that we remove such slots after the standby is converted to subscriber by pg_createsubscriber. In one of the buildfarm members, the sync of the slot failed because the LSN on the standby was before the syncslot's LSN. We need to wait for standby to catch up before trying to sync the slot with pg_sync_replication_slots(). The other buildfarm failed because autovacuum generated a xid which is replicated to the standby at some random point making slots at primary lag behind standby during slot sync. Both these failures wouldn't have occurred if we had used built-in slotsync worker as it would have waited for the standby to sync with primary but for this test, it is sufficient to use pg_sync_replication_slots(). Reported-by: Alexander Lakhin as per buildfarm Author: Kuroda Hayato Reviewed-by: Amit Kapila Backpatch-through: 17 Discussion: https://postgr.es/m/0dffca12-bf17-4a7a-334d-225569de5e6e@gmail.com Discussion: https://postgr.es/m/OSBPR01MB25528300C71FDD83EA1DCA12F5DD2@OSBPR01MB2552.jpnprd01.prod.outlook.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/14387ab0650377a0a349a3d2d57b8cb9d0a067c5 Modified Files -------------- src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 7 +++++++ 1 file changed, 7 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-07-03 09:50 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-07-03 09:50 pgsql: Fix the testcase introduced in commit 81d20fbf7a. Amit Kapila <akapila@postgresql.org> 2024-07-03 09:50 pgsql: Fix the testcase introduced in commit 81d20fbf7a. Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox