pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: SQL/JSON: Fix some obsolete comments. 3+ messages / 1 participants [nested] [flat]
* pgsql: SQL/JSON: Fix some obsolete comments. @ 2024-07-04 07:36 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Langote @ 2024-07-04 07:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org SQL/JSON: Fix some obsolete comments. JSON_OBJECT(), JSON_OBJETAGG(), JSON_ARRAY(), and JSON_ARRAYAGG() added in 7081ac46ace are not transformed into direct calls to user-defined functions as the comments claim. Fix by mentioning instead that they are transformed into JsonConstructorExpr nodes, which may call them, for example, for the *AGG() functions. Reported-by: Alexander Lakhin <exclusion@gmail.com> Discussion: https://postgr.es/m/058c856a-e090-ac42-ff00-ffe394f52a87%40gmail.com Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7768b6569de95de7517bd6520acbe6e599fc6601 Modified Files -------------- src/backend/parser/parse_expr.c | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: SQL/JSON: Fix some obsolete comments. @ 2024-07-04 07:36 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Langote @ 2024-07-04 07:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org SQL/JSON: Fix some obsolete comments. JSON_OBJECT(), JSON_OBJETAGG(), JSON_ARRAY(), and JSON_ARRAYAGG() added in 7081ac46ace are not transformed into direct calls to user-defined functions as the comments claim. Fix by mentioning instead that they are transformed into JsonConstructorExpr nodes, which may call them, for example, for the *AGG() functions. Reported-by: Alexander Lakhin <exclusion@gmail.com> Discussion: https://postgr.es/m/058c856a-e090-ac42-ff00-ffe394f52a87%40gmail.com Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/290a6d800d90d36a4a1d45655c944695102fabd1 Modified Files -------------- src/backend/parser/parse_expr.c | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: SQL/JSON: Fix some obsolete comments. @ 2024-07-04 07:37 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Langote @ 2024-07-04 07:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org SQL/JSON: Fix some obsolete comments. JSON_OBJECT(), JSON_OBJETAGG(), JSON_ARRAY(), and JSON_ARRAYAGG() added in 7081ac46ace are not transformed into direct calls to user-defined functions as the comments claim. Fix by mentioning instead that they are transformed into JsonConstructorExpr nodes, which may call them, for example, for the *AGG() functions. Reported-by: Alexander Lakhin <exclusion@gmail.com> Discussion: https://postgr.es/m/058c856a-e090-ac42-ff00-ffe394f52a87%40gmail.com Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3a8a1f3254b2e3e981a91cb021ea0e9fdb5c3b9c Modified Files -------------- src/backend/parser/parse_expr.c | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-07-04 07:37 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-07-04 07:36 pgsql: SQL/JSON: Fix some obsolete comments. Amit Langote <amitlan@postgresql.org> 2024-07-04 07:36 pgsql: SQL/JSON: Fix some obsolete comments. Amit Langote <amitlan@postgresql.org> 2024-07-04 07:37 pgsql: SQL/JSON: Fix some obsolete comments. Amit Langote <amitlan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox