pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test 5+ messages / 1 participants [nested] [flat]
* pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test @ 2024-07-08 21:36 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 5+ messages in thread From: Andrew Dunstan @ 2024-07-08 21:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Symlink pg_replslot robustly on Windows in pg_basebackup test This reverts commit e9f15bc9. Instead of a hacky solution that didn't work on Windows, we avoid trying to move the directory possibly across drives, and instead remove it and recreate it in the new location. Discussion: https://postgr.es/m/20240707070243.sb77kp4ubowauctz@awork3.anarazel.de Backpatch to release 14 like the previous patch. Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/468b2367d2fe29fe1a53bcba408b472dc8f5051b Modified Files -------------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test @ 2024-07-08 21:36 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 5+ messages in thread From: Andrew Dunstan @ 2024-07-08 21:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Symlink pg_replslot robustly on Windows in pg_basebackup test This reverts commit e9f15bc9. Instead of a hacky solution that didn't work on Windows, we avoid trying to move the directory possibly across drives, and instead remove it and recreate it in the new location. Discussion: https://postgr.es/m/20240707070243.sb77kp4ubowauctz@awork3.anarazel.de Backpatch to release 14 like the previous patch. Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4ac08251eb3db0de3924c788d81a776cc6008edd Modified Files -------------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test @ 2024-07-08 21:36 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 5+ messages in thread From: Andrew Dunstan @ 2024-07-08 21:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Symlink pg_replslot robustly on Windows in pg_basebackup test This reverts commit e9f15bc9. Instead of a hacky solution that didn't work on Windows, we avoid trying to move the directory possibly across drives, and instead remove it and recreate it in the new location. Discussion: https://postgr.es/m/20240707070243.sb77kp4ubowauctz@awork3.anarazel.de Backpatch to release 14 like the previous patch. Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d3e213ae1359f0bcfa9c446166d187811a7db8bc Modified Files -------------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test @ 2024-07-08 21:36 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 5+ messages in thread From: Andrew Dunstan @ 2024-07-08 21:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Symlink pg_replslot robustly on Windows in pg_basebackup test This reverts commit e9f15bc9. Instead of a hacky solution that didn't work on Windows, we avoid trying to move the directory possibly across drives, and instead remove it and recreate it in the new location. Discussion: https://postgr.es/m/20240707070243.sb77kp4ubowauctz@awork3.anarazel.de Backpatch to release 14 like the previous patch. Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4b719e15beed7ceb49d0bd4047aa08001c7fbcf6 Modified Files -------------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test @ 2024-07-08 21:36 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 5+ messages in thread From: Andrew Dunstan @ 2024-07-08 21:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Symlink pg_replslot robustly on Windows in pg_basebackup test This reverts commit e9f15bc9. Instead of a hacky solution that didn't work on Windows, we avoid trying to move the directory possibly across drives, and instead remove it and recreate it in the new location. Discussion: https://postgr.es/m/20240707070243.sb77kp4ubowauctz@awork3.anarazel.de Backpatch to release 14 like the previous patch. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5193ca8e155ac0140d20361bdafa27744c016252 Modified Files -------------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2024-07-08 21:36 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-07-08 21:36 pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test Andrew Dunstan <andrew@dunslane.net> 2024-07-08 21:36 pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test Andrew Dunstan <andrew@dunslane.net> 2024-07-08 21:36 pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test Andrew Dunstan <andrew@dunslane.net> 2024-07-08 21:36 pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test Andrew Dunstan <andrew@dunslane.net> 2024-07-08 21:36 pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test Andrew Dunstan <andrew@dunslane.net>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox