pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix unstable test in 040_pg_createsubscriber. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix unstable test in 040_pg_createsubscriber. @ 2024-07-12 04:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2024-07-12 04:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix unstable test in 040_pg_createsubscriber. The slot synchronization failed because the local slot's (created during slot synchronization) catalog_xmin on standby is ahead of remote slot. This happens because the INSERT before slot synchronization results in the generation of a new xid that could be replicated to the standby. Now before the xmin of the physical slot on the primary catches up via hot_standby_feedback, the test has created a logical slot that got some prior value of catalog_xmin. To fix this we could try to ensure that the physical slot's catalog_xmin is caught up to latest value before creating a logical slot but we took a simpler path to move the INSERT after synchronizing the logical slot. Reported-by: Alexander Lakhin as per buildfarm Diagnosed-by: Amit Kapila, Hou Zhijie, Alexander Lakhin Author: Hou Zhijie Backpatch-through: 17 Discussion: https://postgr.es/m/bde6ac67-69cc-c104-5ab6-dd4f5deadf24@gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9fd8b331dfe151b7c833e2c8fa17ce753830b891 Modified Files -------------- src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix unstable test in 040_pg_createsubscriber. @ 2024-07-12 04:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2024-07-12 04:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix unstable test in 040_pg_createsubscriber. The slot synchronization failed because the local slot's (created during slot synchronization) catalog_xmin on standby is ahead of remote slot. This happens because the INSERT before slot synchronization results in the generation of a new xid that could be replicated to the standby. Now before the xmin of the physical slot on the primary catches up via hot_standby_feedback, the test has created a logical slot that got some prior value of catalog_xmin. To fix this we could try to ensure that the physical slot's catalog_xmin is caught up to latest value before creating a logical slot but we took a simpler path to move the INSERT after synchronizing the logical slot. Reported-by: Alexander Lakhin as per buildfarm Diagnosed-by: Amit Kapila, Hou Zhijie, Alexander Lakhin Author: Hou Zhijie Backpatch-through: 17 Discussion: https://postgr.es/m/bde6ac67-69cc-c104-5ab6-dd4f5deadf24@gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ae4e072bad5ff254a4fcfe876aae849acdaf8c3d Modified Files -------------- src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-07-12 04:34 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-07-12 04:34 pgsql: Fix unstable test in 040_pg_createsubscriber. Amit Kapila <akapila@postgresql.org> 2024-07-12 04:34 pgsql: Fix unstable test in 040_pg_createsubscriber. Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox