pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix new assertion for MERGE view_name ... DO NOTHING. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix new assertion for MERGE view_name ... DO NOTHING. @ 2024-07-13 15:11 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 2+ messages in thread From: Noah Misch @ 2024-07-13 15:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix new assertion for MERGE view_name ... DO NOTHING. Such queries don't expand automatically updatable views, and ModifyTable uses the wholerow attribute unconditionally. The user-visible behavior is fine, so change to more-specific assertions. Commit d5f788b41dc2cbdde6e7694c70dda54d829a5ed5 added the wrong assertion. Back-patch to v17, where commit 5f2e179bd31e5f5803005101eb12a8d7bf8db8f3 introduced MERGE view_name. Reported by Alexander Lakhin. Discussion: https://postgr.es/m/e4b40a88-c134-6926-3196-bc4501cb87a2@gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0d3b35c367c21fcfe437b689919bf153f85e2e25 Modified Files -------------- src/backend/executor/nodeModifyTable.c | 40 +++++++++++++++------------ src/test/regress/expected/updatable_views.out | 5 ++++ src/test/regress/sql/updatable_views.sql | 5 ++++ 3 files changed, 33 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix new assertion for MERGE view_name ... DO NOTHING. @ 2024-07-13 15:11 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 2+ messages in thread From: Noah Misch @ 2024-07-13 15:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix new assertion for MERGE view_name ... DO NOTHING. Such queries don't expand automatically updatable views, and ModifyTable uses the wholerow attribute unconditionally. The user-visible behavior is fine, so change to more-specific assertions. Commit d5f788b41dc2cbdde6e7694c70dda54d829a5ed5 added the wrong assertion. Back-patch to v17, where commit 5f2e179bd31e5f5803005101eb12a8d7bf8db8f3 introduced MERGE view_name. Reported by Alexander Lakhin. Discussion: https://postgr.es/m/e4b40a88-c134-6926-3196-bc4501cb87a2@gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d5e6891502ca9e359aa5f5a381d904fe9d606338 Modified Files -------------- src/backend/executor/nodeModifyTable.c | 40 +++++++++++++++------------ src/test/regress/expected/updatable_views.out | 5 ++++ src/test/regress/sql/updatable_views.sql | 5 ++++ 3 files changed, 33 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-07-13 15:11 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-07-13 15:11 pgsql: Fix new assertion for MERGE view_name ... DO NOTHING. Noah Misch <noah@leadboat.com> 2024-07-13 15:11 pgsql: Fix new assertion for MERGE view_name ... DO NOTHING. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox