pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Doc: improve description of plpgsql's RAISE command. 8+ messages / 1 participants [nested] [flat]
* pgsql: Doc: improve description of plpgsql's RAISE command. @ 2024-07-18 16:38 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 8+ messages in thread From: Tom Lane @ 2024-07-18 16:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: improve description of plpgsql's RAISE command. RAISE accepts either = or := in the USING clause, so fix the syntax synopsis to show that. Rearrange and wordsmith the descriptions of the different syntax variants, in hopes of improving clarity. Igor Gnatyuk, reviewed by Jian He and Laurenz Albe; minor additional wordsmithing by me Discussion: https://postgr.es/m/CAEu6iLvhF5sdGeat2x4_L0FvWW_SiN--ma8ya7CZd-oJoV+yqQ@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/56c6be57af6bd1c7eb7dff50e5f169ced4ed3045 Modified Files -------------- doc/src/sgml/plpgsql.sgml | 58 ++++++++++++++++++++++++++++------------------- 1 file changed, 35 insertions(+), 23 deletions(-) ^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. @ 2024-07-22 23:44 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 8+ messages in thread From: Tom Lane @ 2024-07-22 23:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: improve description of plpgsql's FETCH and MOVE commands. We were not being clear about which variants of the "direction" clause are permitted in MOVE. Also, the text seemed to be written with only the FETCH/MOVE NEXT case in mind, so it didn't apply very well to other variants. Also, document that "MOVE count IN cursor" only works if count is a constant. This is not the whole truth, because some other cases such as a parenthesized expression will also work, but we want to push people to use "MOVE FORWARD count" instead. The constant case is enough to cover what we allow in plain SQL, and that seems sufficient to claim support for. Update a comment in pl_gram.y claiming that we don't document that point. Per gripe from Philipp Salvisberg. Discussion: https://postgr.es/m/172155553388.702.7932496598218792085@wrigleys.postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d2cba4f2cbfe69b2c5f93f364da4e574e075cb03 Modified Files -------------- doc/src/sgml/plpgsql.sgml | 29 +++++++++++++++++++++++------ src/pl/plpgsql/src/pl_gram.y | 10 +++++----- 2 files changed, 28 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. @ 2024-07-22 23:44 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 8+ messages in thread From: Tom Lane @ 2024-07-22 23:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: improve description of plpgsql's FETCH and MOVE commands. We were not being clear about which variants of the "direction" clause are permitted in MOVE. Also, the text seemed to be written with only the FETCH/MOVE NEXT case in mind, so it didn't apply very well to other variants. Also, document that "MOVE count IN cursor" only works if count is a constant. This is not the whole truth, because some other cases such as a parenthesized expression will also work, but we want to push people to use "MOVE FORWARD count" instead. The constant case is enough to cover what we allow in plain SQL, and that seems sufficient to claim support for. Update a comment in pl_gram.y claiming that we don't document that point. Per gripe from Philipp Salvisberg. Discussion: https://postgr.es/m/172155553388.702.7932496598218792085@wrigleys.postgresql.org Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/db46016304dc1f9ea402eee6d392f704050467df Modified Files -------------- doc/src/sgml/plpgsql.sgml | 29 +++++++++++++++++++++++------ src/pl/plpgsql/src/pl_gram.y | 10 +++++----- 2 files changed, 28 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. @ 2024-07-22 23:44 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 8+ messages in thread From: Tom Lane @ 2024-07-22 23:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: improve description of plpgsql's FETCH and MOVE commands. We were not being clear about which variants of the "direction" clause are permitted in MOVE. Also, the text seemed to be written with only the FETCH/MOVE NEXT case in mind, so it didn't apply very well to other variants. Also, document that "MOVE count IN cursor" only works if count is a constant. This is not the whole truth, because some other cases such as a parenthesized expression will also work, but we want to push people to use "MOVE FORWARD count" instead. The constant case is enough to cover what we allow in plain SQL, and that seems sufficient to claim support for. Update a comment in pl_gram.y claiming that we don't document that point. Per gripe from Philipp Salvisberg. Discussion: https://postgr.es/m/172155553388.702.7932496598218792085@wrigleys.postgresql.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/74e15462848de9cc9c302a8f6e12c3b04288b6a1 Modified Files -------------- doc/src/sgml/plpgsql.sgml | 29 +++++++++++++++++++++++------ src/pl/plpgsql/src/pl_gram.y | 10 +++++----- 2 files changed, 28 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. @ 2024-07-22 23:44 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 8+ messages in thread From: Tom Lane @ 2024-07-22 23:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: improve description of plpgsql's FETCH and MOVE commands. We were not being clear about which variants of the "direction" clause are permitted in MOVE. Also, the text seemed to be written with only the FETCH/MOVE NEXT case in mind, so it didn't apply very well to other variants. Also, document that "MOVE count IN cursor" only works if count is a constant. This is not the whole truth, because some other cases such as a parenthesized expression will also work, but we want to push people to use "MOVE FORWARD count" instead. The constant case is enough to cover what we allow in plain SQL, and that seems sufficient to claim support for. Update a comment in pl_gram.y claiming that we don't document that point. Per gripe from Philipp Salvisberg. Discussion: https://postgr.es/m/172155553388.702.7932496598218792085@wrigleys.postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9aa644f92959eca29680595e725a6e71b273f08d Modified Files -------------- doc/src/sgml/plpgsql.sgml | 29 +++++++++++++++++++++++------ src/pl/plpgsql/src/pl_gram.y | 10 +++++----- 2 files changed, 28 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. @ 2024-07-22 23:44 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 8+ messages in thread From: Tom Lane @ 2024-07-22 23:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: improve description of plpgsql's FETCH and MOVE commands. We were not being clear about which variants of the "direction" clause are permitted in MOVE. Also, the text seemed to be written with only the FETCH/MOVE NEXT case in mind, so it didn't apply very well to other variants. Also, document that "MOVE count IN cursor" only works if count is a constant. This is not the whole truth, because some other cases such as a parenthesized expression will also work, but we want to push people to use "MOVE FORWARD count" instead. The constant case is enough to cover what we allow in plain SQL, and that seems sufficient to claim support for. Update a comment in pl_gram.y claiming that we don't document that point. Per gripe from Philipp Salvisberg. Discussion: https://postgr.es/m/172155553388.702.7932496598218792085@wrigleys.postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/30281db50108468a18e0a8ad5eb83e5367472f2b Modified Files -------------- doc/src/sgml/plpgsql.sgml | 29 +++++++++++++++++++++++------ src/pl/plpgsql/src/pl_gram.y | 10 +++++----- 2 files changed, 28 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. @ 2024-07-22 23:44 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 8+ messages in thread From: Tom Lane @ 2024-07-22 23:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: improve description of plpgsql's FETCH and MOVE commands. We were not being clear about which variants of the "direction" clause are permitted in MOVE. Also, the text seemed to be written with only the FETCH/MOVE NEXT case in mind, so it didn't apply very well to other variants. Also, document that "MOVE count IN cursor" only works if count is a constant. This is not the whole truth, because some other cases such as a parenthesized expression will also work, but we want to push people to use "MOVE FORWARD count" instead. The constant case is enough to cover what we allow in plain SQL, and that seems sufficient to claim support for. Update a comment in pl_gram.y claiming that we don't document that point. Per gripe from Philipp Salvisberg. Discussion: https://postgr.es/m/172155553388.702.7932496598218792085@wrigleys.postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/78ff6e0fab3fa2a7064ef8aadaa9e7f87ed5f4a6 Modified Files -------------- doc/src/sgml/plpgsql.sgml | 29 +++++++++++++++++++++++------ src/pl/plpgsql/src/pl_gram.y | 10 +++++----- 2 files changed, 28 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. @ 2024-07-22 23:44 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 8+ messages in thread From: Tom Lane @ 2024-07-22 23:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: improve description of plpgsql's FETCH and MOVE commands. We were not being clear about which variants of the "direction" clause are permitted in MOVE. Also, the text seemed to be written with only the FETCH/MOVE NEXT case in mind, so it didn't apply very well to other variants. Also, document that "MOVE count IN cursor" only works if count is a constant. This is not the whole truth, because some other cases such as a parenthesized expression will also work, but we want to push people to use "MOVE FORWARD count" instead. The constant case is enough to cover what we allow in plain SQL, and that seems sufficient to claim support for. Update a comment in pl_gram.y claiming that we don't document that point. Per gripe from Philipp Salvisberg. Discussion: https://postgr.es/m/172155553388.702.7932496598218792085@wrigleys.postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/77b116724c7545fb610e0f7287d3fbff35ffea22 Modified Files -------------- doc/src/sgml/plpgsql.sgml | 29 +++++++++++++++++++++++------ src/pl/plpgsql/src/pl_gram.y | 10 +++++----- 2 files changed, 28 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2024-07-22 23:44 UTC | newest] Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-07-18 16:38 pgsql: Doc: improve description of plpgsql's RAISE command. Tom Lane <tgl@sss.pgh.pa.us> 2024-07-22 23:44 pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. Tom Lane <tgl@sss.pgh.pa.us> 2024-07-22 23:44 pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. Tom Lane <tgl@sss.pgh.pa.us> 2024-07-22 23:44 pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. Tom Lane <tgl@sss.pgh.pa.us> 2024-07-22 23:44 pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. Tom Lane <tgl@sss.pgh.pa.us> 2024-07-22 23:44 pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. Tom Lane <tgl@sss.pgh.pa.us> 2024-07-22 23:44 pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. Tom Lane <tgl@sss.pgh.pa.us> 2024-07-22 23:44 pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox