pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Use more consistently int64 for page numbers in SLRU-related cod 2+ messages / 1 participants [nested] [flat]
* pgsql: Use more consistently int64 for page numbers in SLRU-related cod @ 2024-07-23 09:00 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2024-07-23 09:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use more consistently int64 for page numbers in SLRU-related code clog.c, async.c and predicate.c included some SLRU page numbers still handled as 4-byte integers, while int64 should be used for this purpose. These holes have been introduced in 4ed8f0913bfd, that has introduced the use of 8-byte integers for SLRU page numbers, still forgot about the code paths updated by this commit. Reported-by: Noah Misch Author: Aleksander Alekseev, Michael Paquier Discussion: https://postgr.es/m/20240626002747.dc.nmisch@google.com Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3937cadfd4383fd32f3fd8d8dc5efc32b3d12664 Modified Files -------------- src/backend/access/transam/clog.c | 4 ++-- src/backend/commands/async.c | 22 +++++++++++----------- src/backend/storage/lmgr/predicate.c | 6 +++--- 3 files changed, 16 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Use more consistently int64 for page numbers in SLRU-related cod @ 2024-07-23 09:00 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2024-07-23 09:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use more consistently int64 for page numbers in SLRU-related code clog.c, async.c and predicate.c included some SLRU page numbers still handled as 4-byte integers, while int64 should be used for this purpose. These holes have been introduced in 4ed8f0913bfd, that has introduced the use of 8-byte integers for SLRU page numbers, still forgot about the code paths updated by this commit. Reported-by: Noah Misch Author: Aleksander Alekseev, Michael Paquier Discussion: https://postgr.es/m/20240626002747.dc.nmisch@google.com Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/165ea79a60774a0e287bfc5dc07363194c6d58df Modified Files -------------- src/backend/access/transam/clog.c | 4 ++-- src/backend/commands/async.c | 22 +++++++++++----------- src/backend/storage/lmgr/predicate.c | 6 +++--- 3 files changed, 16 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-07-23 09:00 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-07-23 09:00 pgsql: Use more consistently int64 for page numbers in SLRU-related cod Michael Paquier <michael@paquier.xyz> 2024-07-23 09:00 pgsql: Use more consistently int64 for page numbers in SLRU-related cod Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox