pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix fallback behavior when server sends an ERROR early at startu
2+ messages / 1 participants
[nested] [flat]
* pgsql: Fix fallback behavior when server sends an ERROR early at startu
@ 2024-07-26 12:38 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Linnakangas @ 2024-07-26 12:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix fallback behavior when server sends an ERROR early at startup
With sslmode=prefer, the desired behavior is to completely fail the
connection attempt, *not* fall back to a plaintext connection, if the
server responds to the SSLRequest with an error ('E') response instead
of rejecting SSL with an 'N' response. This was broken in commit
05fd30c0e7.
Reported-by: Jacob Champion
Reviewed-by: Michael Paquier
Discussion: https://www.postgresql.org/message-id/CAOYmi%2Bnwvu21mJ4DYKUa98HdfM_KZJi7B1MhyXtnsyOO-PB6Ww%40mail.g...
Backpatch-through: 17
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c95d2159c1dd3f269383a9bd830e1c804dba34c8
Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix fallback behavior when server sends an ERROR early at startu
@ 2024-07-26 12:38 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Linnakangas @ 2024-07-26 12:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix fallback behavior when server sends an ERROR early at startup
With sslmode=prefer, the desired behavior is to completely fail the
connection attempt, *not* fall back to a plaintext connection, if the
server responds to the SSLRequest with an error ('E') response instead
of rejecting SSL with an 'N' response. This was broken in commit
05fd30c0e7.
Reported-by: Jacob Champion
Reviewed-by: Michael Paquier
Discussion: https://www.postgresql.org/message-id/CAOYmi%2Bnwvu21mJ4DYKUa98HdfM_KZJi7B1MhyXtnsyOO-PB6Ww%40mail.g...
Backpatch-through: 17
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f06a632a77ed27aab087d62bd76bc52be3a2ac6f
Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-07-26 12:38 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-07-26 12:38 pgsql: Fix fallback behavior when server sends an ERROR early at startu Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-07-26 12:38 pgsql: Fix fallback behavior when server sends an ERROR early at startu Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox