pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix using injection points at backend startup in EXEC_BACKEND mo 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix using injection points at backend startup in EXEC_BACKEND mo @ 2024-07-26 12:38 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 2+ messages in thread From: Heikki Linnakangas @ 2024-07-26 12:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix using injection points at backend startup in EXEC_BACKEND mode Commit 86db52a506 changed the locking of injection points to use only atomic ops and spinlocks, to make it possible to define injection points in processes that don't have a PGPROC entry (yet). However, it didn't work in EXEC_BACKEND mode, because the pointer to shared memory area was not initialized until the process "attaches" to all the shared memory structs. To fix, pass the pointer to the child process along with other global variables that need to be set up early. Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b9e5249c29354186576d8fc00609fe7eaf7c8d25 Modified Files -------------- src/backend/postmaster/launch_backend.c | 12 ++++++++++++ src/backend/utils/misc/injection_point.c | 2 +- src/include/utils/injection_point.h | 4 ++++ 3 files changed, 17 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix using injection points at backend startup in EXEC_BACKEND mo @ 2024-07-26 12:38 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 2+ messages in thread From: Heikki Linnakangas @ 2024-07-26 12:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix using injection points at backend startup in EXEC_BACKEND mode Commit 86db52a506 changed the locking of injection points to use only atomic ops and spinlocks, to make it possible to define injection points in processes that don't have a PGPROC entry (yet). However, it didn't work in EXEC_BACKEND mode, because the pointer to shared memory area was not initialized until the process "attaches" to all the shared memory structs. To fix, pass the pointer to the child process along with other global variables that need to be set up early. Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f19beba3e3acfd804d678af3f768bee069038486 Modified Files -------------- src/backend/postmaster/launch_backend.c | 12 ++++++++++++ src/backend/utils/misc/injection_point.c | 2 +- src/include/utils/injection_point.h | 4 ++++ 3 files changed, 17 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-07-26 12:38 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-07-26 12:38 pgsql: Fix using injection points at backend startup in EXEC_BACKEND mo Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-07-26 12:38 pgsql: Fix using injection points at backend startup in EXEC_BACKEND mo Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox