pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Support absolute bindir/libdir in regression tests with meson
3+ messages / 1 participants
[nested] [flat]
* pgsql: Support absolute bindir/libdir in regression tests with meson
@ 2024-07-27 11:17 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 3+ messages in thread
From: Heikki Linnakangas @ 2024-07-27 11:17 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Support absolute bindir/libdir in regression tests with meson
Passing an absolute bindir/libdir will install the binaries and
libraries to <build>/tmp_install/<bindir> and
<build>/tmp_install/<libdir> respectively.
This path is correctly passed to the regression test suite via
configure/make, but not via meson, yet. This is because the "/"
operator in the following expression throws away the whole left side
when the right side is an absolute path:
test_install_location / get_option('libdir')
This was already correctly handled for dir_prefix, which is likely
absolute as well. This patch handles both bindir and libdir in the
same way - prefixing absolute paths with the tmp_install path
correctly.
Author: Wolfgang Walther
Reviewed-by: Nazir Bilal Yavuz, Alvaro Herrera, Peter Eisentraut
Reviewed-by: Tristan Partin
Discussion: https://www.postgresql.org/message-id/ca8f37e1-a2c3-40e2-91f6-59c3d3652ad4@technowledgy.de
Backpatch: 16-, where meson support was added
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ff34ae368bdb11f9f66e22a4d79e2a179b3a6f0e
Modified Files
--------------
meson.build | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Support absolute bindir/libdir in regression tests with meson
@ 2024-07-27 11:17 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 3+ messages in thread
From: Heikki Linnakangas @ 2024-07-27 11:17 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Support absolute bindir/libdir in regression tests with meson
Passing an absolute bindir/libdir will install the binaries and
libraries to <build>/tmp_install/<bindir> and
<build>/tmp_install/<libdir> respectively.
This path is correctly passed to the regression test suite via
configure/make, but not via meson, yet. This is because the "/"
operator in the following expression throws away the whole left side
when the right side is an absolute path:
test_install_location / get_option('libdir')
This was already correctly handled for dir_prefix, which is likely
absolute as well. This patch handles both bindir and libdir in the
same way - prefixing absolute paths with the tmp_install path
correctly.
Author: Wolfgang Walther
Reviewed-by: Nazir Bilal Yavuz, Alvaro Herrera, Peter Eisentraut
Reviewed-by: Tristan Partin
Discussion: https://www.postgresql.org/message-id/ca8f37e1-a2c3-40e2-91f6-59c3d3652ad4@technowledgy.de
Backpatch: 16-, where meson support was added
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/7f61882b638a7c4caa88137d964d04052829dd38
Modified Files
--------------
meson.build | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Support absolute bindir/libdir in regression tests with meson
@ 2024-07-27 11:17 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 3+ messages in thread
From: Heikki Linnakangas @ 2024-07-27 11:17 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Support absolute bindir/libdir in regression tests with meson
Passing an absolute bindir/libdir will install the binaries and
libraries to <build>/tmp_install/<bindir> and
<build>/tmp_install/<libdir> respectively.
This path is correctly passed to the regression test suite via
configure/make, but not via meson, yet. This is because the "/"
operator in the following expression throws away the whole left side
when the right side is an absolute path:
test_install_location / get_option('libdir')
This was already correctly handled for dir_prefix, which is likely
absolute as well. This patch handles both bindir and libdir in the
same way - prefixing absolute paths with the tmp_install path
correctly.
Author: Wolfgang Walther
Reviewed-by: Nazir Bilal Yavuz, Alvaro Herrera, Peter Eisentraut
Reviewed-by: Tristan Partin
Discussion: https://www.postgresql.org/message-id/ca8f37e1-a2c3-40e2-91f6-59c3d3652ad4@technowledgy.de
Backpatch: 16-, where meson support was added
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/eb6765d57cfabc63bdb02375ec2e788783b88a0f
Modified Files
--------------
meson.build | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-07-27 11:17 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-07-27 11:17 pgsql: Support absolute bindir/libdir in regression tests with meson Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-07-27 11:17 pgsql: Support absolute bindir/libdir in regression tests with meson Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-07-27 11:17 pgsql: Support absolute bindir/libdir in regression tests with meson Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox