pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_createsubscriber: Fix an unpredictable recovery wait time. 2+ messages / 1 participants [nested] [flat]
* pgsql: pg_createsubscriber: Fix an unpredictable recovery wait time. @ 2024-07-30 09:01 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2024-07-30 09:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_createsubscriber: Fix an unpredictable recovery wait time. The problem is that the tool is using the LSN returned by pg_create_logical_replication_slot() as recovery_target_lsn. This LSN is ahead of the current WAL position and the recovery waits until the publisher writes a WAL record to reach the target and ends the recovery. On idle systems, this wait time is unpredictable and could lead to failure in promoting the subscriber. To avoid that, insert a harmless WAL record. Reported-by: Alexander Lakhin and Tom Lane Diagnosed-by: Hayato Kuroda Author: Euler Taveira Reviewed-by: Hayato Kuroda, Amit Kapila Backpatch-through: 17 Discussion: https://postgr.es/m/2377319.1719766794%40sss.pgh.pa.us Discussion: https://postgr.es/m/CA+TgmoYcY+Wb67NAwaHT7MvxCSeV86oSc+va9hHKaasE42ukyw@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/03b08c8f5f3e30c97e5908f3d3d76872dab8a9dc Modified Files -------------- src/bin/pg_basebackup/pg_createsubscriber.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: pg_createsubscriber: Fix an unpredictable recovery wait time. @ 2024-07-30 09:01 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2024-07-30 09:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_createsubscriber: Fix an unpredictable recovery wait time. The problem is that the tool is using the LSN returned by pg_create_logical_replication_slot() as recovery_target_lsn. This LSN is ahead of the current WAL position and the recovery waits until the publisher writes a WAL record to reach the target and ends the recovery. On idle systems, this wait time is unpredictable and could lead to failure in promoting the subscriber. To avoid that, insert a harmless WAL record. Reported-by: Alexander Lakhin and Tom Lane Diagnosed-by: Hayato Kuroda Author: Euler Taveira Reviewed-by: Hayato Kuroda, Amit Kapila Backpatch-through: 17 Discussion: https://postgr.es/m/2377319.1719766794%40sss.pgh.pa.us Discussion: https://postgr.es/m/CA+TgmoYcY+Wb67NAwaHT7MvxCSeV86oSc+va9hHKaasE42ukyw@mail.gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e5ba6a5ab62ce05e2a762b4d26f0fd0c52c7b521 Modified Files -------------- src/bin/pg_basebackup/pg_createsubscriber.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-07-30 09:01 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-07-30 09:01 pgsql: pg_createsubscriber: Fix an unpredictable recovery wait time. Amit Kapila <akapila@postgresql.org> 2024-07-30 09:01 pgsql: pg_createsubscriber: Fix an unpredictable recovery wait time. Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox