pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Skip citext_utf8 test on Windows. 3+ messages / 1 participants [nested] [flat]
* pgsql: Skip citext_utf8 test on Windows. @ 2024-05-12 19:59 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Thomas Munro @ 2024-05-12 19:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Skip citext_utf8 test on Windows. On other Windows build farm animals it is already skipped because they don't use UTF-8 encoding. On "hamerkop", UTF-8 is used, and then the test fails. It is not clear to me (a non-Windows person looking only at buildfarm evidence) whether Windows is less sophisticated than other OSes and doesn't know how to downcase Turkish İ with the standard Unicode database, or if it is more sophisticated than other systems and uses locale-specific behavior like ICU does. Whichever the reason, the result is the same: we need to skip the test on Windows, just as we already do for ICU, at least until a Windows-savvy developer comes up with a better idea. The technique for detecting the OS is borrowed from collate.windows.win1252.sql. This was anticipated by commit c2e8bd27, but the problem only surfaced when Windows build farm animals started using Meson. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CA%2BhUKGJ1LeC3aE2qQYTK95rFVON3ZVoTQpTKJqxkHdtEyawH4A%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/cff4e5a36bfe1191a688c5eaff7ba095588ba732 Modified Files -------------- contrib/citext/expected/citext_utf8.out | 3 +++ contrib/citext/expected/citext_utf8_1.out | 3 +++ contrib/citext/sql/citext_utf8.sql | 3 +++ 3 files changed, 9 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Skip citext_utf8 test on Windows. @ 2024-08-01 22:51 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Thomas Munro @ 2024-08-01 22:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Skip citext_utf8 test on Windows. Back-patch of commit cff4e5a3 to 15 and 16, per request from Oleg Tselebrovskiy. Original commit message: On other Windows build farm animals it is already skipped because they don't use UTF-8 encoding. On "hamerkop", UTF-8 is used, and then the test fails. It is not clear to me (a non-Windows person looking only at buildfarm evidence) whether Windows is less sophisticated than other OSes and doesn't know how to downcase Turkish İ with the standard Unicode database, or if it is more sophisticated than other systems and uses locale-specific behavior like ICU does. Whichever the reason, the result is the same: we need to skip the test on Windows, just as we already do for ICU, at least until a Windows-savvy developer comes up with a better idea. The technique for detecting the OS is borrowed from collate.windows.win1252.sql. This was anticipated by commit c2e8bd27, but the problem only surfaced when Windows build farm animals started using Meson. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CA%2BhUKGJ1LeC3aE2qQYTK95rFVON3ZVoTQpTKJqxkHdtEyawH4A%40mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/91f498fdec14888d58190021fc125ec468d3047b Modified Files -------------- contrib/citext/expected/citext_utf8.out | 3 +++ contrib/citext/expected/citext_utf8_1.out | 3 +++ contrib/citext/sql/citext_utf8.sql | 3 +++ 3 files changed, 9 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Skip citext_utf8 test on Windows. @ 2024-08-01 22:51 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Thomas Munro @ 2024-08-01 22:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Skip citext_utf8 test on Windows. Back-patch of commit cff4e5a3 to 15 and 16, per request from Oleg Tselebrovskiy. Original commit message: On other Windows build farm animals it is already skipped because they don't use UTF-8 encoding. On "hamerkop", UTF-8 is used, and then the test fails. It is not clear to me (a non-Windows person looking only at buildfarm evidence) whether Windows is less sophisticated than other OSes and doesn't know how to downcase Turkish İ with the standard Unicode database, or if it is more sophisticated than other systems and uses locale-specific behavior like ICU does. Whichever the reason, the result is the same: we need to skip the test on Windows, just as we already do for ICU, at least until a Windows-savvy developer comes up with a better idea. The technique for detecting the OS is borrowed from collate.windows.win1252.sql. This was anticipated by commit c2e8bd27, but the problem only surfaced when Windows build farm animals started using Meson. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CA%2BhUKGJ1LeC3aE2qQYTK95rFVON3ZVoTQpTKJqxkHdtEyawH4A%40mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e52a44b8a4c11bc10685162e8e638357c01b9dc4 Modified Files -------------- contrib/citext/expected/citext_utf8.out | 1 + contrib/citext/expected/citext_utf8_1.out | 1 + contrib/citext/sql/citext_utf8.sql | 1 + 3 files changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-08-01 22:51 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-05-12 19:59 pgsql: Skip citext_utf8 test on Windows. Thomas Munro <tmunro@postgresql.org> 2024-08-01 22:51 pgsql: Skip citext_utf8 test on Windows. Thomas Munro <tmunro@postgresql.org> 2024-08-01 22:51 pgsql: Skip citext_utf8 test on Windows. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox