pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Revert ECPG's use of pnstrdup()
6+ messages / 1 participants
[nested] [flat]

* pgsql: Revert ECPG's use of pnstrdup()
@ 2024-08-07 07:28  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Eisentraut @ 2024-08-07 07:28 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert ECPG's use of pnstrdup()

Commit 0b9466fce added a dependency on fe_memutils' pnstrdup() inside
informix.c.  This adds an exit() path in a library, which we don't
want.  (Unlike libpq, the ecpg libraries don't have an automated check
for that, but it makes sense to keep them to a similar standard.)  The
ecpg code can already handle failure results from the *strdup() call
by itself.

Author: Jacob Champion <jacob.champion@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/CAOYmi+=pg=W5L1h=3MEP_EB24jaBu2FyATrLXqQHGe7cpuvwyg@mail.gmail...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5388216f6adc7eac20f32db33cc5ce54ef0cc930

Modified Files
--------------
src/interfaces/ecpg/compatlib/informix.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert ECPG's use of pnstrdup()
@ 2024-08-08 06:07  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Eisentraut @ 2024-08-08 06:07 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert ECPG's use of pnstrdup()

Commit 0b9466fce added a dependency on fe_memutils' pnstrdup() inside
informix.c.  This adds an exit() path in a library, which we don't
want.  (Unlike libpq, the ecpg libraries don't have an automated check
for that, but it makes sense to keep them to a similar standard.)  The
ecpg code can already handle failure results from the *strdup() call
by itself.

Author: Jacob Champion <jacob.champion@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/CAOYmi+=pg=W5L1h=3MEP_EB24jaBu2FyATrLXqQHGe7cpuvwyg@mail.gmail...

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2de129b356bfde9a02269c174396add065ace260

Modified Files
--------------
src/interfaces/ecpg/compatlib/informix.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert ECPG's use of pnstrdup()
@ 2024-08-08 06:07  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Eisentraut @ 2024-08-08 06:07 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert ECPG's use of pnstrdup()

Commit 0b9466fce added a dependency on fe_memutils' pnstrdup() inside
informix.c.  This adds an exit() path in a library, which we don't
want.  (Unlike libpq, the ecpg libraries don't have an automated check
for that, but it makes sense to keep them to a similar standard.)  The
ecpg code can already handle failure results from the *strdup() call
by itself.

Author: Jacob Champion <jacob.champion@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/CAOYmi+=pg=W5L1h=3MEP_EB24jaBu2FyATrLXqQHGe7cpuvwyg@mail.gmail...

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e9e05c655069139ff1533497073d980994dde290

Modified Files
--------------
src/interfaces/ecpg/compatlib/informix.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert ECPG's use of pnstrdup()
@ 2024-08-08 06:07  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Eisentraut @ 2024-08-08 06:07 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert ECPG's use of pnstrdup()

Commit 0b9466fce added a dependency on fe_memutils' pnstrdup() inside
informix.c.  This adds an exit() path in a library, which we don't
want.  (Unlike libpq, the ecpg libraries don't have an automated check
for that, but it makes sense to keep them to a similar standard.)  The
ecpg code can already handle failure results from the *strdup() call
by itself.

Author: Jacob Champion <jacob.champion@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/CAOYmi+=pg=W5L1h=3MEP_EB24jaBu2FyATrLXqQHGe7cpuvwyg@mail.gmail...

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f0096ef13be263cfefb0b47e48c00a0e2fbfef06

Modified Files
--------------
src/interfaces/ecpg/compatlib/informix.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert ECPG's use of pnstrdup()
@ 2024-08-08 06:07  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Eisentraut @ 2024-08-08 06:07 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert ECPG's use of pnstrdup()

Commit 0b9466fce added a dependency on fe_memutils' pnstrdup() inside
informix.c.  This adds an exit() path in a library, which we don't
want.  (Unlike libpq, the ecpg libraries don't have an automated check
for that, but it makes sense to keep them to a similar standard.)  The
ecpg code can already handle failure results from the *strdup() call
by itself.

Author: Jacob Champion <jacob.champion@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/CAOYmi+=pg=W5L1h=3MEP_EB24jaBu2FyATrLXqQHGe7cpuvwyg@mail.gmail...

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3557185538fe7b2e2a04b52a5ed8250597cd0a2d

Modified Files
--------------
src/interfaces/ecpg/compatlib/informix.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert ECPG's use of pnstrdup()
@ 2024-08-08 06:07  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Eisentraut @ 2024-08-08 06:07 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert ECPG's use of pnstrdup()

Commit 0b9466fce added a dependency on fe_memutils' pnstrdup() inside
informix.c.  This adds an exit() path in a library, which we don't
want.  (Unlike libpq, the ecpg libraries don't have an automated check
for that, but it makes sense to keep them to a similar standard.)  The
ecpg code can already handle failure results from the *strdup() call
by itself.

Author: Jacob Champion <jacob.champion@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/CAOYmi+=pg=W5L1h=3MEP_EB24jaBu2FyATrLXqQHGe7cpuvwyg@mail.gmail...

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ee2997c678d86568328f0221717676f86b8aa6f6

Modified Files
--------------
src/interfaces/ecpg/compatlib/informix.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2024-08-08 06:07 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-08-07 07:28 pgsql: Revert ECPG's use of pnstrdup() Peter Eisentraut <peter@eisentraut.org>
2024-08-08 06:07 pgsql: Revert ECPG's use of pnstrdup() Peter Eisentraut <peter@eisentraut.org>
2024-08-08 06:07 pgsql: Revert ECPG's use of pnstrdup() Peter Eisentraut <peter@eisentraut.org>
2024-08-08 06:07 pgsql: Revert ECPG's use of pnstrdup() Peter Eisentraut <peter@eisentraut.org>
2024-08-08 06:07 pgsql: Revert ECPG's use of pnstrdup() Peter Eisentraut <peter@eisentraut.org>
2024-08-08 06:07 pgsql: Revert ECPG's use of pnstrdup() Peter Eisentraut <peter@eisentraut.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox