pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby
2+ messages / 2 participants
[nested] [flat]
* pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby
@ 2024-08-15 21:19 Alexander Korotkov <akorotkov@postgresql.org>
2024-08-15 21:51 ` Re: pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby Alexander Korotkov <aekorotkov@gmail.com>
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Korotkov @ 2024-08-15 21:19 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix GetStrictOldestNonRemovableTransactionId() on standby
e85662df44 implemented GetStrictOldestNonRemovableTransactionId() function
for computation of xid horizon that avoid reporting of false errors.
However, GetStrictOldestNonRemovableTransactionId() uses
GetRunningTransactionData() even on standby leading to an assertion failure.
Given that we decided to ignore KnownAssignedXids and standby can't have
own running xids, we switch to use TransamVariables->nextXid as a xid horizon.
Also, revise the comment regarding ignoring KnownAssignedXids with more
detailed reasoning provided by Heikki.
Reported-by: Heikki Linnakangas
Discussion: https://postgr.es/m/42218c4f-2c8d-40a3-8743-4d34dd0e4cce%40iki.fi
Reviewed-by: Heikki Linnakangas
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e2ed7e32271a82179c3f8c7c93ce52ff93c6dd3c
Modified Files
--------------
contrib/pg_visibility/pg_visibility.c | 26 +++++++++++++++++++---
.../pg_visibility/t/001_concurrent_transaction.pl | 19 ++++++++++++++--
2 files changed, 40 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby
2024-08-15 21:19 pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby Alexander Korotkov <akorotkov@postgresql.org>
@ 2024-08-15 21:51 ` Alexander Korotkov <aekorotkov@gmail.com>
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Korotkov @ 2024-08-15 21:51 UTC (permalink / raw)
To: Alexander Korotkov <akorotkov@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
On Fri, Aug 16, 2024 at 12:19 AM Alexander Korotkov
<akorotkov@postgresql.org> wrote:
>
> Fix GetStrictOldestNonRemovableTransactionId() on standby
>
> e85662df44 implemented GetStrictOldestNonRemovableTransactionId() function
> for computation of xid horizon that avoid reporting of false errors.
> However, GetStrictOldestNonRemovableTransactionId() uses
> GetRunningTransactionData() even on standby leading to an assertion failure.
>
> Given that we decided to ignore KnownAssignedXids and standby can't have
> own running xids, we switch to use TransamVariables->nextXid as a xid horizon.
>
> Also, revise the comment regarding ignoring KnownAssignedXids with more
> detailed reasoning provided by Heikki.
I see the buildfarm failures. I will try to fix them shortly.
------
Regards,
Alexander Korotkov
Supabase
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-08-15 21:51 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-08-15 21:19 pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby Alexander Korotkov <akorotkov@postgresql.org>
2024-08-15 21:51 ` Alexander Korotkov <aekorotkov@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox