pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm
5+ messages / 2 participants
[nested] [flat]
* pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm
@ 2024-08-24 16:18 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Korotkov @ 2024-08-24 16:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) commands
This commit reverts 1adf16b8fb, 87c21bb941, and subsequent fixes and
improvements including df64c81ca9, c99ef1811a, 9dfcac8e15, 885742b9f8,
842c9b2705, fcf80c5d5f, 96c7381c4c, f4fc7cb54b, 60ae37a8bc, 259c96fa8f,
449cdcd486, 3ca43dbbb6, 2a679ae94e, 3a82c689fd, fbd4321fd5, d53a4286d7,
c086896625, 4e5d6c4091, 04158e7fa3.
The reason for reverting is security issues related to repeatable name lookups
(CVE-2014-0062). Even though 04158e7fa3 solved part of the problem, there
are still remaining issues, which aren't feasible to even carefully analyze
before the RC deadline.
Reported-by: Noah Misch, Robert Haas
Discussion: https://postgr.es/m/20240808171351.a9.nmisch%40google.com
Backpatch-through: 17
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3890d90c1508125729ed20038d90513694fc3a7b
Modified Files
--------------
doc/src/sgml/ddl.sgml | 38 -
doc/src/sgml/ref/alter_table.sgml | 165 +-
src/backend/commands/tablecmds.c | 819 +---------
src/backend/parser/gram.y | 61 +-
src/backend/parser/parse_utilcmd.c | 193 +--
src/backend/partitioning/partbounds.c | 901 +----------
src/backend/tcop/utility.c | 6 -
src/backend/utils/adt/ruleutils.c | 18 -
src/bin/psql/tab-complete.c | 18 +-
src/include/nodes/parsenodes.h | 16 -
src/include/parser/kwlist.h | 2 -
src/include/partitioning/partbounds.h | 11 -
src/include/utils/ruleutils.h | 2 -
src/test/isolation/expected/partition-merge.out | 199 ---
src/test/isolation/expected/partition-split.out | 190 ---
src/test/isolation/isolation_schedule | 2 -
src/test/isolation/specs/partition-merge.spec | 54 -
src/test/isolation/specs/partition-split.spec | 54 -
.../modules/test_ddl_deparse/test_ddl_deparse.c | 6 -
src/test/regress/expected/partition_merge.out | 945 ------------
src/test/regress/expected/partition_split.out | 1589 --------------------
src/test/regress/parallel_schedule | 2 +-
src/test/regress/sql/partition_merge.sql | 609 --------
src/test/regress/sql/partition_split.sql | 962 ------------
src/tools/pgindent/typedefs.list | 2 -
25 files changed, 36 insertions(+), 6828 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm
@ 2024-08-24 16:18 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Korotkov @ 2024-08-24 16:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) commands
This commit reverts 1adf16b8fb, 87c21bb941, and subsequent fixes and
improvements including df64c81ca9, c99ef1811a, 9dfcac8e15, 885742b9f8,
842c9b2705, fcf80c5d5f, 96c7381c4c, f4fc7cb54b, 60ae37a8bc, 259c96fa8f,
449cdcd486, 3ca43dbbb6, 2a679ae94e, 3a82c689fd, fbd4321fd5, d53a4286d7,
c086896625, 4e5d6c4091, 04158e7fa3.
The reason for reverting is security issues related to repeatable name lookups
(CVE-2014-0062). Even though 04158e7fa3 solved part of the problem, there
are still remaining issues, which aren't feasible to even carefully analyze
before the RC deadline.
Reported-by: Noah Misch, Robert Haas
Discussion: https://postgr.es/m/20240808171351.a9.nmisch%40google.com
Backpatch-through: 17
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/84f594da358861cceeaeb7a97bb58f3765eeb284
Modified Files
--------------
doc/src/sgml/ddl.sgml | 38 -
doc/src/sgml/ref/alter_table.sgml | 165 +-
src/backend/commands/tablecmds.c | 819 +---------
src/backend/parser/gram.y | 61 +-
src/backend/parser/parse_utilcmd.c | 193 +--
src/backend/partitioning/partbounds.c | 901 +----------
src/backend/tcop/utility.c | 6 -
src/backend/utils/adt/ruleutils.c | 18 -
src/bin/psql/tab-complete.c | 18 +-
src/include/nodes/parsenodes.h | 14 +-
src/include/parser/kwlist.h | 2 -
src/include/partitioning/partbounds.h | 11 -
src/include/utils/ruleutils.h | 2 -
src/test/isolation/expected/partition-merge.out | 199 ---
src/test/isolation/expected/partition-split.out | 190 ---
src/test/isolation/isolation_schedule | 2 -
src/test/isolation/specs/partition-merge.spec | 54 -
src/test/isolation/specs/partition-split.spec | 54 -
.../modules/test_ddl_deparse/test_ddl_deparse.c | 6 -
src/test/regress/expected/partition_merge.out | 945 ------------
src/test/regress/expected/partition_split.out | 1589 --------------------
src/test/regress/parallel_schedule | 2 +-
src/test/regress/sql/partition_merge.sql | 609 --------
src/test/regress/sql/partition_split.sql | 962 ------------
src/tools/pgindent/typedefs.list | 2 -
25 files changed, 40 insertions(+), 6822 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm
@ 2026-08-26 21:56 Alexander Korotkov <akorotkov@postgresql.org>
2026-08-27 01:00 ` Re: pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Korotkov @ 2026-08-26 21:56 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) commands
This commit reverts f2e4cc4279 and 4b3d173629, and the subsequent fixes and
improvements c5ae07a90a, 713e553e32, 52e629be95, ecb2508aaf, 9354896920,
971017c495, 83df16f1fa, e64a9ba2b4, ff8bec8c46, cdae794af3, 57f19774d6, and
881033ae8b. d8af730100 and 0392fb900e cancelled each other out and are not
reverted separately.
The feature is reverted due to multiple design issues which are too late to
address in this release cycle.
Discussion: https://postgr.es/m/CAN4CZFNCU%3Dt09M%3D%2Br2t9hHLJuujdM4oQ8hCK_Sx-GpfiwMAicw%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7612ae8ed8c941985d9cbf60a0674c48f5b0abe5
Modified Files
--------------
doc/src/sgml/ddl.sgml | 38 -
doc/src/sgml/ref/alter_table.sgml | 272 +--
src/backend/catalog/dependency.c | 54 +-
src/backend/catalog/pg_constraint.c | 2 +-
src/backend/commands/tablecmds.c | 1649 +-----------------
src/backend/parser/gram.y | 60 +-
src/backend/parser/parse_utilcmd.c | 338 +---
src/backend/partitioning/partbounds.c | 1054 ------------
src/bin/psql/tab-complete.in.c | 18 +-
src/include/catalog/dependency.h | 2 -
src/include/nodes/parsenodes.h | 34 +-
src/include/parser/kwlist.h | 2 -
src/include/partitioning/partbounds.h | 10 -
src/test/isolation/expected/partition-merge.out | 243 ---
src/test/isolation/expected/partition-split.out | 230 ---
src/test/isolation/isolation_schedule | 2 -
src/test/isolation/specs/partition-merge.spec | 62 -
src/test/isolation/specs/partition-split.spec | 62 -
.../test_ddl_deparse/expected/alter_table.out | 10 -
.../modules/test_ddl_deparse/sql/alter_table.sql | 7 -
.../modules/test_ddl_deparse/test_ddl_deparse.c | 6 -
.../test_extensions/expected/test_extdepend.out | 120 --
.../modules/test_extensions/sql/test_extdepend.sql | 104 --
src/test/regress/expected/partition_merge.out | 1174 -------------
src/test/regress/expected/partition_split.out | 1758 --------------------
src/test/regress/parallel_schedule | 2 +-
src/test/regress/sql/partition_merge.sql | 846 ----------
src/test/regress/sql/partition_split.sql | 1263 --------------
src/tools/pgindent/typedefs.list | 3 -
29 files changed, 46 insertions(+), 9379 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm
2026-08-26 21:56 pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm Alexander Korotkov <akorotkov@postgresql.org>
@ 2026-08-27 01:00 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2026-08-27 01:00 UTC (permalink / raw)
To: Alexander Korotkov <akorotkov@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
Alexander Korotkov <akorotkov@postgresql.org> writes:
> Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) commands
Uh ... I don't see a revert in the v19 branch?
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm
@ 2026-08-27 08:14 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Korotkov @ 2026-08-27 08:14 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) commands
This commit reverts f2e4cc4279 and 4b3d173629, and the subsequent fixes and
improvements c5ae07a90a, 713e553e32, 52e629be95, ecb2508aaf, 9354896920,
971017c495, 83df16f1fa, e64a9ba2b4, ff8bec8c46, cdae794af3, 57f19774d6, and
881033ae8b. d8af730100 and 0392fb900e cancelled each other out and are not
reverted separately.
The feature is reverted due to multiple design issues which are too late to
address in this release cycle.
Discussion: https://postgr.es/m/CAN4CZFNCU%3Dt09M%3D%2Br2t9hHLJuujdM4oQ8hCK_Sx-GpfiwMAicw%40mail.gmail.com
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/3e8bcc8644feaa9ca1cc954197b6994817af4290
Modified Files
--------------
doc/src/sgml/ddl.sgml | 38 -
doc/src/sgml/ref/alter_table.sgml | 272 +--
src/backend/catalog/dependency.c | 54 +-
src/backend/catalog/pg_constraint.c | 2 +-
src/backend/commands/tablecmds.c | 1649 +-----------------
src/backend/parser/gram.y | 60 +-
src/backend/parser/parse_utilcmd.c | 338 +---
src/backend/partitioning/partbounds.c | 1054 ------------
src/bin/psql/tab-complete.in.c | 18 +-
src/include/catalog/dependency.h | 2 -
src/include/nodes/parsenodes.h | 34 +-
src/include/parser/kwlist.h | 2 -
src/include/partitioning/partbounds.h | 10 -
src/test/isolation/expected/partition-merge.out | 243 ---
src/test/isolation/expected/partition-split.out | 230 ---
src/test/isolation/isolation_schedule | 2 -
src/test/isolation/specs/partition-merge.spec | 62 -
src/test/isolation/specs/partition-split.spec | 62 -
.../test_ddl_deparse/expected/alter_table.out | 10 -
.../modules/test_ddl_deparse/sql/alter_table.sql | 7 -
.../modules/test_ddl_deparse/test_ddl_deparse.c | 6 -
.../test_extensions/expected/test_extdepend.out | 120 --
.../modules/test_extensions/sql/test_extdepend.sql | 104 --
src/test/regress/expected/partition_merge.out | 1174 -------------
src/test/regress/expected/partition_split.out | 1758 --------------------
src/test/regress/parallel_schedule | 2 +-
src/test/regress/sql/partition_merge.sql | 846 ----------
src/test/regress/sql/partition_split.sql | 1263 --------------
src/tools/pgindent/typedefs.list | 3 -
29 files changed, 46 insertions(+), 9379 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-08-27 08:14 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-08-24 16:18 pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm Alexander Korotkov <akorotkov@postgresql.org>
2024-08-24 16:18 pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm Alexander Korotkov <akorotkov@postgresql.org>
2026-08-26 21:56 pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm Alexander Korotkov <akorotkov@postgresql.org>
2026-08-27 01:00 ` Tom Lane <tgl@sss.pgh.pa.us>
2026-08-27 08:14 pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm Alexander Korotkov <akorotkov@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox