pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Disallow USING clause when altering type of generated column 7+ messages / 1 participants [nested] [flat]
* pgsql: Disallow USING clause when altering type of generated column @ 2024-08-29 07:07 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2024-08-29 07:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow USING clause when altering type of generated column This does not make sense. It would write the output of the USING clause into the converted column, which would violate the generation expression. This adds a check to error out if this is specified. There was a test for this, but that test errored out for a different reason, so it was not effective. Reported-by: Jian He <jian.universality@gmail.com> Reviewed-by: Yugo NAGATA <nagata@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/flat/c7083982-69f4-4b14-8315-f9ddb20b9834%40eisentraut.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cf49a606c416634fd6af82eb559331fd6052835d Modified Files -------------- src/backend/commands/tablecmds.c | 13 ++++++++++++- src/test/regress/expected/generated.out | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow USING clause when altering type of generated column @ 2024-08-29 07:07 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2024-08-29 07:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow USING clause when altering type of generated column This does not make sense. It would write the output of the USING clause into the converted column, which would violate the generation expression. This adds a check to error out if this is specified. There was a test for this, but that test errored out for a different reason, so it was not effective. Reported-by: Jian He <jian.universality@gmail.com> Reviewed-by: Yugo NAGATA <nagata@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/flat/c7083982-69f4-4b14-8315-f9ddb20b9834%40eisentraut.org Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fdbf7e46a46d2ce8a215b37870b14ee2d7cf0fda Modified Files -------------- src/backend/commands/tablecmds.c | 13 ++++++++++++- src/test/regress/expected/generated.out | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow USING clause when altering type of generated column @ 2024-08-29 07:07 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2024-08-29 07:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow USING clause when altering type of generated column This does not make sense. It would write the output of the USING clause into the converted column, which would violate the generation expression. This adds a check to error out if this is specified. There was a test for this, but that test errored out for a different reason, so it was not effective. Reported-by: Jian He <jian.universality@gmail.com> Reviewed-by: Yugo NAGATA <nagata@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/flat/c7083982-69f4-4b14-8315-f9ddb20b9834%40eisentraut.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ecd19a3cc1879118424ce730369dcfe3d7a41d75 Modified Files -------------- src/backend/commands/tablecmds.c | 13 ++++++++++++- src/test/regress/expected/generated.out | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow USING clause when altering type of generated column @ 2024-08-29 07:07 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2024-08-29 07:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow USING clause when altering type of generated column This does not make sense. It would write the output of the USING clause into the converted column, which would violate the generation expression. This adds a check to error out if this is specified. There was a test for this, but that test errored out for a different reason, so it was not effective. Reported-by: Jian He <jian.universality@gmail.com> Reviewed-by: Yugo NAGATA <nagata@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/flat/c7083982-69f4-4b14-8315-f9ddb20b9834%40eisentraut.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5867ee0056a2db40160926e1a4684d435a099ef4 Modified Files -------------- src/backend/commands/tablecmds.c | 13 ++++++++++++- src/test/regress/expected/generated.out | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow USING clause when altering type of generated column @ 2024-08-29 07:07 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2024-08-29 07:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow USING clause when altering type of generated column This does not make sense. It would write the output of the USING clause into the converted column, which would violate the generation expression. This adds a check to error out if this is specified. There was a test for this, but that test errored out for a different reason, so it was not effective. Reported-by: Jian He <jian.universality@gmail.com> Reviewed-by: Yugo NAGATA <nagata@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/flat/c7083982-69f4-4b14-8315-f9ddb20b9834%40eisentraut.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4d68a043245a6947d676a216aaac0714bcaf97d5 Modified Files -------------- src/backend/commands/tablecmds.c | 13 ++++++++++++- src/test/regress/expected/generated.out | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow USING clause when altering type of generated column @ 2024-08-29 07:07 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2024-08-29 07:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow USING clause when altering type of generated column This does not make sense. It would write the output of the USING clause into the converted column, which would violate the generation expression. This adds a check to error out if this is specified. There was a test for this, but that test errored out for a different reason, so it was not effective. Reported-by: Jian He <jian.universality@gmail.com> Reviewed-by: Yugo NAGATA <nagata@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/flat/c7083982-69f4-4b14-8315-f9ddb20b9834%40eisentraut.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1c57ae795b3c0650cbac13e0f59f326ddc34c5d0 Modified Files -------------- src/backend/commands/tablecmds.c | 13 ++++++++++++- src/test/regress/expected/generated.out | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow USING clause when altering type of generated column @ 2024-08-29 07:07 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2024-08-29 07:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow USING clause when altering type of generated column This does not make sense. It would write the output of the USING clause into the converted column, which would violate the generation expression. This adds a check to error out if this is specified. There was a test for this, but that test errored out for a different reason, so it was not effective. Reported-by: Jian He <jian.universality@gmail.com> Reviewed-by: Yugo NAGATA <nagata@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/flat/c7083982-69f4-4b14-8315-f9ddb20b9834%40eisentraut.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7589d5c5b98dee21541214950d8a303c6979dd78 Modified Files -------------- src/backend/commands/tablecmds.c | 13 ++++++++++++- src/test/regress/expected/generated.out | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-08-29 07:07 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-08-29 07:07 pgsql: Disallow USING clause when altering type of generated column Peter Eisentraut <peter@eisentraut.org> 2024-08-29 07:07 pgsql: Disallow USING clause when altering type of generated column Peter Eisentraut <peter@eisentraut.org> 2024-08-29 07:07 pgsql: Disallow USING clause when altering type of generated column Peter Eisentraut <peter@eisentraut.org> 2024-08-29 07:07 pgsql: Disallow USING clause when altering type of generated column Peter Eisentraut <peter@eisentraut.org> 2024-08-29 07:07 pgsql: Disallow USING clause when altering type of generated column Peter Eisentraut <peter@eisentraut.org> 2024-08-29 07:07 pgsql: Disallow USING clause when altering type of generated column Peter Eisentraut <peter@eisentraut.org> 2024-08-29 07:07 pgsql: Disallow USING clause when altering type of generated column Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox