pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Avoid installcheck failure in TAP tests using injection_points 2+ messages / 1 participants [nested] [flat]
* pgsql: Avoid installcheck failure in TAP tests using injection_points @ 2024-09-03 23:56 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2024-09-03 23:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid installcheck failure in TAP tests using injection_points These tests depend on the test module injection_points to be installed, but it may not be available as the contents of src/test/modules/ are not installed by default. This commit adds a workaround based on a scan of pg_available_extensions to check if the extension is available, skipping the test if it is not. This allows installcheck to work transparently. There are more tests impacted by this problem on HEAD, but for now this addresses only the tests that exist on HEAD and v17 as the release is close by. Reported-by: Maxim Orlov Discussion: https://postgr.es/m/CACG=ezZkoT-pFz6a9XnyToiuR-Wg8fGELqHLoyBodr+2h-77qA@mail.gmail.com Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/2cdcae9da6968ed1057bfc67442fd9e0dcbbc31d Modified Files -------------- src/test/modules/test_misc/t/005_timeouts.pl | 12 ++++++++++++ src/test/recovery/t/041_checkpoint_at_promote.pl | 11 +++++++++++ 2 files changed, 23 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Avoid installcheck failure in TAP tests using injection_points @ 2024-09-03 23:56 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2024-09-03 23:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid installcheck failure in TAP tests using injection_points These tests depend on the test module injection_points to be installed, but it may not be available as the contents of src/test/modules/ are not installed by default. This commit adds a workaround based on a scan of pg_available_extensions to check if the extension is available, skipping the test if it is not. This allows installcheck to work transparently. There are more tests impacted by this problem on HEAD, but for now this addresses only the tests that exist on HEAD and v17 as the release is close by. Reported-by: Maxim Orlov Discussion: https://postgr.es/m/CACG=ezZkoT-pFz6a9XnyToiuR-Wg8fGELqHLoyBodr+2h-77qA@mail.gmail.com Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bab1fd9277c2b1ef9ef70552d95a6e16c1f3cad4 Modified Files -------------- src/test/modules/test_misc/t/005_timeouts.pl | 12 ++++++++++++ src/test/recovery/t/041_checkpoint_at_promote.pl | 11 +++++++++++ 2 files changed, 23 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-09-03 23:56 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-09-03 23:56 pgsql: Avoid installcheck failure in TAP tests using injection_points Michael Paquier <michael@paquier.xyz> 2024-09-03 23:56 pgsql: Avoid installcheck failure in TAP tests using injection_points Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox