pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing 4+ messages / 1 participants [nested] [flat]
* pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing @ 2024-09-06 03:07 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Amit Langote @ 2024-09-06 03:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org SQL/JSON: Fix JSON_TABLE() column deparsing The deparsing code in get_json_expr_options() unnecessarily emitted the default column-specific ON ERROR / EMPTY behavior when the top-level ON ERROR behavior in JSON_TABLE was set to ERROR. Fix that by not overriding the column-specific default, determined based on the column's JsonExprOp in get_json_table_columns(), with JSON_BEHAVIOR_ERROR when that is the top-level ON ERROR behavior. Note that this only removes redundancy; the current deparsing output is not incorrect, just redundant. Reviewed-by: Jian He <jian.universality@gmail.com> Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c88ce386c4d7bfeb437ff31ec7c23c392c862e77 Modified Files -------------- src/backend/utils/adt/ruleutils.c | 8 ++++---- src/test/regress/expected/sqljson_jsontable.out | 18 ++++++++++++++++++ src/test/regress/sql/sqljson_jsontable.sql | 5 +++++ 3 files changed, 27 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing @ 2024-09-06 03:07 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Amit Langote @ 2024-09-06 03:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org SQL/JSON: Fix JSON_TABLE() column deparsing The deparsing code in get_json_expr_options() unnecessarily emitted the default column-specific ON ERROR / EMPTY behavior when the top-level ON ERROR behavior in JSON_TABLE was set to ERROR. Fix that by not overriding the column-specific default, determined based on the column's JsonExprOp in get_json_table_columns(), with JSON_BEHAVIOR_ERROR when that is the top-level ON ERROR behavior. Note that this only removes redundancy; the current deparsing output is not incorrect, just redundant. Reviewed-by: Jian He <jian.universality@gmail.com> Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/68222851d5a8d2ca152a97ee69fe18a95970ed20 Modified Files -------------- src/backend/utils/adt/ruleutils.c | 8 ++++---- src/test/regress/expected/sqljson_jsontable.out | 18 ++++++++++++++++++ src/test/regress/sql/sqljson_jsontable.sql | 5 +++++ 3 files changed, 27 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing @ 2024-09-06 07:52 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Amit Langote @ 2024-09-06 07:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org SQL/JSON: Fix JSON_TABLE() column deparsing The deparsing code in get_json_expr_options() unnecessarily emitted the default column-specific ON ERROR / EMPTY behavior when the top-level ON ERROR behavior in JSON_TABLE was set to ERROR. Fix that by not overriding the column-specific default, determined based on the column's JsonExprOp in get_json_table_columns(), with JSON_BEHAVIOR_ERROR when that is the top-level ON ERROR behavior. Note that this only removes redundancy; the current deparsing output is not incorrect, just redundant. Reviewed-by: Jian He <jian.universality@gmail.com> Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cd680b39211c5c3c88a143abcac576a22f996d7a Modified Files -------------- src/backend/utils/adt/ruleutils.c | 8 ++++---- src/test/regress/expected/sqljson_jsontable.out | 23 +++++++++++++++++++++++ src/test/regress/sql/sqljson_jsontable.sql | 10 ++++++++++ 3 files changed, 37 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing @ 2024-09-06 07:53 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Amit Langote @ 2024-09-06 07:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org SQL/JSON: Fix JSON_TABLE() column deparsing The deparsing code in get_json_expr_options() unnecessarily emitted the default column-specific ON ERROR / EMPTY behavior when the top-level ON ERROR behavior in JSON_TABLE was set to ERROR. Fix that by not overriding the column-specific default, determined based on the column's JsonExprOp in get_json_table_columns(), with JSON_BEHAVIOR_ERROR when that is the top-level ON ERROR behavior. Note that this only removes redundancy; the current deparsing output is not incorrect, just redundant. Reviewed-by: Jian He <jian.universality@gmail.com> Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ee75a03f37fc27c7f07a21dc22edf4511e31a4a1 Modified Files -------------- src/backend/utils/adt/ruleutils.c | 8 ++++---- src/test/regress/expected/sqljson_jsontable.out | 23 +++++++++++++++++++++++ src/test/regress/sql/sqljson_jsontable.sql | 10 ++++++++++ 3 files changed, 37 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-09-06 07:53 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-09-06 03:07 pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing Amit Langote <amitlan@postgresql.org> 2024-09-06 03:07 pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing Amit Langote <amitlan@postgresql.org> 2024-09-06 07:52 pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing Amit Langote <amitlan@postgresql.org> 2024-09-06 07:53 pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing Amit Langote <amitlan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox