pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix contrib/pageinspect's test for sequences.
7+ messages / 1 participants
[nested] [flat]
* pgsql: Fix contrib/pageinspect's test for sequences.
@ 2024-09-13 15:18 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-09-13 15:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix contrib/pageinspect's test for sequences.
I managed to break this test in two different ways in commit
05036a3155.
First, the output of the new call to tuple_data_split() on the test
sequence is dependent on endianness. This is fixed by setting a
special start value for the test sequence that produces the same
output regardless of the endianness of the machine.
Second, on versions older than v15, the new test case fails under
"force_parallel_mode = regress" with the following error:
ERROR: cannot access temporary tables during a parallel operation
This is because pageinspect's disk-accessing functions are
incorrectly marked PARALLEL SAFE on versions older than v15 (see
commit aeaaf520f4 for details). This one is fixed by changing the
test sequence to be permanent. The only reason it was previously
marked temporary was to avoid needing a DROP SEQUENCE command at
the end of the test. Unlike some other tests in this file, the use
of a permanent sequence here shouldn't result in any test
instability like what was fixed by commit e2933a6e11.
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/ZuOKOut5hhDlf_bP%40nathan
Backpatch-through: 12
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/70d1c664f4376fd3499e3b0c6888cf39b65d722b
Modified Files
--------------
contrib/pageinspect/expected/page.out | 5 +++--
contrib/pageinspect/sql/page.sql | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix contrib/pageinspect's test for sequences.
@ 2024-09-13 15:18 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-09-13 15:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix contrib/pageinspect's test for sequences.
I managed to break this test in two different ways in commit
05036a3155.
First, the output of the new call to tuple_data_split() on the test
sequence is dependent on endianness. This is fixed by setting a
special start value for the test sequence that produces the same
output regardless of the endianness of the machine.
Second, on versions older than v15, the new test case fails under
"force_parallel_mode = regress" with the following error:
ERROR: cannot access temporary tables during a parallel operation
This is because pageinspect's disk-accessing functions are
incorrectly marked PARALLEL SAFE on versions older than v15 (see
commit aeaaf520f4 for details). This one is fixed by changing the
test sequence to be permanent. The only reason it was previously
marked temporary was to avoid needing a DROP SEQUENCE command at
the end of the test. Unlike some other tests in this file, the use
of a permanent sequence here shouldn't result in any test
instability like what was fixed by commit e2933a6e11.
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/ZuOKOut5hhDlf_bP%40nathan
Backpatch-through: 12
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9b3c3c0fc2061789c10e331ab3b04913f2b09531
Modified Files
--------------
contrib/pageinspect/expected/page.out | 5 +++--
contrib/pageinspect/sql/page.sql | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix contrib/pageinspect's test for sequences.
@ 2024-09-13 15:18 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-09-13 15:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix contrib/pageinspect's test for sequences.
I managed to break this test in two different ways in commit
05036a3155.
First, the output of the new call to tuple_data_split() on the test
sequence is dependent on endianness. This is fixed by setting a
special start value for the test sequence that produces the same
output regardless of the endianness of the machine.
Second, on versions older than v15, the new test case fails under
"force_parallel_mode = regress" with the following error:
ERROR: cannot access temporary tables during a parallel operation
This is because pageinspect's disk-accessing functions are
incorrectly marked PARALLEL SAFE on versions older than v15 (see
commit aeaaf520f4 for details). This one is fixed by changing the
test sequence to be permanent. The only reason it was previously
marked temporary was to avoid needing a DROP SEQUENCE command at
the end of the test. Unlike some other tests in this file, the use
of a permanent sequence here shouldn't result in any test
instability like what was fixed by commit e2933a6e11.
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/ZuOKOut5hhDlf_bP%40nathan
Backpatch-through: 12
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0938a4ecda33ce0630dd4cb01466f8ef4c41f8b4
Modified Files
--------------
contrib/pageinspect/expected/page.out | 5 +++--
contrib/pageinspect/sql/page.sql | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix contrib/pageinspect's test for sequences.
@ 2024-09-13 15:18 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-09-13 15:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix contrib/pageinspect's test for sequences.
I managed to break this test in two different ways in commit
05036a3155.
First, the output of the new call to tuple_data_split() on the test
sequence is dependent on endianness. This is fixed by setting a
special start value for the test sequence that produces the same
output regardless of the endianness of the machine.
Second, on versions older than v15, the new test case fails under
"force_parallel_mode = regress" with the following error:
ERROR: cannot access temporary tables during a parallel operation
This is because pageinspect's disk-accessing functions are
incorrectly marked PARALLEL SAFE on versions older than v15 (see
commit aeaaf520f4 for details). This one is fixed by changing the
test sequence to be permanent. The only reason it was previously
marked temporary was to avoid needing a DROP SEQUENCE command at
the end of the test. Unlike some other tests in this file, the use
of a permanent sequence here shouldn't result in any test
instability like what was fixed by commit e2933a6e11.
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/ZuOKOut5hhDlf_bP%40nathan
Backpatch-through: 12
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a63aef5e496c1db0325845892d946e8569e7f9d6
Modified Files
--------------
contrib/pageinspect/expected/page.out | 5 +++--
contrib/pageinspect/sql/page.sql | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix contrib/pageinspect's test for sequences.
@ 2024-09-13 15:18 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-09-13 15:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix contrib/pageinspect's test for sequences.
I managed to break this test in two different ways in commit
05036a3155.
First, the output of the new call to tuple_data_split() on the test
sequence is dependent on endianness. This is fixed by setting a
special start value for the test sequence that produces the same
output regardless of the endianness of the machine.
Second, on versions older than v15, the new test case fails under
"force_parallel_mode = regress" with the following error:
ERROR: cannot access temporary tables during a parallel operation
This is because pageinspect's disk-accessing functions are
incorrectly marked PARALLEL SAFE on versions older than v15 (see
commit aeaaf520f4 for details). This one is fixed by changing the
test sequence to be permanent. The only reason it was previously
marked temporary was to avoid needing a DROP SEQUENCE command at
the end of the test. Unlike some other tests in this file, the use
of a permanent sequence here shouldn't result in any test
instability like what was fixed by commit e2933a6e11.
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/ZuOKOut5hhDlf_bP%40nathan
Backpatch-through: 12
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0970889e352ccef7d1b5f32855b3db02a9946e90
Modified Files
--------------
contrib/pageinspect/expected/page.out | 5 +++--
contrib/pageinspect/sql/page.sql | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix contrib/pageinspect's test for sequences.
@ 2024-09-13 15:18 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-09-13 15:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix contrib/pageinspect's test for sequences.
I managed to break this test in two different ways in commit
05036a3155.
First, the output of the new call to tuple_data_split() on the test
sequence is dependent on endianness. This is fixed by setting a
special start value for the test sequence that produces the same
output regardless of the endianness of the machine.
Second, on versions older than v15, the new test case fails under
"force_parallel_mode = regress" with the following error:
ERROR: cannot access temporary tables during a parallel operation
This is because pageinspect's disk-accessing functions are
incorrectly marked PARALLEL SAFE on versions older than v15 (see
commit aeaaf520f4 for details). This one is fixed by changing the
test sequence to be permanent. The only reason it was previously
marked temporary was to avoid needing a DROP SEQUENCE command at
the end of the test. Unlike some other tests in this file, the use
of a permanent sequence here shouldn't result in any test
instability like what was fixed by commit e2933a6e11.
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/ZuOKOut5hhDlf_bP%40nathan
Backpatch-through: 12
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ef46a73f6941021ad40b342ea637f19fb5144cc8
Modified Files
--------------
contrib/pageinspect/expected/page.out | 5 +++--
contrib/pageinspect/sql/page.sql | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix contrib/pageinspect's test for sequences.
@ 2024-09-13 15:18 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-09-13 15:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix contrib/pageinspect's test for sequences.
I managed to break this test in two different ways in commit
05036a3155.
First, the output of the new call to tuple_data_split() on the test
sequence is dependent on endianness. This is fixed by setting a
special start value for the test sequence that produces the same
output regardless of the endianness of the machine.
Second, on versions older than v15, the new test case fails under
"force_parallel_mode = regress" with the following error:
ERROR: cannot access temporary tables during a parallel operation
This is because pageinspect's disk-accessing functions are
incorrectly marked PARALLEL SAFE on versions older than v15 (see
commit aeaaf520f4 for details). This one is fixed by changing the
test sequence to be permanent. The only reason it was previously
marked temporary was to avoid needing a DROP SEQUENCE command at
the end of the test. Unlike some other tests in this file, the use
of a permanent sequence here shouldn't result in any test
instability like what was fixed by commit e2933a6e11.
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/ZuOKOut5hhDlf_bP%40nathan
Backpatch-through: 12
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e0277d90acf6f328d3dfc804238682490124fbb3
Modified Files
--------------
contrib/pageinspect/expected/page.out | 5 +++--
contrib/pageinspect/sql/page.sql | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-09-13 15:18 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-09-13 15:18 pgsql: Fix contrib/pageinspect's test for sequences. Nathan Bossart <nathan@postgresql.org>
2024-09-13 15:18 pgsql: Fix contrib/pageinspect's test for sequences. Nathan Bossart <nathan@postgresql.org>
2024-09-13 15:18 pgsql: Fix contrib/pageinspect's test for sequences. Nathan Bossart <nathan@postgresql.org>
2024-09-13 15:18 pgsql: Fix contrib/pageinspect's test for sequences. Nathan Bossart <nathan@postgresql.org>
2024-09-13 15:18 pgsql: Fix contrib/pageinspect's test for sequences. Nathan Bossart <nathan@postgresql.org>
2024-09-13 15:18 pgsql: Fix contrib/pageinspect's test for sequences. Nathan Bossart <nathan@postgresql.org>
2024-09-13 15:18 pgsql: Fix contrib/pageinspect's test for sequences. Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox