pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Improve meson's detection of perl build flags 3+ messages / 1 participants [nested] [flat]
* pgsql: Improve meson's detection of perl build flags @ 2024-09-14 14:37 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 3+ messages in thread From: Andrew Dunstan @ 2024-09-14 14:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve meson's detection of perl build flags The current method of detecting perl build flags breaks if the path to perl contains a space. This change makes two improvements. First, instead of getting a list of ldflags and ccdlflags and then trying to filter those out of the reported ldopts, we tell perl to suppress reporting those in the first instance. Second, it tells perl to parse those and output them, one per line. Thus any space on the option in a file name, for example, is preserved. Issue reported off-list by Muralikrishna Bandaru Discussion: https://postgr.es/01117f88-f465-bf6c-9362-083bd72ca305@dunslane.net Backpatch to release 16. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/76f2a0e5479618d48161549a148a37251b4b3d4b Modified Files -------------- meson.build | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Improve meson's detection of perl build flags @ 2024-09-14 14:37 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 3+ messages in thread From: Andrew Dunstan @ 2024-09-14 14:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve meson's detection of perl build flags The current method of detecting perl build flags breaks if the path to perl contains a space. This change makes two improvements. First, instead of getting a list of ldflags and ccdlflags and then trying to filter those out of the reported ldopts, we tell perl to suppress reporting those in the first instance. Second, it tells perl to parse those and output them, one per line. Thus any space on the option in a file name, for example, is preserved. Issue reported off-list by Muralikrishna Bandaru Discussion: https://postgr.es/01117f88-f465-bf6c-9362-083bd72ca305@dunslane.net Backpatch to release 16. Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dc2a660bd983f2675f357d279253256a2aef9836 Modified Files -------------- meson.build | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Improve meson's detection of perl build flags @ 2024-09-14 14:37 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 3+ messages in thread From: Andrew Dunstan @ 2024-09-14 14:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve meson's detection of perl build flags The current method of detecting perl build flags breaks if the path to perl contains a space. This change makes two improvements. First, instead of getting a list of ldflags and ccdlflags and then trying to filter those out of the reported ldopts, we tell perl to suppress reporting those in the first instance. Second, it tells perl to parse those and output them, one per line. Thus any space on the option in a file name, for example, is preserved. Issue reported off-list by Muralikrishna Bandaru Discussion: https://postgr.es/01117f88-f465-bf6c-9362-083bd72ca305@dunslane.net Backpatch to release 16. Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cb52d1cdd1031d3b0d66a001b7b153990a0497c8 Modified Files -------------- meson.build | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-09-14 14:37 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-09-14 14:37 pgsql: Improve meson's detection of perl build flags Andrew Dunstan <andrew@dunslane.net> 2024-09-14 14:37 pgsql: Improve meson's detection of perl build flags Andrew Dunstan <andrew@dunslane.net> 2024-09-14 14:37 pgsql: Improve meson's detection of perl build flags Andrew Dunstan <andrew@dunslane.net>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox