pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Allow meson builds to run test_pg_dump test in installcheck mode
4+ messages / 3 participants
[nested] [flat]
* pgsql: Allow meson builds to run test_pg_dump test in installcheck mode
@ 2024-04-29 23:46 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 4+ messages in thread
From: Tom Lane @ 2024-04-29 23:46 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Allow meson builds to run test_pg_dump test in installcheck mode.
This had been disabled because the test "doesn't delete its user".
It doesn't seem like a great idea for the meson tests to act
differently from the makefile tests, though, and the makefiles
had no such exception (which is how come only copperhead noticed
the problem just fixed in 534287403). In any case, the premise
is false since 936e3fa37, so let's remove the restriction.
Discussion: https://postgr.es/m/2857513.1713733688@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b0c5b215dace219ecf3b42cc2eb90abf7fd7a582
Modified Files
--------------
src/test/modules/test_pg_dump/meson.build | 2 --
1 file changed, 2 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Allow meson builds to run test_pg_dump test in installcheck mode
@ 2024-09-24 03:40 Michael Paquier <michael@paquier.xyz>
2024-09-24 13:42 ` Re: pgsql: Allow meson builds to run test_pg_dump test in installcheck mode Peter Geoghegan <pg@bowt.ie>
0 siblings, 1 reply; 4+ messages in thread
From: Michael Paquier @ 2024-09-24 03:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Allow meson builds to run test_pg_dump test in installcheck mode.
This had been disabled because the test "doesn't delete its user".
It doesn't seem like a great idea for the meson tests to act
differently from the makefile tests, though, and the makefiles
had no such exception (which is how come only copperhead noticed
the problem just fixed in 534287403). In any case, the premise
is false since 936e3fa37, so let's remove the restriction.
Discussion: https://postgr.es/m/2857513.1713733688@sss.pgh.pa.us
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f663f4daf075b75268579c9a19d79de81b18c67b
Author: Tom Lane <tgl@sss.pgh.pa.us>
Modified Files
--------------
src/test/modules/test_pg_dump/meson.build | 2 --
1 file changed, 2 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Allow meson builds to run test_pg_dump test in installcheck mode
2024-09-24 03:40 pgsql: Allow meson builds to run test_pg_dump test in installcheck mode Michael Paquier <michael@paquier.xyz>
@ 2024-09-24 13:42 ` Peter Geoghegan <pg@bowt.ie>
2024-09-24 23:57 ` Re: pgsql: Allow meson builds to run test_pg_dump test in installcheck mode Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 4+ messages in thread
From: Peter Geoghegan @ 2024-09-24 13:42 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
On Mon, Sep 23, 2024 at 11:40 PM Michael Paquier <michael@paquier.xyz> wrote:
> Allow meson builds to run test_pg_dump test in installcheck mode.
This commit has Tom as the git author, and Michael as the git
committer. Was that intentional?
--
Peter Geoghegan
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Allow meson builds to run test_pg_dump test in installcheck mode
2024-09-24 03:40 pgsql: Allow meson builds to run test_pg_dump test in installcheck mode Michael Paquier <michael@paquier.xyz>
2024-09-24 13:42 ` Re: pgsql: Allow meson builds to run test_pg_dump test in installcheck mode Peter Geoghegan <pg@bowt.ie>
@ 2024-09-24 23:57 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 4+ messages in thread
From: Michael Paquier @ 2024-09-24 23:57 UTC (permalink / raw)
To: Peter Geoghegan <pg@bowt.ie>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Sep 24, 2024 at 09:42:59AM -0400, Peter Geoghegan wrote:
> On Mon, Sep 23, 2024 at 11:40 PM Michael Paquier <michael@paquier.xyz> wrote:
> > Allow meson builds to run test_pg_dump test in installcheck mode.
>
> This commit has Tom as the git author, and Michael as the git
> committer. Was that intentional?
As a cherry-pick of an existing patch to an older branch, that's
intentional. I got remarks in the past that it was not right to do a
--reset-author in such cases.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-09-24 23:57 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-04-29 23:46 pgsql: Allow meson builds to run test_pg_dump test in installcheck mode Tom Lane <tgl@sss.pgh.pa.us>
2024-09-24 03:40 pgsql: Allow meson builds to run test_pg_dump test in installcheck mode Michael Paquier <michael@paquier.xyz>
2024-09-24 13:42 ` Peter Geoghegan <pg@bowt.ie>
2024-09-24 23:57 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox